From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>,
David Brownell <david-b@pacbell.net>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC/PATCH 1/2] mfd: twl6030-irq: move to threaded_irq
Date: Tue, 28 Dec 2010 15:46:17 +0000 [thread overview]
Message-ID: <20101228154617.GC14860@sirena.org.uk> (raw)
In-Reply-To: <1293544790-793-2-git-send-email-balbi@ti.com>
On Tue, Dec 28, 2010 at 03:59:49PM +0200, Felipe Balbi wrote:
> + disable_irq_nosync(irq);
You shouldn't need this any more; the driver used to be faffing around
with this because it wasn't using genirq for this in the past.
> + for (i = 0; sts.int_sts; sts.int_sts >>= 1, i++) {
> + local_irq_disable();
Simiarly here as far as I know; the original code predates genirq
support for this so is doing some hairy stuff that is no longer
required and may actually be harmful.
What I'd expect to see from a conversion like this would be that most of
the locking/IRQ management stuff would be dropped and the bus_lock() and
bus_sync_unlock() operations would be implemented.
next prev parent reply other threads:[~2010-12-28 15:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-28 13:59 [RFC/PATCH 0/2] Move twl*-irq.c to threaded_irq infrastructure Felipe Balbi
2010-12-28 13:59 ` [RFC/PATCH 1/2] mfd: twl6030-irq: move to threaded_irq Felipe Balbi
2010-12-28 15:46 ` Mark Brown [this message]
2010-12-28 16:16 ` Felipe Balbi
2010-12-28 17:14 ` [RFC/PATCH 0/3] TWL4030 IRQ Changes Felipe Balbi
2010-12-28 17:14 ` [RFC/PATCH 1/3] mfd: twl4030-irq: move to threaded_irq Felipe Balbi
2010-12-28 17:14 ` [RFC/PATCH 2/3] mfd: twl4030-irq: drop the workqueue hackery Felipe Balbi
2010-12-28 17:14 ` [RFC/PATCH 3/3] mfd: twl4030-irq: implement bus_*lock Felipe Balbi
2010-12-28 23:58 ` Mark Brown
2010-12-29 0:38 ` Felipe Balbi
2010-12-29 12:28 ` Felipe Balbi
2010-12-30 12:18 ` Mark Brown
2010-12-30 12:26 ` Felipe Balbi
2010-12-28 17:36 ` [RFC/PATCH 0/3] TWL4030 IRQ Changes Felipe Balbi
2010-12-28 17:41 ` Mark Brown
2010-12-29 0:39 ` Felipe Balbi
2010-12-28 17:40 ` [RFC/PATCH 1/2] mfd: twl6030-irq: move to threaded_irq David Brownell
2010-12-28 17:45 ` Mark Brown
2010-12-28 13:59 ` [RFC/PATCH 2/2] mfd: twl4030-irq: " Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101228154617.GC14860@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=balbi@ti.com \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox