Re: [PATCH 5/5] MAP4: DMIC: Add DMIC codec platform devices

Felipe Balbi
2010-12-28T11:23:34Z

Hi,

$SUBJECT should read OMAP4 instead of MAP4

On Mon, Dec 27, 2010 at 10:17:06PM -0600, David Lambert wrote:
>This creates the DMIC codec platform devices.
>
>The platform devices create an instance of the driver during boot up.
>
>Signed-off-by: David Lambert <dlambert@ti.com>

is this a "virtual" device ? If not, where's HWMOD for it ?

>diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c
>index df5a425..bf271e5 100644
>--- a/arch/arm/mach-omap2/board-4430sdp.c
>+++ b/arch/arm/mach-omap2/board-4430sdp.c
>@@ -505,6 +505,16 @@ static void __init omap_sfh7741prox_init(void)
> }
> }
>
>+static struct platform_device codec_dmic0 = {
>+ .name = "dmic-codec",
>+ .id = 0,

if this is the only device, should id be -1 instead ?

>+};
>+
>+static inline void omap_dmic_init(void)
>+{
>+ platform_device_register(&codec_dmic0);

Another option would be to use
platform_device_register_simple("dmi-codec", -1);

--
balbi