Re: [PATCH 1/5] ASoC: DMIC: Adding the OMAP DMIC driver

Liam Girdwood
2010-12-29T10:35:36Z

On Wed, 2010-12-29 at 11:47 +0200, Felipe Balbi wrote:
> Hi,
>
> On Tue, Dec 28, 2010 at 07:13:58PM -0600, Lambert, David wrote:
> >> one blank line only. BTW, are these used anywwhere outside the dmic.c
> >> driver ? If not, it's better to move the definitions there.
> >>
> >
> >They were originally in the omap-dmic.h header, but it was suggested
> >that we move
> >them to a platform header so that the driver could be more
> >architecture independent
> >and we could put the platform specific details here. I'm OK putting
> >them just about
> >anywhere, as long as we have consensus.
>
> The thing I don't like about putting register definitions under
> <plat/*.h> is that it creates the need for making the driver "depends on
> ARCH_OMAP" because it's the only architecture which has that file. If
> you put under <linux/*> or directly on the .c source file, you can have
> a much needed compile test with several architectures.
>
> Even though the driver will never work with those other archs, compile
> testing with several of them isn't bad at all.

This seems unnecessary since this driver is for the OMAP platform only
and also means maintainers will have to waste time fixing any build
issues for this driver on irrelevant architectures. The costs here
outweigh any benefits....

It also seems inconsistent with the other OMAP system headers in
plat-omap too.

Liam

--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.