From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Linux OMAP Mailing List <linux-omap@vger.kernel.org>
Subject: Re: [RFT/PATCH 01/10] cbus: retu: give it a context structure
Date: Mon, 3 Jan 2011 17:40:16 -0800 [thread overview]
Message-ID: <20110104014016.GW7771@atomide.com> (raw)
In-Reply-To: <1294040988-21191-2-git-send-email-balbi@ti.com>
* Felipe Balbi <balbi@ti.com> [110102 23:49]:
> This is pretty much a cleanup patch just
> adding a context structure for Retu, to avoid
> all the globals it had.
>
> Note that this breaks retu-user.c due to moving
> the lock around, but that retu-user.c has to
> go anyway as it's completely non-standard way
> of accessing Retu children.
FYI, this one alone fails to compile with:
drivers/cbus/retu-user.c: In function 'retu_user_write_with_mask':
drivers/cbus/retu-user.c:208: error: 'retu_lock' undeclared (first use in this function)
drivers/cbus/retu-user.c:208: error: (Each undeclared identifier is reported only once
drivers/cbus/retu-user.c:208: error: for each function it appears in.)
Regards,
Tony
next prev parent reply other threads:[~2011-01-04 1:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 7:49 [RFT/PATCH 00/10] move retu to threaded IRQ Felipe Balbi
2011-01-03 7:49 ` [RFT/PATCH 01/10] cbus: retu: give it a context structure Felipe Balbi
2011-01-04 1:40 ` Tony Lindgren [this message]
2011-01-04 6:51 ` Felipe Balbi
2011-01-03 7:49 ` [RFT/PATCH 02/10] cbus: retu: get rid of retu-user.c Felipe Balbi
2011-01-03 7:49 ` [RFT/PATCH 03/10] cbus: retu: move module_* close to the matching symbol Felipe Balbi
2011-01-03 7:49 ` [RFT/PATCH 04/10] cbus: retu: cleanup error path Felipe Balbi
2011-01-03 7:49 ` [RFT/PATCH 05/10] cbus: retu: move to threaded IRQ and GENIRQ Felipe Balbi
2011-01-04 1:40 ` Tony Lindgren
2011-01-04 6:52 ` Felipe Balbi
2011-01-04 7:46 ` Felipe Balbi
2011-01-04 7:47 ` Felipe Balbi
2011-01-04 19:14 ` Tony Lindgren
2011-01-05 6:37 ` Felipe Balbi
2011-01-07 3:04 ` Tony Lindgren
2011-01-07 7:48 ` Felipe Balbi
2011-01-07 17:04 ` Tony Lindgren
2011-01-07 19:15 ` Felipe Balbi
2011-01-03 7:49 ` [RFT/PATCH 06/10] cbus: retu: headset: convert to threaded_irq Felipe Balbi
2011-01-03 7:49 ` [RFT/PATCH 07/10] cbus: retu-pwrbutton: convert to threaded irq Felipe Balbi
2011-01-03 7:49 ` [RFT/PATCH 08/10] cbus: retu-rtc: move " Felipe Balbi
2011-01-03 7:49 ` [RFT/PATCH 09/10] cbus: retu-rtc: drop the reset_occurred flag Felipe Balbi
2011-01-03 7:49 ` [RFT/PATCH 10/10] cbus: Makefile: re-enable retu-wdt Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110104014016.GW7771@atomide.com \
--to=tony@atomide.com \
--cc=balbi@ti.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox