From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: Hemant Pedanekar <hemantp@ti.com>,
linux-omap@vger.kernel.org, khilman@deeprootsystems.com
Subject: Re: [PATCH v3 1/4] TI816X: Update common omap platform files
Date: Mon, 3 Jan 2011 17:50:08 -0800 [thread overview]
Message-ID: <20110104015008.GX7771@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1101031603070.10403@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [110103 15:06]:
> Hello Hemant
>
> On Mon, 3 Jan 2011, Hemant Pedanekar wrote:
>
> > This patch updates the common platform files with TI816X support. Also adds new
> > files for TI816X modules base addresseses and irq definitions.
> >
> > The approach taken in this patch is to add TI816X as part of OMAP3 variant where
> > the cpu class is considered as OMAP34XX and the type is TI816X. This means, both
> > cpu_is_omap34xx() and cpu_is_ti816x() checks return success on TI816X.
>
> Looks like you should add a CONFIG_ARCH_OMAPTI816X Kconfig option for this
> chip. I suspect that many handheld device manufacturers won't want to
> include TI816X-specific code/data in their builds, and vice versa.
Please use CONFIG_SOC_OMAPTI816X instead, eventually we should use
CONFIG_ARCH_OMAPX only for something that requires different compiler
options.
Regards,
Tony
next prev parent reply other threads:[~2011-01-04 1:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 17:28 [PATCH v3 1/4] TI816X: Update common omap platform files Hemant Pedanekar
2011-01-03 23:07 ` Paul Walmsley
2011-01-04 1:50 ` Tony Lindgren [this message]
2011-01-04 17:38 ` Pedanekar, Hemant
2011-01-04 17:49 ` Paul Walmsley
2011-01-04 23:25 ` Tony Lindgren
2011-01-04 23:57 ` [PATCH] omap: Start using CONFIG_SOC_OMAP (Re: [PATCH v3 1/4] TI816X: Update common omap platform files) Tony Lindgren
2011-01-05 1:22 ` [PATCH v3 1/4] TI816X: Update common omap platform files Pedanekar, Hemant
2011-01-05 23:59 ` Pedanekar, Hemant
2011-01-07 2:56 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110104015008.GX7771@atomide.com \
--to=tony@atomide.com \
--cc=hemantp@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox