From: Tony Lindgren <tony@atomide.com>
To: Guruswamy Senthilvadivu <svadivu@ti.com>
Cc: tomi.valkeinen@nokia.com, paul@pwsan.com,
khilman@deeprootsystems.com, v-hiremath@ti.com, a0919096@ti.com,
linux-omap@vger.kernel.org
Subject: Re: [PATCH v3 07/17] OMAP2,3: DSS2: Build omap_device for each DSS HWIP
Date: Mon, 3 Jan 2011 17:56:52 -0800 [thread overview]
Message-ID: <20110104015652.GY7771@atomide.com> (raw)
In-Reply-To: <1294059069-26737-8-git-send-email-svadivu@ti.com>
* Guruswamy Senthilvadivu <svadivu@ti.com> [110103 04:51]:
> + char *omap2_oh_name[] = { "dss_dss", "dss_dispc", "dss_rfbi",
> + "dss_venc" };
> + char *omap3_oh_name[] = { "dss_dss", "dss_dispc", "dss_rfbi",
> + "dss_venc", "dss_dsi1" };
> + char *omap2_dev_name[] = { "omap_dss", "omap_dispc", "omap_rfbi",
> + "omap_venc" };
> + char *omap3_dev_name[] = { "omap_dss", "omap_dispc", "omap_rfbi",
> + "omap_venc", "omap_dsi1" };
> + char *(*oh_name)[];
> + char *(*dev_name)[];
> + int oh_count;
> +
> + if (cpu_is_omap24xx()) {
> + oh_name = &omap2_oh_name;
> + dev_name = &omap2_dev_name;
> + oh_count = ARRAY_SIZE(omap2_oh_name);
> + } else {
> + oh_name = &omap3_oh_name;
> + dev_name = &omap3_dev_name;
> + oh_count = ARRAY_SIZE(omap3_oh_name);
> + }
Here it looks like you don't need to repeat the common names
"dss_dss", "dss_dispc", "dss_rfbi". Instead you can have a
common char *omap_oh_name[5] then set oh_count smaller based
on the omap type.
Regards,
Tony
next prev parent reply other threads:[~2011-01-04 1:57 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 12:50 [PATCH v3 00/17] OMAP2,3: hwmod DSS Adaptation Guruswamy Senthilvadivu
2011-01-03 12:50 ` [PATCH v3 01/17] OMAP2420: hwmod data: add DSS DISPC RFBI VENC Guruswamy Senthilvadivu
2011-01-03 12:50 ` [PATCH v3 02/17] OMAP2430: " Guruswamy Senthilvadivu
2011-01-03 12:50 ` [PATCH v3 03/17] OMAP3: hwmod data: add DSS DISPC RFBI DSI VENC Guruswamy Senthilvadivu
2011-01-03 12:50 ` [PATCH v3 04/17] OMAP2,3 DSS2 Change driver name to omap_display Guruswamy Senthilvadivu
2011-01-03 12:50 ` [PATCH v3 05/17] OMAP2,3 DSS2 Use Regulator init with driver name Guruswamy Senthilvadivu
2011-01-03 12:50 ` [PATCH v3 06/17] OMAP2,3 DSS2 Move DSS driver register from board file to devices.c Guruswamy Senthilvadivu
2011-01-04 23:58 ` Kevin Hilman
2011-01-05 10:51 ` Tomi Valkeinen
2011-01-05 10:55 ` Semwal, Sumit
2011-01-03 12:50 ` [PATCH v3 07/17] OMAP2,3: DSS2: Build omap_device for each DSS HWIP Guruswamy Senthilvadivu
2011-01-04 1:56 ` Tony Lindgren [this message]
2011-01-04 12:27 ` Semwal, Sumit
2011-01-03 12:51 ` [PATCH v3 08/17] OMAP2,3: DSS2: Create platform_driver for each DSS HW IP Guruswamy Senthilvadivu
2011-01-05 0:07 ` Kevin Hilman
2011-01-05 3:44 ` Semwal, Sumit
2011-01-05 11:27 ` Tomi Valkeinen
2011-01-05 13:25 ` Semwal, Sumit
2011-01-05 14:58 ` Tomi Valkeinen
2011-01-03 12:51 ` [PATCH v3 09/17] OMAP2,3: DSS2: Move clocks from core driver to dss driver Guruswamy Senthilvadivu
2011-01-05 15:35 ` Tomi Valkeinen
2011-01-06 9:40 ` Semwal, Sumit
2011-01-07 9:14 ` Tomi Valkeinen
2011-01-03 12:51 ` [PATCH v3 10/17] OMAP2,3: DSS2: Move dss_feature_init to dss Guruswamy Senthilvadivu
2011-01-03 12:51 ` [PATCH v3 11/17] OMAP2,3: DSS2: DSS Move init,exit to driver Guruswamy Senthilvadivu
2011-01-03 12:51 ` [PATCH v3 12/17] OMAP2,3: DSS2: RFBI " Guruswamy Senthilvadivu
2011-01-05 15:46 ` Tomi Valkeinen
2011-01-03 12:51 ` [PATCH v3 13/17] OMAP2,3: DSS2: DISPC " Guruswamy Senthilvadivu
2011-01-03 12:51 ` [PATCH v3 14/17] OMAP2,3: DSS2: VENC " Guruswamy Senthilvadivu
2011-01-03 12:51 ` [PATCH v3 15/17] OMAP2,3: DSS2: DSI Move init, exit " Guruswamy Senthilvadivu
2011-01-03 12:51 ` [PATCH v3 16/17] OMAP2,3: DSS2: Use platform device to get baseaddr Guruswamy Senthilvadivu
2011-01-03 12:51 ` [PATCH v3 17/17] OMAP2,3: DSS2: Get DSS IRQ from platform device Guruswamy Senthilvadivu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110104015652.GY7771@atomide.com \
--to=tony@atomide.com \
--cc=a0919096@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=svadivu@ti.com \
--cc=tomi.valkeinen@nokia.com \
--cc=v-hiremath@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox