From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Keerthy <j-keerthy@ti.com>
Cc: "lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"khali@linux-fr.org" <khali@linux-fr.org>,
"mikko.k.ylinen@nokia.com" <mikko.k.ylinen@nokia.com>,
"amit.kucheria@canonical.com" <amit.kucheria@canonical.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"balajitk@ti.com" <balajitk@ti.com>
Subject: Re: [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module
Date: Wed, 5 Jan 2011 21:33:28 -0800 [thread overview]
Message-ID: <20110106053328.GA7489@ericsson.com> (raw)
In-Reply-To: <1294287457-2438-1-git-send-email-j-keerthy@ti.com>
On Wed, Jan 05, 2011 at 11:17:37PM -0500, Keerthy wrote:
> Introducing a driver for MADC on TWL4030 powerIC. MADC stands for monitoring
> ADC. This driver monitors the real time conversion of analog signals like
> battery temperature, battery type, battery level etc. User can also ask for
> the conversion on a particular channel using the sysfs nodes. Tested the
> conversion through sysfs nodes. Tested with DEBUG_LOCKDEP enabled.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>
NACK for:
[...]
> +EXPORT_SYMBOL_GPL(twl4030_madc_conversion);
[...]
> +EXPORT_SYMBOL_GPL(twl4030_get_madc_conversion);
No symbol export from hwmon drivers. Other parts of the kernel
should not depend on HWMON configuration.
I would suggest to check if drivers/staging/iio would be a better fit.
Guenter
next prev parent reply other threads:[~2011-01-06 5:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 4:17 [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module Keerthy
2011-01-06 5:33 ` Guenter Roeck [this message]
2011-01-06 12:07 ` [lm-sensors] " Mark Brown
2011-01-06 15:04 ` Guenter Roeck
2011-01-06 20:21 ` Mark Brown
2011-01-06 21:55 ` Guenter Roeck
2011-01-07 12:12 ` J, KEERTHY
2011-01-07 14:45 ` Guenter Roeck
2011-01-22 16:49 ` J, KEERTHY
2011-01-31 10:43 ` Samuel Ortiz
2011-01-06 5:58 ` Kalliguddi, Hema
2011-01-07 8:40 ` J, KEERTHY
-- strict thread matches above, loose matches on Subject: below --
2011-01-06 3:56 Keerthy
2011-01-06 4:04 ` J, KEERTHY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110106053328.GA7489@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=amit.kucheria@canonical.com \
--cc=balajitk@ti.com \
--cc=j-keerthy@ti.com \
--cc=khali@linux-fr.org \
--cc=linux-omap@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mikko.k.ylinen@nokia.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox