From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module Date: Wed, 5 Jan 2011 21:33:28 -0800 Message-ID: <20110106053328.GA7489@ericsson.com> References: <1294287457-2438-1-git-send-email-j-keerthy@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Received: from imr4.ericy.com ([198.24.6.8]:37751 "EHLO imr4.ericy.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752486Ab1AFFen (ORCPT ); Thu, 6 Jan 2011 00:34:43 -0500 Content-Disposition: inline In-Reply-To: <1294287457-2438-1-git-send-email-j-keerthy@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Keerthy Cc: "lm-sensors@lm-sensors.org" , "sameo@linux.intel.com" , "khali@linux-fr.org" , "mikko.k.ylinen@nokia.com" , "amit.kucheria@canonical.com" , "linux-omap@vger.kernel.org" , "balajitk@ti.com" On Wed, Jan 05, 2011 at 11:17:37PM -0500, Keerthy wrote: > Introducing a driver for MADC on TWL4030 powerIC. MADC stands for monitoring > ADC. This driver monitors the real time conversion of analog signals like > battery temperature, battery type, battery level etc. User can also ask for > the conversion on a particular channel using the sysfs nodes. Tested the > conversion through sysfs nodes. Tested with DEBUG_LOCKDEP enabled. > > Signed-off-by: Keerthy > --- > NACK for: [...] > +EXPORT_SYMBOL_GPL(twl4030_madc_conversion); [...] > +EXPORT_SYMBOL_GPL(twl4030_get_madc_conversion); No symbol export from hwmon drivers. Other parts of the kernel should not depend on HWMON configuration. I would suggest to check if drivers/staging/iio would be a better fit. Guenter