From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: Keerthy <j-keerthy@ti.com>,
"amit.kucheria@canonical.com" <amit.kucheria@canonical.com>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"mikko.k.ylinen@nokia.com" <mikko.k.ylinen@nokia.com>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"balajitk@ti.com" <balajitk@ti.com>
Subject: Re: [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module
Date: Thu, 6 Jan 2011 12:07:13 +0000 [thread overview]
Message-ID: <20110106120713.GD17184@sirena.org.uk> (raw)
In-Reply-To: <20110106053328.GA7489@ericsson.com>
On Wed, Jan 05, 2011 at 09:33:28PM -0800, Guenter Roeck wrote:
> [...]
> > +EXPORT_SYMBOL_GPL(twl4030_madc_conversion);
> [...]
> > +EXPORT_SYMBOL_GPL(twl4030_get_madc_conversion);
> No symbol export from hwmon drivers. Other parts of the kernel
> should not depend on HWMON configuration.
Why? It's not like hwmon has an unreasonably large core or similar.
> I would suggest to check if drivers/staging/iio would be a better fit.
That does have the problem that it's in staging and constantly churning,
though. When I've looked at it it seemed like awfully hard work to use
for devices like this.
What I've done in some of my drivers is put the ADC core in the MFD core
(it's used by both hwmon and power supply function drivers, plus any
board specific stuff people do).
next prev parent reply other threads:[~2011-01-06 12:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 4:17 [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module Keerthy
2011-01-06 5:33 ` Guenter Roeck
2011-01-06 12:07 ` Mark Brown [this message]
2011-01-06 15:04 ` [lm-sensors] " Guenter Roeck
2011-01-06 20:21 ` Mark Brown
2011-01-06 21:55 ` Guenter Roeck
2011-01-07 12:12 ` J, KEERTHY
2011-01-07 14:45 ` Guenter Roeck
2011-01-22 16:49 ` J, KEERTHY
2011-01-31 10:43 ` Samuel Ortiz
2011-01-06 5:58 ` Kalliguddi, Hema
2011-01-07 8:40 ` J, KEERTHY
-- strict thread matches above, loose matches on Subject: below --
2011-01-06 3:56 Keerthy
2011-01-06 12:04 ` [lm-sensors] " Mark Brown
2011-01-07 9:25 ` J, KEERTHY
2011-01-07 10:44 ` Mark Brown
2011-01-07 11:20 ` J, KEERTHY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110106120713.GD17184@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=amit.kucheria@canonical.com \
--cc=balajitk@ti.com \
--cc=guenter.roeck@ericsson.com \
--cc=j-keerthy@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mikko.k.ylinen@nokia.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox