From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module Date: Thu, 6 Jan 2011 20:21:42 +0000 Message-ID: <20110106202142.GC8018@opensource.wolfsonmicro.com> References: <1294287457-2438-1-git-send-email-j-keerthy@ti.com> <20110106053328.GA7489@ericsson.com> <20110106120713.GD17184@sirena.org.uk> <20110106150430.GA9053@ericsson.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from opensource.wolfsonmicro.com ([80.75.67.52]:40733 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751907Ab1AFUV0 (ORCPT ); Thu, 6 Jan 2011 15:21:26 -0500 Content-Disposition: inline In-Reply-To: <20110106150430.GA9053@ericsson.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Guenter Roeck Cc: Keerthy , "amit.kucheria@canonical.com" , "sameo@linux.intel.com" , "mikko.k.ylinen@nokia.com" , "lm-sensors@lm-sensors.org" , "linux-omap@vger.kernel.org" , "balajitk@ti.com" On Thu, Jan 06, 2011 at 07:04:30AM -0800, Guenter Roeck wrote: > On Thu, Jan 06, 2011 at 07:07:13AM -0500, Mark Brown wrote: > > Why? It's not like hwmon has an unreasonably large core or similar. > Because it creates an unnecessary dependency, and because it is not hwmon's > responsibility to provide infrastructure for other subsystems or drivers. hwmon isn't really doing anything, though. The *driver* is doing something but it doesn't really impact the core that much. Not that I'm particularly sold on putting the ADC core in here, but total NACK based on that alone seems rather harsh.