public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-omap@vger.kernel.org
Subject: Re: 4430SDP boot failure
Date: Thu, 6 Jan 2011 12:34:32 -0800	[thread overview]
Message-ID: <20110106203431.GZ7771@atomide.com> (raw)
In-Reply-To: <20110106195225.GX7771@atomide.com>

* Tony Lindgren <tony@atomide.com> [110106 11:52]:
> --- a/arch/arm/boot/compressed/head.S
> +++ b/arch/arm/boot/compressed/head.S
> @@ -71,6 +71,23 @@ wait:		mrc	p14, 0, pc, c0, c1, 0
>  		mov	\rb, #0x50000000
>  		add	\rb, \rb, #0x4000 * CONFIG_S3C_LOWLEVEL_UART_PORT
>  		.endm
> +#elif defined(CONFIG_ARCH_OMAP2PLUS)
> +#include <plat/multi.h>
> +#ifdef MULTI_OMAP2)
                     ^
Looks like my last change to this patch from if defined to ifdef
broke the warning above with an unbalanced bracket..

Thanks Nishant for catching that, updated patch below.

Regards,

Tony


From: Tony Lindgren <tony@atomide.com>
Date: Thu, 6 Jan 2011 11:29:39 -0800
Subject: [PATCH] ARM: Fix low-level decompress debug code for omap

If DEBUG is enabled for decompress code, the system will hang
as the debug UART is not specified. Fix this by adding the
necessary code for omap2plus.

Note that this won't work properly with multi-omap support
compiled in. Also the debug UART used needs to be patched
in if not omap UART3.

Signed-off-by: Tony Lindgren <tony@atomide.com>

--- a/arch/arm/boot/compressed/head.S
+++ b/arch/arm/boot/compressed/head.S
@@ -71,6 +71,23 @@ wait:		mrc	p14, 0, pc, c0, c1, 0
 		mov	\rb, #0x50000000
 		add	\rb, \rb, #0x4000 * CONFIG_S3C_LOWLEVEL_UART_PORT
 		.endm
+#elif defined(CONFIG_ARCH_OMAP2PLUS)
+#include <plat/multi.h>
+#ifdef MULTI_OMAP2
+#error Low-level uncompress debug code won't work with multi-omap
+#elif defined(CONFIG_ARCH_OMAP2)
+		.macro loadsp, rb, tmp
+		ldr	\rb, =OMAP2_UART3_BASE	/* patch accordingly */
+		.endm
+#elif defined(CONFIG_ARCH_OMAP3)
+		.macro loadsp, rb, tmp
+		ldr	\rb, =OMAP3_UART3_BASE	/* patch accordingly */
+		.endm
+#elif defined(CONFIG_ARCH_OMAP4)
+		.macro loadsp, rb, tmp
+		ldr	\rb, =OMAP4_UART3_BASE	/* patch accordingly */
+		.endm
+#endif
 #else
 		.macro	loadsp,	rb, tmp
 		addruart \rb, \tmp

  reply	other threads:[~2011-01-06 20:34 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-06 17:08 4430SDP boot failure Russell King - ARM Linux
2011-01-06 17:25 ` Nishanth Menon
2011-01-06 18:00 ` Russell King - ARM Linux
2011-01-06 18:17   ` Russell King - ARM Linux
2011-01-06 18:25     ` Tony Lindgren
2011-01-06 18:20   ` Tony Lindgren
2011-01-06 19:52     ` Tony Lindgren
2011-01-06 20:34       ` Tony Lindgren [this message]
2011-01-06 20:51         ` Russell King - ARM Linux
2011-01-06 21:11           ` Russell King - ARM Linux
2011-01-06 23:52           ` Russell King - ARM Linux
2011-01-07  4:11             ` Tony Lindgren
2011-01-07  8:39             ` Santosh Shilimkar
2011-01-07  9:28               ` Russell King - ARM Linux
2011-01-07  9:52                 ` Santosh Shilimkar
2011-01-07 12:18                   ` Santosh Shilimkar
2011-01-07 12:24                     ` Santosh Shilimkar
2011-01-07 12:51                     ` Russell King - ARM Linux
2011-01-07 13:07                       ` Koen Kooi
2011-01-07 13:58                         ` Russell King - ARM Linux
2011-01-07 13:09                       ` Santosh Shilimkar
2011-01-07 14:24                         ` Russell King - ARM Linux
2011-01-07 14:26                           ` Santosh Shilimkar
2011-01-07 15:49                             ` 4430SDP boot failure - solved + SPI bug fix Russell King - ARM Linux
2011-01-07 17:10                               ` Tony Lindgren
2011-01-07 17:19                                 ` Grant Likely
2011-01-07 17:25                                   ` Tony Lindgren
2011-01-07 20:24                                     ` Russell King - ARM Linux
2011-01-07 18:25                               ` Santosh Shilimkar
2011-01-07 18:52                                 ` Russell King - ARM Linux
2011-01-07 19:05                                   ` Santosh Shilimkar
2011-01-07 19:19                                     ` Russell King - ARM Linux
2011-01-07 19:28                                       ` Santosh Shilimkar
2011-01-07 20:24                               ` Russell King - ARM Linux
2011-01-07 16:24                             ` 4430SDP boot failure Russell King - ARM Linux
2011-01-07 17:02                               ` Daniel Díaz
2011-01-07 18:29                               ` Santosh Shilimkar
2011-01-07 18:55                                 ` Russell King - ARM Linux
2011-01-06 20:32     ` Russell King - ARM Linux
2011-01-06 20:40       ` Tony Lindgren
2011-01-07 16:12         ` Russell King - ARM Linux
2011-01-10 18:52           ` Tony Lindgren
2011-01-11 23:16             ` [PATCH] omap4: Fix ULPI PHY init for ES1.0 SDP (Re: 4430SDP boot failure) Tony Lindgren
2011-01-13  8:52               ` Anand Gadiyar
2011-01-13  9:15                 ` Russell King - ARM Linux
2011-01-13 15:51                   ` Tony Lindgren
2011-01-13 16:49                     ` Russell King - ARM Linux
2011-01-14 17:29                       ` Tony Lindgren
2011-01-14 19:18                       ` Paul Walmsley
2011-01-14 21:20                         ` Russell King - ARM Linux
2011-01-14 22:07                           ` Paul Walmsley
2011-01-14 23:10                           ` Paul Walmsley
2011-01-14 23:58                             ` Russell King - ARM Linux
2011-01-15  0:12                               ` Tony Lindgren
2011-01-15  0:25                                 ` Russell King - ARM Linux
2011-01-15  0:37                                   ` Tony Lindgren
2011-01-15 17:04                                     ` Russell King - ARM Linux
2011-01-17  8:35                                       ` Sascha Hauer
2011-02-01 12:55               ` Anand Gadiyar
2011-02-02  1:10                 ` Tony Lindgren
2011-02-02  6:05                   ` Santosh Shilimkar
2011-02-02 19:48                     ` Tony Lindgren
2011-02-03  8:43                       ` Santosh Shilimkar
2011-02-12  8:46                         ` Santosh Shilimkar
2011-02-24 17:38                           ` Tony Lindgren
2011-02-25  5:33                             ` Santosh Shilimkar
2011-02-25 17:49                               ` Tony Lindgren
2011-02-02 18:43                   ` Anand Gadiyar
2011-02-02 19:50                     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110106203431.GZ7771@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox