From: Tony Lindgren <tony@atomide.com>
To: Thara Gopinath <thara@ti.com>
Cc: linux-omap@vger.kernel.org, khilman@deeprootsystems.com, khilman@ti.com
Subject: Re: [PATCH] OMAP: Cpufreq: Clean up to support multi omap builds
Date: Thu, 6 Jan 2011 18:06:03 -0800 [thread overview]
Message-ID: <20110107020602.GE7771@atomide.com> (raw)
In-Reply-To: <1294244613-25798-1-git-send-email-thara@ti.com>
* Thara Gopinath <thara@ti.com> [110105 08:23]:
> +#define OMAP1_MPU_CLK "mpu"
> +#define OMAP2_MPU_CLK "virt_prcm_set"
> +#define OMAP3_MPU_CLK "dpll1_ck"
...
> static int __init omap_cpufreq_init(void)
> {
> + if (cpu_class_is_omap1()) {
> + mpu_clk_name = OMAP1_MPU_CLK;
> + arch_cpu_init = omap1_cpu_init;
> + arch_cpu_target = omap1_cpu_target;
> + } else if (cpu_is_omap24xx()) {
> + mpu_clk_name = OMAP2_MPU_CLK;
> + arch_cpu_init = omap1_cpu_init;
> + arch_cpu_target = omap2plus_cpu_target;
> + } else if (cpu_is_omap34xx()) {
> + mpu_clk_name = OMAP3_MPU_CLK;
> + arch_cpu_init = omap3_cpu_init;
> + arch_cpu_target = omap2plus_cpu_target;
> + } else {
> + pr_warning("%s: cpufreq support not yet added\n", __func__);
> + return -EINVAL;
> + }
> +
To me it seems that you should be able to now remove these
just by adding the mpu clock alias to the struct omap_clk
tables?
Tony
prev parent reply other threads:[~2011-01-07 2:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-05 16:23 [PATCH] OMAP: Cpufreq: Clean up to support multi omap builds Thara Gopinath
2011-01-07 2:06 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110107020602.GE7771@atomide.com \
--to=tony@atomide.com \
--cc=khilman@deeprootsystems.com \
--cc=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=thara@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox