From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Eduardo Valentin <eduardo.valentin@nokia.com>
Cc: ext Kevin Hilman <khilman@ti.com>,
Tony Lindgren <tony@atomide.com>,
Linux-OMAP <linux-omap@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] arm: omap: gpio: define .disable callback for gpio irq chip
Date: Fri, 7 Jan 2011 10:11:59 +0000 [thread overview]
Message-ID: <20110107101159.GP31708@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20110107095609.GC6137@besouro.research.nokia.com>
On Fri, Jan 07, 2011 at 11:56:09AM +0200, Eduardo Valentin wrote:
> It is in wakeup-enable gpio. But the driver removes the wakeup
> flag from the gpio on its suspend function right after disabling the irq.
> disable_irq(gpio_irq);
> disable_irq_wake(gpio_irq);
>
> In this case, the device uses gpio 61 as its irq line.
I think the solution to this is to have genirq synchronize the hardware
state with the lazy state on suspend transitions rather than trying to
fix this on a case-by-case basis.
prev parent reply other threads:[~2011-01-07 10:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-05 17:58 [PATCH 1/1] arm: omap: gpio: define .disable callback for gpio irq chip Eduardo Valentin
2011-01-05 18:19 ` Russell King - ARM Linux
2011-01-05 19:24 ` Eduardo Valentin
2011-01-05 20:29 ` Russell King - ARM Linux
2011-01-07 9:00 ` David Brownell
2011-01-05 23:22 ` Kevin Hilman
2011-01-06 6:24 ` Eduardo Valentin
2011-01-06 17:59 ` Kevin Hilman
2011-01-07 9:56 ` Eduardo Valentin
2011-01-07 10:11 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110107101159.GP31708@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=eduardo.valentin@nokia.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox