Re: [RFT/PATCH 05/10] cbus: retu: move to threaded IRQ and GENIRQ

Tony Lindgren
2011-01-04T19:14:02Z

* Felipe Balbi <balbi@ti.com> [110103 23:47]:
> On Tue, Jan 04, 2011 at 09:46:15AM +0200, Felipe Balbi wrote:
> >@@ -593,6 +594,14 @@ static struct twl4030_platform_data sdp3430_twldata = {
> > .vpll2 = &sdp3430_vpll2,
> >};
> >+static void __init sdp3430_twl_init(void)
> >+{
> >+ int irq_base = omap_irq_get_base();
> >+
> >+ sdp3430_twldata.irq_base = irq_base;
> >+ sdp3430_twldata.irq_end = irq_base + TWL4030_BASE_NR_IRQS;
> >+}
> >+
> >static struct i2c_board_info __initdata sdp3430_i2c_boardinfo[] = {
> > {
> > I2C_BOARD_INFO("twl4030", 0x48),
>
> this hunk should be:
>
> @@ -593,6 +594,16 @@ static struct twl4030_platform_data sdp3430_twldata = {
> .vpll2 = &sdp3430_vpll2,
> };
> +static void __init sdp3430_twl_init(void)
> +{
> + int irq_base = omap_irq_get_base();
> +
> + sdp3430_twldata.irq_base = irq_base;
> + sdp3430_twldata.irq_end = irq_base + TWL4030_BASE_NR_IRQS;
> +
> + omap_irq_add(TWL4030_BASE_NR_IRQS);
> +}
> +
> static struct i2c_board_info __initdata sdp3430_i2c_boardinfo[] = {
> {
> I2C_BOARD_INFO("twl4030", 0x48),
>
> otherwise it won't work for other irq_chips

I think there's been some patches related to this to get rid
of NR_IRQS? Might be worth taking a look at those first as it's
a generic solution.

Regards,

Tony