From: Tony Lindgren <tony@atomide.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Paul Walmsley <paul@pwsan.com>, Anand Gadiyar <gadiyar@ti.com>,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
Keshava Munegowda <keshava_mgowda@ti.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Felipe Balbi <balbi@ti.com>
Subject: Re: [PATCH] omap4: Fix ULPI PHY init for ES1.0 SDP (Re: 4430SDP boot failure)
Date: Fri, 14 Jan 2011 16:12:55 -0800 [thread overview]
Message-ID: <20110115001254.GU4957@atomide.com> (raw)
In-Reply-To: <20110114235840.GE22505@n2100.arm.linux.org.uk>
* Russell King - ARM Linux <linux@arm.linux.org.uk> [110114 15:58]:
>
> # ARMv6k
> config CPU_32v6K
> bool "Support ARM V6K processor extensions" if !SMP
> depends on CPU_V6 || CPU_V7
> default y if SMP && !(ARCH_MX3 || ARCH_OMAP2)
>
> OMAP2 prevents the selection of armv6k support. This is probably a very
> bad idea if you want to run the resulting kernel on SMP hardware as it
> removes a barrier in the spinlock code and disables the SMP-safe bitops.
I have some ideas to fix this. Unfortunately it will be inefficient
as spinlock.h can be included from modules too :( I was thinking we can
implement dsb_sev in the proc-*.S functions for the unoptimized multi-arm
builds.
> The original patch which started turning this off was from the MX3 stuff,
> but without explaination.
>
> However, OMAP extended this to disabling the select statement for CPU_32v6K
> even if CPU_V7 is set:
>
> config CPU_V7
> bool "Support ARM V7 processor" if ARCH_INTEGRATOR || MACH_REALVIEW_EB |- select CPU_32v6K
> + select CPU_32v6K if !ARCH_OMAP2
>
> Arguably, SMP _requires_ CPU_32v6K to be enabled for a safe kernel, and this
> patch should not have been merged.
The only way we can fix that is do smp_on_up style rewriting of the assembly
during init between CPUv6 and v6K. Want me to do a patch for that?
For the defconfigs, I have a branch where I occasionally compile all
the old removed defconfigs too. And I believe Kevin test compiles various
PM options.
Tony
next prev parent reply other threads:[~2011-01-15 0:13 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 17:08 4430SDP boot failure Russell King - ARM Linux
2011-01-06 17:25 ` Nishanth Menon
2011-01-06 18:00 ` Russell King - ARM Linux
2011-01-06 18:17 ` Russell King - ARM Linux
2011-01-06 18:25 ` Tony Lindgren
2011-01-06 18:20 ` Tony Lindgren
2011-01-06 19:52 ` Tony Lindgren
2011-01-06 20:34 ` Tony Lindgren
2011-01-06 20:51 ` Russell King - ARM Linux
2011-01-06 21:11 ` Russell King - ARM Linux
2011-01-06 23:52 ` Russell King - ARM Linux
2011-01-07 4:11 ` Tony Lindgren
2011-01-07 8:39 ` Santosh Shilimkar
2011-01-07 9:28 ` Russell King - ARM Linux
2011-01-07 9:52 ` Santosh Shilimkar
2011-01-07 12:18 ` Santosh Shilimkar
2011-01-07 12:24 ` Santosh Shilimkar
2011-01-07 12:51 ` Russell King - ARM Linux
2011-01-07 13:07 ` Koen Kooi
2011-01-07 13:58 ` Russell King - ARM Linux
2011-01-07 13:09 ` Santosh Shilimkar
2011-01-07 14:24 ` Russell King - ARM Linux
2011-01-07 14:26 ` Santosh Shilimkar
2011-01-07 15:49 ` 4430SDP boot failure - solved + SPI bug fix Russell King - ARM Linux
2011-01-07 17:10 ` Tony Lindgren
2011-01-07 17:19 ` Grant Likely
2011-01-07 17:25 ` Tony Lindgren
2011-01-07 20:24 ` Russell King - ARM Linux
2011-01-07 18:25 ` Santosh Shilimkar
2011-01-07 18:52 ` Russell King - ARM Linux
2011-01-07 19:05 ` Santosh Shilimkar
2011-01-07 19:19 ` Russell King - ARM Linux
2011-01-07 19:28 ` Santosh Shilimkar
2011-01-07 20:24 ` Russell King - ARM Linux
2011-01-07 16:24 ` 4430SDP boot failure Russell King - ARM Linux
2011-01-07 17:02 ` Daniel Díaz
2011-01-07 18:29 ` Santosh Shilimkar
2011-01-07 18:55 ` Russell King - ARM Linux
2011-01-06 20:32 ` Russell King - ARM Linux
2011-01-06 20:40 ` Tony Lindgren
2011-01-07 16:12 ` Russell King - ARM Linux
2011-01-10 18:52 ` Tony Lindgren
2011-01-11 23:16 ` [PATCH] omap4: Fix ULPI PHY init for ES1.0 SDP (Re: 4430SDP boot failure) Tony Lindgren
2011-01-13 8:52 ` Anand Gadiyar
2011-01-13 9:15 ` Russell King - ARM Linux
2011-01-13 15:51 ` Tony Lindgren
2011-01-13 16:49 ` Russell King - ARM Linux
2011-01-14 17:29 ` Tony Lindgren
2011-01-14 19:18 ` Paul Walmsley
2011-01-14 21:20 ` Russell King - ARM Linux
2011-01-14 22:07 ` Paul Walmsley
2011-01-14 23:10 ` Paul Walmsley
2011-01-14 23:58 ` Russell King - ARM Linux
2011-01-15 0:12 ` Tony Lindgren [this message]
2011-01-15 0:25 ` Russell King - ARM Linux
2011-01-15 0:37 ` Tony Lindgren
2011-01-15 17:04 ` Russell King - ARM Linux
2011-01-17 8:35 ` Sascha Hauer
2011-02-01 12:55 ` Anand Gadiyar
2011-02-02 1:10 ` Tony Lindgren
2011-02-02 6:05 ` Santosh Shilimkar
2011-02-02 19:48 ` Tony Lindgren
2011-02-03 8:43 ` Santosh Shilimkar
2011-02-12 8:46 ` Santosh Shilimkar
2011-02-24 17:38 ` Tony Lindgren
2011-02-25 5:33 ` Santosh Shilimkar
2011-02-25 17:49 ` Tony Lindgren
2011-02-02 18:43 ` Anand Gadiyar
2011-02-02 19:50 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110115001254.GU4957@atomide.com \
--to=tony@atomide.com \
--cc=balbi@ti.com \
--cc=gadiyar@ti.com \
--cc=keshava_mgowda@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=paul@pwsan.com \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox