From: Russell King <rmk@arm.linux.org.uk>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Aaro Koskinen <aaro.koskinen@nokia.com>,
Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org
Subject: Re: Open issues after 2.6.38 merge window
Date: Mon, 17 Jan 2011 12:50:15 +0000 [thread overview]
Message-ID: <20110117125015.GC18600@flint.arm.linux.org.uk> (raw)
In-Reply-To: <78caabae29d28f26d5d003eeb7e75526@mail.gmail.com>
On Mon, Jan 17, 2011 at 06:05:36PM +0530, Santosh Shilimkar wrote:
> > -----Original Message-----
> > From: Aaro Koskinen [mailto:aaro.koskinen@nokia.com]
> > Sent: Monday, January 17, 2011 5:52 PM
> > To: Santosh Shilimkar
> > Cc: Aaro Koskinen; Tony Lindgren; rmk+kernel@arm.linux.org.uk;
> > linux-omap@vger.kernel.org
> > Subject: RE: Open issues after 2.6.38 merge window
> >
> > Hi,
> >
> > On Mon, 17 Jan 2011, Santosh Shilimkar wrote:
> > >> Amstrad E3 fails during the boot. Bisection points to:
> > >>
> > >> commit 211baa7016894c02fc18693e21ca479cd08ac0c0
> > >> Author: Russell King <rmk+kernel@arm.linux.org.uk>
> > >> Date: Tue Jan 11 16:23:04 2011 +0000
> > >>
> > >> ARM: sched_clock: allow init_sched_clock() to be called
> > >> early
> > >>
> > >> The board does not have sched_clock(), although HAVE_SCHED_CLOCK
> > is
> > >> defined for all OMAP.
> > >>
> > > I guess above is sorted out by the attached patch from Paul.
> >
> > I don't see how it could help? Amstrad E3 is OMAP 15xx.
> >
> I read patch again and omap15xx is skipped. Not sure
> why 15xx is skipped.
EWW. This is horrible - and too far complicated.
So if we build a kernel with OMAP730 or OMAP15xx support, the 32k
counter support is disabled for every platform, which also removes
sched_clock() support (as this uses the 32k timer).
If CONFIG_OMAP_32K_TIMER is also true (eg, because you enabled
OMAP16xx) then we won't have the GP clocksource code. So a kernel
which is configured for OMAP15xx + OMAP16xx won't have any clocksource
code at all.
In effect, all this being done by _negative_ dependencies. As has
been seen with deselecting the V6K configuration symbol, negative
dependencies are Bad News(tm).
This code needs to be restructured for positive dependencies and
proper selection of the appopriate clock sources - which then
needs to be coupled into sched_clock() properly so OMAP15xx can also
benefit from sched_clock() support.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2011-01-17 12:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 19:47 Open issues after 2.6.38 merge window Tony Lindgren
2011-01-14 20:24 ` Tony Lindgren
2011-01-14 20:37 ` Jarkko Nikula
2011-01-14 20:54 ` Tony Lindgren
2011-01-14 22:22 ` Nishanth Menon
2011-01-14 20:57 ` David Anders
2011-01-14 23:38 ` Tony Lindgren
2011-01-14 23:59 ` Tony Lindgren
2011-01-14 23:54 ` Thomas Weber
2011-01-15 5:19 ` Santosh Shilimkar
2011-01-17 10:15 ` Santosh Shilimkar
2011-01-27 18:41 ` Tony Lindgren
2011-01-17 11:37 ` Aaro Koskinen
2011-01-17 11:59 ` Santosh Shilimkar
2011-01-17 12:11 ` Russell King
2011-01-17 12:19 ` Santosh Shilimkar
2011-01-17 12:24 ` Russell King
2011-01-17 18:29 ` Tony Lindgren
2011-01-17 12:22 ` Aaro Koskinen
2011-01-17 12:35 ` Santosh Shilimkar
2011-01-17 12:50 ` Russell King [this message]
2011-01-17 18:20 ` Tony Lindgren
2011-01-17 20:31 ` Paul Walmsley
2011-01-17 20:39 ` Russell King
2011-01-17 21:00 ` Paul Walmsley
2011-01-17 21:19 ` Russell King
2011-01-17 22:49 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110117125015.GC18600@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=aaro.koskinen@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox