* Adio on BeagleBoard XM 2.6.37-rc8
@ 2011-01-19 11:47 Ashok Babu
2011-01-19 13:02 ` Jarkko Nikula
0 siblings, 1 reply; 3+ messages in thread
From: Ashok Babu @ 2011-01-19 11:47 UTC (permalink / raw)
To: linux-omap
Hi folks,
After upgrading to 2.6.37-rc8, I am not able to play any audio.
Fund that the code in sound/soc/omap/omap-mcbsp.c uses the function
"cpu_is_omap343x()" which fails and returns ENODEV.
Does the call should be "cpu_is_omap34xx()" instead ?
Thanks & Regards
Ashok
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Adio on BeagleBoard XM 2.6.37-rc8
2011-01-19 11:47 Adio on BeagleBoard XM 2.6.37-rc8 Ashok Babu
@ 2011-01-19 13:02 ` Jarkko Nikula
2011-01-19 18:51 ` Tony Lindgren
0 siblings, 1 reply; 3+ messages in thread
From: Jarkko Nikula @ 2011-01-19 13:02 UTC (permalink / raw)
To: Ashok Babu; +Cc: linux-omap, Peter Ujfalusi
On Wed, 19 Jan 2011 17:17:11 +0530
Ashok Babu <ashok3d@gmail.com> wrote:
> Hi folks,
>
> After upgrading to 2.6.37-rc8, I am not able to play any audio.
>
> Fund that the code in sound/soc/omap/omap-mcbsp.c uses the function
> "cpu_is_omap343x()" which fails and returns ENODEV.
>
> Does the call should be "cpu_is_omap34xx()" instead ?
>
It looks like so. cpu_is_omap34xx() checks the lowest 8 bits from
omap_rev (that are 0x34 for omap3x ) and cpu_is_omap343x() checks upper
12 bits (that are 0x363 for 3630).
Peter: I think cpu_is_omap343x() tests can be replaced by
cpu_is_omap34xx() in omap-mcbsp.c?
--
Jarkko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Adio on BeagleBoard XM 2.6.37-rc8
2011-01-19 13:02 ` Jarkko Nikula
@ 2011-01-19 18:51 ` Tony Lindgren
0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2011-01-19 18:51 UTC (permalink / raw)
To: Jarkko Nikula; +Cc: Ashok Babu, linux-omap, Peter Ujfalusi
* Jarkko Nikula <jhnikula@gmail.com> [110119 05:01]:
> On Wed, 19 Jan 2011 17:17:11 +0530
> Ashok Babu <ashok3d@gmail.com> wrote:
>
> > Hi folks,
> >
> > After upgrading to 2.6.37-rc8, I am not able to play any audio.
> >
> > Fund that the code in sound/soc/omap/omap-mcbsp.c uses the function
> > "cpu_is_omap343x()" which fails and returns ENODEV.
> >
> > Does the call should be "cpu_is_omap34xx()" instead ?
> >
> It looks like so. cpu_is_omap34xx() checks the lowest 8 bits from
> omap_rev (that are 0x34 for omap3x ) and cpu_is_omap343x() checks upper
> 12 bits (that are 0x363 for 3630).
>
> Peter: I think cpu_is_omap343x() tests can be replaced by
> cpu_is_omap34xx() in omap-mcbsp.c?
For next merge window, can you please git rid of cpu_is_omap
and machine_is usage under drivers?
You can pass the necessary flags in platform data.
Regards,
Tony
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-01-19 18:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-19 11:47 Adio on BeagleBoard XM 2.6.37-rc8 Ashok Babu
2011-01-19 13:02 ` Jarkko Nikula
2011-01-19 18:51 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox