Re: [PATCH] OMAP: use fncpy to copy the PM code functions to SRAM

[Tony Lindgren <tony@atomide.com>]

* Jean Pihet <jean.pihet@newoldbits.com> [110119 13:36]:
> Hi Tony,
> 
> On Wed, Jan 19, 2011 at 8:10 PM, Tony Lindgren <tony@atomide.com> wrote:
> > * Jean Pihet <jean.pihet@newoldbits.com> [110119 00:05]:
> >> On Wed, Jan 19, 2011 at 12:44 AM, Tony Lindgren <tony@atomide.com> wrote:
> >> > * Russell King - ARM Linux <linux@arm.linux.org.uk> [110118 15:41]:
> >> >> On Tue, Jan 18, 2011 at 01:05:49PM +0100, Jean Pihet wrote:
> >> >> > Dave, Russell,
> >> >> >
> >> >> > On Mon, Jan 17, 2011 at 4:46 PM, Dave Martin <dave.martin@linaro.org> wrote:
> >> >> > > One way to work around this is would be to make omap_sram_push() a macro:
> >> >> > >
> >> >> > > #define omap_sram_push(funcp, size) \
> >> >> > >    (typeof(funcp))_do_omap_sram_push((void *)(funcp), size)
> >> >> > >
> >> >> > > ... where the definition of _do_omap_sram_push() is the same is the
> >> >> > > existing definition of omap_sram_push().  Providing
> >> >> > > _do_omap_sram_push() is not called directly, this should now be
> >> >> > > type-safe.
> >> >> > >
> >> >> > Ok I reworked the patch from your suggestions. Indeed a few functions
> >> >> > types mismatch have been spotted and corrected using the fncpy API.
> >> >> >
> >> >> > New patch sent as '[PATCH v2] OMAP: use fncpy to copy the PM code
> >> >> > functions to SRAM'.
> >> >>
> >> >> Looks good, thanks.  Next problem to sort out is who's taking the
> >> >> patches...
> >> >
> >> > You can take them but we should have at least Kevin test and ack them.
> >> Sure, this needs some testing on OMAP1 & 2 platforms. It has only been
> >> compile tested on those (means: compile OK, functions types mismatches
> >> fixed).
> >>
> >> Anyone with OMAP1 & 2 boards willing to test?
> >
> > Can you please repost the whole set one more time or have them in
> > some git branch? That way I can pull them into linux-omap master
> > branch for testing to make sure omap1 and 2 boards don't break.
> There is only patch to apply: '[PATCH v2] OMAP: use fncpy to copy the
> PM code functions to SRAM'
> (http://marc.info/?l=linux-omap&m=129535214414192&w=2) which depends
> on Dave Martin's ([PATCH v4] ARM: Thumb-2: Symbol manipulation macros
> for function body copying'
> (http://marc.info/?l=linux-omap&m=129503990527072&w=2).
> 
> Is this enough? If not I can have them in a branch of a gitorious tree.

OK, will apply them into omap-testing. Then hopefully within next
few days Russell can set up some immutable branch that we can merge
too as some PM patches may conflict with these.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html