From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] OMAP: use fncpy to copy the PM code functions to SRAM Date: Wed, 19 Jan 2011 13:44:22 -0800 Message-ID: <20110119214422.GE4957@atomide.com> References: <20110114173400.GB22505@n2100.arm.linux.org.uk> <20110118234215.GB17398@n2100.arm.linux.org.uk> <20110118234443.GV4957@atomide.com> <20110119191057.GC4957@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:35805 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751973Ab1ASVor (ORCPT ); Wed, 19 Jan 2011 16:44:47 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Jean Pihet Cc: Kevin Hilman , Russell King - ARM Linux , Dave Martin , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Jean Pihet * Jean Pihet [110119 13:36]: > Hi Tony, >=20 > On Wed, Jan 19, 2011 at 8:10 PM, Tony Lindgren wro= te: > > * Jean Pihet [110119 00:05]: > >> On Wed, Jan 19, 2011 at 12:44 AM, Tony Lindgren = wrote: > >> > * Russell King - ARM Linux [110118 15:4= 1]: > >> >> On Tue, Jan 18, 2011 at 01:05:49PM +0100, Jean Pihet wrote: > >> >> > Dave, Russell, > >> >> > > >> >> > On Mon, Jan 17, 2011 at 4:46 PM, Dave Martin wrote: > >> >> > > One way to work around this is would be to make omap_sram_p= ush() a macro: > >> >> > > > >> >> > > #define omap_sram_push(funcp, size) \ > >> >> > > =C2=A0 =C2=A0(typeof(funcp))_do_omap_sram_push((void *)(fun= cp), size) > >> >> > > > >> >> > > ... where the definition of _do_omap_sram_push() is the sam= e is the > >> >> > > existing definition of omap_sram_push(). =C2=A0Providing > >> >> > > _do_omap_sram_push() is not called directly, this should no= w be > >> >> > > type-safe. > >> >> > > > >> >> > Ok I reworked the patch from your suggestions. Indeed a few f= unctions > >> >> > types mismatch have been spotted and corrected using the fncp= y API. > >> >> > > >> >> > New patch sent as '[PATCH v2] OMAP: use fncpy to copy the PM = code > >> >> > functions to SRAM'. > >> >> > >> >> Looks good, thanks. =C2=A0Next problem to sort out is who's tak= ing the > >> >> patches... > >> > > >> > You can take them but we should have at least Kevin test and ack= them. > >> Sure, this needs some testing on OMAP1 & 2 platforms. It has only = been > >> compile tested on those (means: compile OK, functions types mismat= ches > >> fixed). > >> > >> Anyone with OMAP1 & 2 boards willing to test? > > > > Can you please repost the whole set one more time or have them in > > some git branch? That way I can pull them into linux-omap master > > branch for testing to make sure omap1 and 2 boards don't break. > There is only patch to apply: '[PATCH v2] OMAP: use fncpy to copy the > PM code functions to SRAM' > (http://marc.info/?l=3Dlinux-omap&m=3D129535214414192&w=3D2) which de= pends > on Dave Martin's ([PATCH v4] ARM: Thumb-2: Symbol manipulation macros > for function body copying' > (http://marc.info/?l=3Dlinux-omap&m=3D129503990527072&w=3D2). >=20 > Is this enough? If not I can have them in a branch of a gitorious tre= e. OK, will apply them into omap-testing. Then hopefully within next few days Russell can set up some immutable branch that we can merge too as some PM patches may conflict with these. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html