From: Tony Lindgren <tony@atomide.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-omap@vger.kernel.org
Subject: Re: Latest regressions
Date: Wed, 26 Jan 2011 10:15:37 -0800 [thread overview]
Message-ID: <20110126181536.GD23412@atomide.com> (raw)
In-Reply-To: <20110126090157.GA2997@n2100.arm.linux.org.uk>
* Russell King - ARM Linux <linux@arm.linux.org.uk> [110126 01:00]:
> On Fri, Jan 07, 2011 at 08:56:26AM -0800, Tony Lindgren wrote:
> > > diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c
> > > index 17bd639..9eaa28c 100644
> > > --- a/arch/arm/mach-omap2/mux.c
> > > +++ b/arch/arm/mach-omap2/mux.c
> > > @@ -160,7 +160,7 @@ static int __init _omap_mux_get_by_name(struct omap_mux_partition *partition,
> > > struct omap_mux *mux = NULL;
> > > struct omap_mux_entry *e;
> > > const char *mode_name;
> > > - int found = 0, found_mode, mode0_len = 0;
> > > + int found = 0, found_mode = 0, mode0_len = 0;
> > > struct list_head *muxmodes = &partition->muxmodes;
> > >
> > > mode_name = strchr(muxname, '.');
> >
> > Ack.
>
> This one is also still there.
I have a similar patch in devel-cleanup branch queued up from Felipe Balbi.
However, this fixes regression for patch 8419fdbaf2118a0a169441be82f09f7be93a5ca1
(omap2+: Add omap_mux_get_by_name) so this too should be done for the
-rc cycle:
Acked-by: Tony Lindgren <tony@atomide.com>
Again, let me know if you want me to take it.
next prev parent reply other threads:[~2011-01-26 18:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 11:57 Latest regressions Russell King - ARM Linux
2011-01-07 12:58 ` Nishanth Menon
2011-01-07 14:41 ` Russell King - ARM Linux
2011-01-07 14:54 ` Santosh Shilimkar
2011-01-07 14:57 ` Russell King - ARM Linux
2011-01-07 17:12 ` Tony Lindgren
2011-01-07 16:56 ` Tony Lindgren
2011-01-07 21:56 ` Kevin Hilman
2011-01-26 8:58 ` Russell King - ARM Linux
2011-01-26 18:12 ` Tony Lindgren
2011-01-27 12:22 ` Russell King - ARM Linux
2011-01-28 0:18 ` Tony Lindgren
2011-01-28 0:21 ` Tony Lindgren
2011-01-28 0:24 ` Tony Lindgren
2011-01-26 9:01 ` Russell King - ARM Linux
2011-01-26 18:15 ` Tony Lindgren [this message]
2011-01-27 12:22 ` Russell King - ARM Linux
2011-01-28 0:22 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110126181536.GD23412@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox