* [PATCH] OMAP: McBSP: Remove unused audio macros in mcbsp.h
@ 2011-02-04 9:15 Kishon Vijay Abraham I
2011-02-04 9:46 ` Jarkko Nikula
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Kishon Vijay Abraham I @ 2011-02-04 9:15 UTC (permalink / raw)
To: linux-omap; +Cc: Kishon Vijay Abraham I, Jarkko Nikula
Some macros defined in mcbsp.h related to audio, which are never being used
is removed.
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Reviewed-by: Charulatha V <charu@ti.com>
Cc: Jarkko Nikula <jhnikula@gmail.com>
---
arch/arm/plat-omap/include/plat/mcbsp.h | 14 --------------
1 files changed, 0 insertions(+), 14 deletions(-)
diff --git a/arch/arm/plat-omap/include/plat/mcbsp.h b/arch/arm/plat-omap/include/plat/mcbsp.h
index b87d83c..6ecf105 100644
--- a/arch/arm/plat-omap/include/plat/mcbsp.h
+++ b/arch/arm/plat-omap/include/plat/mcbsp.h
@@ -106,13 +106,6 @@ static struct platform_device omap_mcbsp##port_nr = { \
#define OMAP_MCBSP_REG_XCCR 0x00
#define OMAP_MCBSP_REG_RCCR 0x00
-#define AUDIO_MCBSP_DATAWRITE (OMAP1510_MCBSP1_BASE + OMAP_MCBSP_REG_DXR1)
-#define AUDIO_MCBSP_DATAREAD (OMAP1510_MCBSP1_BASE + OMAP_MCBSP_REG_DRR1)
-
-#define AUDIO_MCBSP OMAP_MCBSP1
-#define AUDIO_DMA_TX OMAP_DMA_MCBSP1_TX
-#define AUDIO_DMA_RX OMAP_DMA_MCBSP1_RX
-
#else
#define OMAP_MCBSP_REG_DRR2 0x00
@@ -168,13 +161,6 @@ static struct platform_device omap_mcbsp##port_nr = { \
#define OMAP_ST_REG_SFIRCR 0x28
#define OMAP_ST_REG_SSELCR 0x2C
-#define AUDIO_MCBSP_DATAWRITE (OMAP24XX_MCBSP2_BASE + OMAP_MCBSP_REG_DXR1)
-#define AUDIO_MCBSP_DATAREAD (OMAP24XX_MCBSP2_BASE + OMAP_MCBSP_REG_DRR1)
-
-#define AUDIO_MCBSP OMAP_MCBSP2
-#define AUDIO_DMA_TX OMAP24XX_DMA_MCBSP2_TX
-#define AUDIO_DMA_RX OMAP24XX_DMA_MCBSP2_RX
-
#endif
/************************** McBSP SPCR1 bit definitions ***********************/
--
1.7.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] OMAP: McBSP: Remove unused audio macros in mcbsp.h
2011-02-04 9:15 [PATCH] OMAP: McBSP: Remove unused audio macros in mcbsp.h Kishon Vijay Abraham I
@ 2011-02-04 9:46 ` Jarkko Nikula
2011-02-04 13:45 ` Peter Ujfalusi
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Jarkko Nikula @ 2011-02-04 9:46 UTC (permalink / raw)
To: Kishon Vijay Abraham I; +Cc: linux-omap
On Fri, 4 Feb 2011 14:45:09 +0530
Kishon Vijay Abraham I <kishon@ti.com> wrote:
> Some macros defined in mcbsp.h related to audio, which are never being used
> is removed.
>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> Reviewed-by: Charulatha V <charu@ti.com>
> Cc: Jarkko Nikula <jhnikula@gmail.com>
> ---
> arch/arm/plat-omap/include/plat/mcbsp.h | 14 --------------
> 1 files changed, 0 insertions(+), 14 deletions(-)
>
Acked-by: Jarkko Nikula <jhnikula@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] OMAP: McBSP: Remove unused audio macros in mcbsp.h
2011-02-04 9:15 [PATCH] OMAP: McBSP: Remove unused audio macros in mcbsp.h Kishon Vijay Abraham I
2011-02-04 9:46 ` Jarkko Nikula
@ 2011-02-04 13:45 ` Peter Ujfalusi
2011-02-04 13:57 ` G, Manjunath Kondaiah
2011-02-14 22:58 ` Tony Lindgren
3 siblings, 0 replies; 5+ messages in thread
From: Peter Ujfalusi @ 2011-02-04 13:45 UTC (permalink / raw)
To: ext Kishon Vijay Abraham I; +Cc: linux-omap, Jarkko Nikula
On 02/04/11 11:15, ext Kishon Vijay Abraham I wrote:
> Some macros defined in mcbsp.h related to audio, which are never being used
> is removed.
>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> Reviewed-by: Charulatha V <charu@ti.com>
> Cc: Jarkko Nikula <jhnikula@gmail.com>
> ---
> arch/arm/plat-omap/include/plat/mcbsp.h | 14 --------------
> 1 files changed, 0 insertions(+), 14 deletions(-)
Acked-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] OMAP: McBSP: Remove unused audio macros in mcbsp.h
2011-02-04 9:15 [PATCH] OMAP: McBSP: Remove unused audio macros in mcbsp.h Kishon Vijay Abraham I
2011-02-04 9:46 ` Jarkko Nikula
2011-02-04 13:45 ` Peter Ujfalusi
@ 2011-02-04 13:57 ` G, Manjunath Kondaiah
2011-02-14 22:58 ` Tony Lindgren
3 siblings, 0 replies; 5+ messages in thread
From: G, Manjunath Kondaiah @ 2011-02-04 13:57 UTC (permalink / raw)
To: Kishon Vijay Abraham I; +Cc: linux-omap, Jarkko Nikula
On Fri, Feb 04, 2011 at 02:45:09PM +0530, Kishon Vijay Abraham I wrote:
> Some macros defined in mcbsp.h related to audio, which are never being used
> is removed.
>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> Reviewed-by: Charulatha V <charu@ti.com>
> Cc: Jarkko Nikula <jhnikula@gmail.com>
> ---
> arch/arm/plat-omap/include/plat/mcbsp.h | 14 --------------
> 1 files changed, 0 insertions(+), 14 deletions(-)
>
> diff --git a/arch/arm/plat-omap/include/plat/mcbsp.h b/arch/arm/plat-omap/include/plat/mcbsp.h
> index b87d83c..6ecf105 100644
> --- a/arch/arm/plat-omap/include/plat/mcbsp.h
> +++ b/arch/arm/plat-omap/include/plat/mcbsp.h
> @@ -106,13 +106,6 @@ static struct platform_device omap_mcbsp##port_nr = { \
> #define OMAP_MCBSP_REG_XCCR 0x00
> #define OMAP_MCBSP_REG_RCCR 0x00
>
> -#define AUDIO_MCBSP_DATAWRITE (OMAP1510_MCBSP1_BASE + OMAP_MCBSP_REG_DXR1)
> -#define AUDIO_MCBSP_DATAREAD (OMAP1510_MCBSP1_BASE + OMAP_MCBSP_REG_DRR1)
> -
> -#define AUDIO_MCBSP OMAP_MCBSP1
> -#define AUDIO_DMA_TX OMAP_DMA_MCBSP1_TX
> -#define AUDIO_DMA_RX OMAP_DMA_MCBSP1_RX
Thanks. I have patch in my git repo to cleanup all unwanted dma macros.
I will remove mcbsp dma related declarations in my patch.
Acked-by: G, Manjunath Kondaiah <manjugk@ti.com>
-Manjunath
> -
> #else
>
> #define OMAP_MCBSP_REG_DRR2 0x00
> @@ -168,13 +161,6 @@ static struct platform_device omap_mcbsp##port_nr = { \
> #define OMAP_ST_REG_SFIRCR 0x28
> #define OMAP_ST_REG_SSELCR 0x2C
>
> -#define AUDIO_MCBSP_DATAWRITE (OMAP24XX_MCBSP2_BASE + OMAP_MCBSP_REG_DXR1)
> -#define AUDIO_MCBSP_DATAREAD (OMAP24XX_MCBSP2_BASE + OMAP_MCBSP_REG_DRR1)
> -
> -#define AUDIO_MCBSP OMAP_MCBSP2
> -#define AUDIO_DMA_TX OMAP24XX_DMA_MCBSP2_TX
> -#define AUDIO_DMA_RX OMAP24XX_DMA_MCBSP2_RX
> -
> #endif
>
> /************************** McBSP SPCR1 bit definitions ***********************/
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] OMAP: McBSP: Remove unused audio macros in mcbsp.h
2011-02-04 9:15 [PATCH] OMAP: McBSP: Remove unused audio macros in mcbsp.h Kishon Vijay Abraham I
` (2 preceding siblings ...)
2011-02-04 13:57 ` G, Manjunath Kondaiah
@ 2011-02-14 22:58 ` Tony Lindgren
3 siblings, 0 replies; 5+ messages in thread
From: Tony Lindgren @ 2011-02-14 22:58 UTC (permalink / raw)
To: Kishon Vijay Abraham I; +Cc: linux-omap, Jarkko Nikula
* Kishon Vijay Abraham I <kishon@ti.com> [110204 01:17]:
> Some macros defined in mcbsp.h related to audio, which are never being used
> is removed.
Applying this to devel-cleanup branch for the upcoming merge window.
Tony
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-02-14 22:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-04 9:15 [PATCH] OMAP: McBSP: Remove unused audio macros in mcbsp.h Kishon Vijay Abraham I
2011-02-04 9:46 ` Jarkko Nikula
2011-02-04 13:45 ` Peter Ujfalusi
2011-02-04 13:57 ` G, Manjunath Kondaiah
2011-02-14 22:58 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox