From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Balaji T K <balajitk@ti.com>
Cc: lrg@slimlogic.co.uk, sameo@linux.intel.com,
linux-omap@vger.kernel.org, tony@atomide.com
Subject: Re: [PATCH 1/2] regulator: twl: add clk32kg to twl-regulator
Date: Wed, 9 Feb 2011 15:44:45 +0000 [thread overview]
Message-ID: <20110209154444.GG24042@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1297265845-21967-1-git-send-email-balajitk@ti.com>
On Wed, Feb 09, 2011 at 09:07:25PM +0530, Balaji T K wrote:
> - TWL6030_FIXED_LDO(VUSB, 0x70, 3300, 18, 0, 0x21)
> + TWL6030_FIXED_LDO(VUSB, 0x70, 3300, 18, 0, 0x21),
> + TWL6030_FIXED_LDO(CLK32KG, 0x8C, 1000, 48, 0, 0x21),
It'd seem better to implement a version of this that just doesn't have
the voltage readback operation rather than putting in a dummy voltage.
Otherwise this looks good.
next prev parent reply other threads:[~2011-02-09 15:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 15:37 [PATCH 1/2] regulator: twl: add clk32kg to twl-regulator Balaji T K
2011-02-09 15:44 ` Mark Brown [this message]
2011-02-09 16:45 ` Krishnamoorthy, Balaji T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110209154444.GG24042@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=balajitk@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox