public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Colin Cross <ccross@google.com>
Cc: Eric Miao <eric.y.miao@gmail.com>,
	Kukjin Kim <kgene.kim@samsung.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 6/6] ARM: pm: allow generic sleep code to be used with SMP CPU idle
Date: Mon, 14 Feb 2011 16:01:33 +0000	[thread overview]
Message-ID: <20110214160133.GA31501@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <AANLkTimmSbs7Q_068ERWeKUFV_1Fyxvj37e3r21LZYCL@mail.gmail.com>

On Sun, Feb 13, 2011 at 01:59:54PM -0800, Colin Cross wrote:
> On Fri, Feb 11, 2011 at 8:19 AM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> > Allow the generic sleep code to be used with SMP CPU idle by storing
> > N CPU stack pointers rather than just one.
> >
> > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> > ---
> >  arch/arm/kernel/sleep.S |   26 +++++++++++++++++++++++++-
> >  1 files changed, 25 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/kernel/sleep.S b/arch/arm/kernel/sleep.S
> > index 9f106fa..e10618f 100644
> > --- a/arch/arm/kernel/sleep.S
> > +++ b/arch/arm/kernel/sleep.S
> 
> <snip>
> 
> > @@ -107,4 +129,6 @@ ENTRY(cpu_resume)
> >  ENDPROC(cpu_resume)
> >
> >  sleep_save_sp:
> > -       .word   0                               @ preserve stack phys ptr here
> > +       .rept   CONFIG_NR_CPUS
> > +       .long   0                               @ preserve stack phys ptr here
> > +       .endr
> 
> This doesn't compile on CONFIG_SMP=n, CONFIG_NR_CPUS is undefined.
> Including linux/threads.h will provide a default definition.

Added, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2011-02-14 16:01 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-11 16:16 [PATCH] Generic CPU save/restore PM support Russell King - ARM Linux
2011-02-11 16:17 ` [PATCH 1/6] ARM: move cache/processor/fault glue to separate include files Russell King - ARM Linux
2011-02-12  2:52   ` Colin Cross
2011-02-12  9:48     ` Russell King - ARM Linux
2011-02-11 16:17 ` [PATCH 2/6] ARM: pm: add generic CPU suspend/resume support Russell King - ARM Linux
2011-02-12  2:50   ` Colin Cross
2011-02-15 11:04     ` Russell King - ARM Linux
2011-02-16  0:26       ` Colin Cross
2011-02-17 10:41         ` Lorenzo Pieralisi
2011-02-17 13:59           ` Russell King - ARM Linux
2011-02-17 20:05           ` Colin Cross
2011-02-17 23:36             ` Russell King - ARM Linux
2011-02-20 12:00       ` Russell King - ARM Linux
2011-02-21  9:58         ` Kukjin Kim
2011-02-15  1:21   ` Colin Cross
2011-02-15  4:11     ` Colin Cross
2011-02-15 10:50       ` Russell King - ARM Linux
2011-02-15 18:20         ` Colin Cross
2011-02-11 16:18 ` [PATCH 3/6] ARM: pm: convert PXA to generic " Russell King - ARM Linux
2011-02-11 16:18 ` [PATCH 4/6] ARM: pm: convert sa11x0 " Russell King - ARM Linux
2011-02-11 16:18 ` [PATCH 5/6] ARM: pm: convert samsung platforms " Russell King - ARM Linux
2011-02-17 12:09   ` Kukjin Kim
2011-02-17 14:06     ` Russell King - ARM Linux
2011-02-17 23:05       ` Kukjin Kim
2011-02-17 23:29         ` Russell King - ARM Linux
2011-02-17 23:46           ` Kukjin Kim
2011-02-11 16:19 ` [PATCH 6/6] ARM: pm: allow generic sleep code to be used with SMP CPU idle Russell King - ARM Linux
2011-02-12  2:52   ` Colin Cross
2011-02-13 21:59   ` Colin Cross
2011-02-14 16:01     ` Russell King - ARM Linux [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110214160133.GA31501@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=ccross@google.com \
    --cc=eric.y.miao@gmail.com \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox