public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: OMAP3 & USB NFS root
Date: Wed, 16 Feb 2011 10:05:43 +0200	[thread overview]
Message-ID: <20110216080543.GD2497@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <20110216080227.GB2497@legolas.emea.dhcp.ti.com>

On Wed, Feb 16, 2011 at 10:02:27AM +0200, Felipe Balbi wrote:
> Hi,
> 
> On Wed, Feb 16, 2011 at 08:44:26AM +0200, Tomi Valkeinen wrote:
> > > ah, ok. So it's another problem. I don't have beagle, but I have an old
> > > overo here. Will try tomorrow to see what's going on. Thanks for the
> > > report.
> > 
> > Did you get a chance to try this? Or any suggestions what I could try? I
> > could of course try to bisect it, but that's quite laborious as I have
> > to store the kernel into an mmc to be able to use it.
> 
> I'm trying to get my overo to work. MMC doesn't seem to be working on
> u-boot again:
> 
> Overo # mmc rescan 0
> Overo # fatload mmc 0 82000000 uImage
> reading uImage
> mmc_send_cmd: timedout waiting for cmddis!
> mmc fail to send stop cmd
> mmc_send_cmd: timedout waiting for cmddis!
> Invalid FAT entry
> 
> 952320 bytes read
> Overo # 
> 
> u-boot's HEAD is efb063390d2d1e712c2c8110911616244d562c4b

case I can't get it working, would you care to try the below patch ?

diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 54a8bd1..bc29655 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
@@ -1949,31 +1949,6 @@ musb_init_controller(struct device *dev, int nIrq, void __iomem *ctrl)
                goto fail0;
        }
 
-       switch (plat->mode) {
-       case MUSB_HOST:
-#ifdef CONFIG_USB_MUSB_HDRC_HCD
-               break;
-#else
-               goto bad_config;
-#endif
-       case MUSB_PERIPHERAL:
-#ifdef CONFIG_USB_GADGET_MUSB_HDRC
-               break;
-#else
-               goto bad_config;
-#endif
-       case MUSB_OTG:
-#ifdef CONFIG_USB_MUSB_OTG
-               break;
-#else
-bad_config:
-#endif
-       default:
-               dev_err(dev, "incompatible Kconfig role setting\n");
-               status = -EINVAL;
-               goto fail0;
-       }
-
        /* allocate */
        musb = allocate_instance(dev, plat->config, ctrl);
        if (!musb) {


-- 
balbi

  reply	other threads:[~2011-02-16  8:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1297691206.2951.8.camel@deskari>
2011-02-14 13:48 ` OMAP3 & USB NFS root Felipe Balbi
2011-02-14 14:00   ` Tomi Valkeinen
2011-02-14 14:02     ` Felipe Balbi
2011-02-16  6:44       ` Tomi Valkeinen
2011-02-16  8:02         ` Felipe Balbi
2011-02-16  8:05           ` Felipe Balbi [this message]
2011-02-16  9:44             ` Tomi Valkeinen
2011-02-16  9:49               ` Felipe Balbi
2011-02-16 10:00                 ` Tomi Valkeinen
2011-02-16 10:26                   ` Felipe Balbi
2011-02-16 10:30                     ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110216080543.GD2497@legolas.emea.dhcp.ti.com \
    --to=balbi@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox