* Latest config warning @ 2011-01-07 11:35 Russell King - ARM Linux 2011-01-07 16:47 ` Tony Lindgren 0 siblings, 1 reply; 7+ messages in thread From: Russell King - ARM Linux @ 2011-01-07 11:35 UTC (permalink / raw) To: linux-omap warning: (ARCH_STMP3XXX && <choice> || ARCH_OMAP3 && ARCH_OMAP2PLUS) selects USB_ARCH_HAS_EHCI which has unmet direct dependencies (USB_SUPPORT) This didn't happen with 2.6.37. Maybe a missing select USB_SUPPORT somewhere? ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Latest config warning 2011-01-07 11:35 Latest config warning Russell King - ARM Linux @ 2011-01-07 16:47 ` Tony Lindgren 2011-01-07 17:43 ` Premi, Sanjeev 0 siblings, 1 reply; 7+ messages in thread From: Tony Lindgren @ 2011-01-07 16:47 UTC (permalink / raw) To: Russell King - ARM Linux, Felipe Balbi; +Cc: linux-omap * Russell King - ARM Linux <linux@arm.linux.org.uk> [110107 03:34]: > warning: (ARCH_STMP3XXX && <choice> || ARCH_OMAP3 && ARCH_OMAP2PLUS) selects USB_ARCH_HAS_EHCI which has unmet direct dependencies (USB_SUPPORT) > > This didn't happen with 2.6.37. Maybe a missing select USB_SUPPORT > somewhere? Felipe, care to take a look at this one? Regards, Tony ^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: Latest config warning 2011-01-07 16:47 ` Tony Lindgren @ 2011-01-07 17:43 ` Premi, Sanjeev 2011-01-07 19:22 ` Felipe Balbi 0 siblings, 1 reply; 7+ messages in thread From: Premi, Sanjeev @ 2011-01-07 17:43 UTC (permalink / raw) To: Tony Lindgren, Russell King - ARM Linux, Balbi, Felipe Cc: linux-omap@vger.kernel.org > -----Original Message----- > From: linux-omap-owner@vger.kernel.org > [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Tony Lindgren > Sent: Friday, January 07, 2011 10:18 PM > To: Russell King - ARM Linux; Balbi, Felipe > Cc: linux-omap@vger.kernel.org > Subject: Re: Latest config warning > > * Russell King - ARM Linux <linux@arm.linux.org.uk> [110107 03:34]: > > warning: (ARCH_STMP3XXX && <choice> || ARCH_OMAP3 && > ARCH_OMAP2PLUS) selects USB_ARCH_HAS_EHCI which has unmet > direct dependencies (USB_SUPPORT) > > > > This didn't happen with 2.6.37. Maybe a missing select USB_SUPPORT > > somewhere? > I had come across this while building the "minimal kernel" for omap3evm. Here is my local patch: >From bd4efa15ec96116b359d18913c91bcbb45b46ee1 Mon Sep 17 00:00:00 2001 From: Sanjeev Premi <premi@ti.com> Date: Tue, 4 Jan 2011 18:37:39 +0530 Subject: [PATCH] omap3: fix Kconfig dependency on USB_SUPPORT This patch fixes the following warning due to unmet dependency: warning: (ARCH_STMP3XXX && <choice> || ARCH_OMAP3 && ARCH_OMAP 2PLUS) selects USB_ARCH_HAS_EHCI which has unmet direct depend encies (USB_SUPPORT) Signed-off-by: Sanjeev Premi <premi@ti.com> --- arch/arm/mach-omap2/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig index 310b759..3d67b9b 100644 --- a/arch/arm/mach-omap2/Kconfig +++ b/arch/arm/mach-omap2/Kconfig @@ -33,7 +33,7 @@ config ARCH_OMAP3 depends on ARCH_OMAP2PLUS default y select CPU_V7 - select USB_ARCH_HAS_EHCI + select USB_ARCH_HAS_EHCI if USB_SUPPORT select ARM_L1_CACHE_SHIFT_6 if !ARCH_OMAP4 select ARCH_HAS_OPP if PM select PM_OPP if PM -- 1.7.2.2 If this is a real solution, I can submit it as formal patch ~sanjeev > Felipe, care to take a look at this one? > > Regards, > > Tony > -- > To unsubscribe from this list: send the line "unsubscribe > linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: Latest config warning 2011-01-07 17:43 ` Premi, Sanjeev @ 2011-01-07 19:22 ` Felipe Balbi 2011-02-10 11:37 ` Premi, Sanjeev 0 siblings, 1 reply; 7+ messages in thread From: Felipe Balbi @ 2011-01-07 19:22 UTC (permalink / raw) To: Premi, Sanjeev Cc: Tony Lindgren, Russell King - ARM Linux, Balbi, Felipe, linux-omap@vger.kernel.org, Greg KH, Linux USB Mailing List Hi, On Fri, Jan 07, 2011 at 11:13:40PM +0530, Premi, Sanjeev wrote: > > * Russell King - ARM Linux <linux@arm.linux.org.uk> [110107 03:34]: > > > warning: (ARCH_STMP3XXX && <choice> || ARCH_OMAP3 && > > ARCH_OMAP2PLUS) selects USB_ARCH_HAS_EHCI which has unmet > > direct dependencies (USB_SUPPORT) > > > > > > This didn't happen with 2.6.37. Maybe a missing select USB_SUPPORT > > > somewhere? > > > > I had come across this while building the "minimal kernel" for omap3evm. > Here is my local patch: > > >From bd4efa15ec96116b359d18913c91bcbb45b46ee1 Mon Sep 17 00:00:00 2001 > From: Sanjeev Premi <premi@ti.com> > Date: Tue, 4 Jan 2011 18:37:39 +0530 > Subject: [PATCH] omap3: fix Kconfig dependency on USB_SUPPORT > > This patch fixes the following warning due to unmet dependency: > > warning: (ARCH_STMP3XXX && <choice> || ARCH_OMAP3 && ARCH_OMAP > 2PLUS) selects USB_ARCH_HAS_EHCI which has unmet direct depend > encies (USB_SUPPORT) > > Signed-off-by: Sanjeev Premi <premi@ti.com> > --- > arch/arm/mach-omap2/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig > index 310b759..3d67b9b 100644 > --- a/arch/arm/mach-omap2/Kconfig > +++ b/arch/arm/mach-omap2/Kconfig > @@ -33,7 +33,7 @@ config ARCH_OMAP3 > depends on ARCH_OMAP2PLUS > default y > select CPU_V7 > - select USB_ARCH_HAS_EHCI > + select USB_ARCH_HAS_EHCI if USB_SUPPORT > select ARM_L1_CACHE_SHIFT_6 if !ARCH_OMAP4 > select ARCH_HAS_OPP if PM > select PM_OPP if PM > -- > 1.7.2.2 > > If this is a real solution, I can submit it as formal patch This is one way to do it, but I believe the real fix would be to change drivers/usb/Kconfig to something like: diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig index 5a7c8f1..558cf4d 100644 --- a/drivers/usb/Kconfig +++ b/drivers/usb/Kconfig @@ -10,8 +10,6 @@ menuconfig USB_SUPPORT This option adds core support for Universal Serial Bus (USB). You will also need drivers from the following menu to make use of it. -if USB_SUPPORT - # Host-side USB depends on having a host controller # NOTE: dummy_hcd is always an option, but it's ignored here ... # NOTE: SL-811 option should be board-specific ... @@ -70,6 +68,8 @@ config USB_ARCH_HAS_EHCI default y if ARCH_CNS3XXX default PCI +if USB_SUPPORT + # ARM SA1111 chips have a non-PCI based "OHCI-compatible" USB host interface. config USB tristate "Support for Host-side USB" The idea is that ARCHs can select USB_ARCH_HAS_* without having to enable USB_SUPPORT. Currently, there's a big mess of conditional default values on all USB_ARCH_HAS_* entries: config USB_ARCH_HAS_EHCI boolean default y if PPC_83xx default y if PPC_MPC512x default y if SOC_AU1200 default y if ARCH_IXP4XX default y if ARCH_W90X900 default y if ARCH_AT91SAM9G45 default y if ARCH_MXC default y if ARCH_OMAP3 default y if ARCH_CNS3XXX default PCI IMHO it's much better to have something like: diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig index 5a7c8f1..ac137d1 100644 --- a/drivers/usb/Kconfig +++ b/drivers/usb/Kconfig @@ -10,8 +10,6 @@ menuconfig USB_SUPPORT This option adds core support for Universal Serial Bus (USB). You will also need drivers from the following menu to make use of it. -if USB_SUPPORT - # Host-side USB depends on having a host controller # NOTE: dummy_hcd is always an option, but it's ignored here ... # NOTE: SL-811 option should be board-specific ... @@ -59,16 +57,9 @@ config USB_ARCH_HAS_OHCI # some non-PCI hcds implement EHCI config USB_ARCH_HAS_EHCI boolean - default y if PPC_83xx - default y if PPC_MPC512x - default y if SOC_AU1200 - default y if ARCH_IXP4XX - default y if ARCH_W90X900 - default y if ARCH_AT91SAM9G45 - default y if ARCH_MXC - default y if ARCH_OMAP3 - default y if ARCH_CNS3XXX - default PCI + default n + +if USB_SUPPORT # ARM SA1111 chips have a non-PCI based "OHCI-compatible" USB host interface. config USB and expect ARCH Kconfigs to select the features they have. Greg, what do you think ? -- balbi ^ permalink raw reply related [flat|nested] 7+ messages in thread
* RE: Latest config warning 2011-01-07 19:22 ` Felipe Balbi @ 2011-02-10 11:37 ` Premi, Sanjeev [not found] ` <B85A65D85D7EB246BE421B3FB0FBB593024894BC9D-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org> 0 siblings, 1 reply; 7+ messages in thread From: Premi, Sanjeev @ 2011-02-10 11:37 UTC (permalink / raw) To: Balbi, Felipe Cc: Tony Lindgren, Russell King - ARM Linux, linux-omap@vger.kernel.org, Greg KH, Linux USB Mailing List > -----Original Message----- > From: Balbi, Felipe > Sent: Saturday, January 08, 2011 12:53 AM > To: Premi, Sanjeev > Cc: Tony Lindgren; Russell King - ARM Linux; Balbi, Felipe; linux- > omap@vger.kernel.org; Greg KH; Linux USB Mailing List > Subject: Re: Latest config warning > > Hi, > > On Fri, Jan 07, 2011 at 11:13:40PM +0530, Premi, Sanjeev wrote: > > > * Russell King - ARM Linux <linux@arm.linux.org.uk> [110107 03:34]: > > > > warning: (ARCH_STMP3XXX && <choice> || ARCH_OMAP3 && > > > ARCH_OMAP2PLUS) selects USB_ARCH_HAS_EHCI which has unmet > > > direct dependencies (USB_SUPPORT) > > > > > > > > This didn't happen with 2.6.37. Maybe a missing select USB_SUPPORT > > > > somewhere? > > > > > > > I had come across this while building the "minimal kernel" for omap3evm. > > Here is my local patch: > > > > >From bd4efa15ec96116b359d18913c91bcbb45b46ee1 Mon Sep 17 00:00:00 2001 > > From: Sanjeev Premi <premi@ti.com> > > Date: Tue, 4 Jan 2011 18:37:39 +0530 > > Subject: [PATCH] omap3: fix Kconfig dependency on USB_SUPPORT > > > > This patch fixes the following warning due to unmet dependency: > > > > warning: (ARCH_STMP3XXX && <choice> || ARCH_OMAP3 && ARCH_OMAP > > 2PLUS) selects USB_ARCH_HAS_EHCI which has unmet direct depend > > encies (USB_SUPPORT) > > > > Signed-off-by: Sanjeev Premi <premi@ti.com> > > --- > > arch/arm/mach-omap2/Kconfig | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig > > index 310b759..3d67b9b 100644 > > --- a/arch/arm/mach-omap2/Kconfig > > +++ b/arch/arm/mach-omap2/Kconfig > > @@ -33,7 +33,7 @@ config ARCH_OMAP3 > > depends on ARCH_OMAP2PLUS > > default y > > select CPU_V7 > > - select USB_ARCH_HAS_EHCI > > + select USB_ARCH_HAS_EHCI if USB_SUPPORT > > select ARM_L1_CACHE_SHIFT_6 if !ARCH_OMAP4 > > select ARCH_HAS_OPP if PM > > select PM_OPP if PM > > -- > > 1.7.2.2 > > > > If this is a real solution, I can submit it as formal patch > > This is one way to do it, but I believe the real fix would be to change > drivers/usb/Kconfig to something like: > > diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig > index 5a7c8f1..558cf4d 100644 > --- a/drivers/usb/Kconfig > +++ b/drivers/usb/Kconfig > @@ -10,8 +10,6 @@ menuconfig USB_SUPPORT > This option adds core support for Universal Serial Bus (USB). > You will also need drivers from the following menu to make use > of it. > > -if USB_SUPPORT > - > # Host-side USB depends on having a host controller > # NOTE: dummy_hcd is always an option, but it's ignored here ... > # NOTE: SL-811 option should be board-specific ... > @@ -70,6 +68,8 @@ config USB_ARCH_HAS_EHCI > default y if ARCH_CNS3XXX > default PCI > > +if USB_SUPPORT > + > # ARM SA1111 chips have a non-PCI based "OHCI-compatible" USB host > interface. > config USB > tristate "Support for Host-side USB" > > The idea is that ARCHs can select USB_ARCH_HAS_* without having to > enable USB_SUPPORT. Currently, there's a big mess of conditional default > values on all USB_ARCH_HAS_* entries: > > config USB_ARCH_HAS_EHCI > boolean > default y if PPC_83xx > default y if PPC_MPC512x > default y if SOC_AU1200 > default y if ARCH_IXP4XX > default y if ARCH_W90X900 > default y if ARCH_AT91SAM9G45 > default y if ARCH_MXC > default y if ARCH_OMAP3 > default y if ARCH_CNS3XXX > default PCI > > IMHO it's much better to have something like: > > diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig > index 5a7c8f1..ac137d1 100644 > --- a/drivers/usb/Kconfig > +++ b/drivers/usb/Kconfig > @@ -10,8 +10,6 @@ menuconfig USB_SUPPORT > This option adds core support for Universal Serial Bus (USB). > You will also need drivers from the following menu to make use > of it. > > -if USB_SUPPORT > - > # Host-side USB depends on having a host controller > # NOTE: dummy_hcd is always an option, but it's ignored here ... > # NOTE: SL-811 option should be board-specific ... > @@ -59,16 +57,9 @@ config USB_ARCH_HAS_OHCI > # some non-PCI hcds implement EHCI > config USB_ARCH_HAS_EHCI > boolean > - default y if PPC_83xx > - default y if PPC_MPC512x > - default y if SOC_AU1200 > - default y if ARCH_IXP4XX > - default y if ARCH_W90X900 > - default y if ARCH_AT91SAM9G45 > - default y if ARCH_MXC > - default y if ARCH_OMAP3 > - default y if ARCH_CNS3XXX > - default PCI > + default n > + > +if USB_SUPPORT > > # ARM SA1111 chips have a non-PCI based "OHCI-compatible" USB host > interface. > config USB > > and expect ARCH Kconfigs to select the features they have. > > Greg, what do you think ? > I noticed same problem when building kernel from latest master today. Felipe, Greg: Do you have agreement on what would be good fix for this warning? Best regards, Sanjeev > -- > balbi ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <B85A65D85D7EB246BE421B3FB0FBB593024894BC9D-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>]
* Re: Latest config warning [not found] ` <B85A65D85D7EB246BE421B3FB0FBB593024894BC9D-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org> @ 2011-02-10 11:48 ` Felipe Balbi [not found] ` <20110210114854.GJ3580-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org> 0 siblings, 1 reply; 7+ messages in thread From: Felipe Balbi @ 2011-02-10 11:48 UTC (permalink / raw) To: Premi, Sanjeev Cc: Balbi, Felipe, Tony Lindgren, Russell King - ARM Linux, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Greg KH, Linux USB Mailing List Hi, On Thu, Feb 10, 2011 at 05:07:06PM +0530, Premi, Sanjeev wrote: > > diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig > > index 5a7c8f1..ac137d1 100644 > > --- a/drivers/usb/Kconfig > > +++ b/drivers/usb/Kconfig > > @@ -10,8 +10,6 @@ menuconfig USB_SUPPORT > > This option adds core support for Universal Serial Bus (USB). > > You will also need drivers from the following menu to make use > > of it. > > > > -if USB_SUPPORT > > - > > # Host-side USB depends on having a host controller > > # NOTE: dummy_hcd is always an option, but it's ignored here ... > > # NOTE: SL-811 option should be board-specific ... > > @@ -59,16 +57,9 @@ config USB_ARCH_HAS_OHCI > > # some non-PCI hcds implement EHCI > > config USB_ARCH_HAS_EHCI > > boolean > > - default y if PPC_83xx > > - default y if PPC_MPC512x > > - default y if SOC_AU1200 > > - default y if ARCH_IXP4XX > > - default y if ARCH_W90X900 > > - default y if ARCH_AT91SAM9G45 > > - default y if ARCH_MXC > > - default y if ARCH_OMAP3 > > - default y if ARCH_CNS3XXX > > - default PCI > > + default n > > + > > +if USB_SUPPORT > > > > # ARM SA1111 chips have a non-PCI based "OHCI-compatible" USB host > > interface. > > config USB > > > > and expect ARCH Kconfigs to select the features they have. > > > > Greg, what do you think ? > > > > I noticed same problem when building kernel from latest master today. > > Felipe, Greg: > Do you have agreement on what would be good fix for this warning? Yeah, I never got a reply about the proposal above. Greg, what do you think ? -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <20110210114854.GJ3580-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>]
* Re: Latest config warning [not found] ` <20110210114854.GJ3580-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org> @ 2011-02-17 18:38 ` Greg KH 0 siblings, 0 replies; 7+ messages in thread From: Greg KH @ 2011-02-17 18:38 UTC (permalink / raw) To: Felipe Balbi Cc: Premi, Sanjeev, Tony Lindgren, Russell King - ARM Linux, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux USB Mailing List On Thu, Feb 10, 2011 at 01:48:54PM +0200, Felipe Balbi wrote: > Hi, > > On Thu, Feb 10, 2011 at 05:07:06PM +0530, Premi, Sanjeev wrote: > > > diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig > > > index 5a7c8f1..ac137d1 100644 > > > --- a/drivers/usb/Kconfig > > > +++ b/drivers/usb/Kconfig > > > @@ -10,8 +10,6 @@ menuconfig USB_SUPPORT > > > This option adds core support for Universal Serial Bus (USB). > > > You will also need drivers from the following menu to make use > > > of it. > > > > > > -if USB_SUPPORT > > > - > > > # Host-side USB depends on having a host controller > > > # NOTE: dummy_hcd is always an option, but it's ignored here ... > > > # NOTE: SL-811 option should be board-specific ... > > > @@ -59,16 +57,9 @@ config USB_ARCH_HAS_OHCI > > > # some non-PCI hcds implement EHCI > > > config USB_ARCH_HAS_EHCI > > > boolean > > > - default y if PPC_83xx > > > - default y if PPC_MPC512x > > > - default y if SOC_AU1200 > > > - default y if ARCH_IXP4XX > > > - default y if ARCH_W90X900 > > > - default y if ARCH_AT91SAM9G45 > > > - default y if ARCH_MXC > > > - default y if ARCH_OMAP3 > > > - default y if ARCH_CNS3XXX > > > - default PCI > > > + default n > > > + > > > +if USB_SUPPORT > > > > > > # ARM SA1111 chips have a non-PCI based "OHCI-compatible" USB host > > > interface. > > > config USB > > > > > > and expect ARCH Kconfigs to select the features they have. > > > > > > Greg, what do you think ? > > > > > > > I noticed same problem when building kernel from latest master today. > > > > Felipe, Greg: > > Do you have agreement on what would be good fix for this warning? > > Yeah, I never got a reply about the proposal above. Greg, what do you > think ? I don't know, I can't remember what the outcome of the "arches need to select the proper Kconfig options" discussion ended up being. Anyone remember? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-02-17 18:38 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-07 11:35 Latest config warning Russell King - ARM Linux
2011-01-07 16:47 ` Tony Lindgren
2011-01-07 17:43 ` Premi, Sanjeev
2011-01-07 19:22 ` Felipe Balbi
2011-02-10 11:37 ` Premi, Sanjeev
[not found] ` <B85A65D85D7EB246BE421B3FB0FBB593024894BC9D-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2011-02-10 11:48 ` Felipe Balbi
[not found] ` <20110210114854.GJ3580-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-02-17 18:38 ` Greg KH
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox