Re: Ping-> Subject: [PATCH] omap: omap3evm: add support for the WL12xx WLAN module to the omap3evm

Re: Ping-> Subject: [PATCH] omap: omap3evm: add support for the WL12xx WLAN module to the omap3evm

[Tony Lindgren]

* Reizer, Eyal <eyalr@ti.com> [110215 07:11]:
> Dear Tony,
> 
> I did not receive any comments to the patch I have send in the following link:
> 
> http://marc.info/?l=linux-omap&m=129612179900695&w=2
> 
> Are there any issues with excepting this patch?

Pushing to devel-board branch for the upcoming merge window.
Can you please check it's working? I had to merge some other
evm board changes manually..

Tony

RE: Ping-> Subject: [PATCH] omap: omap3evm: add support for the WL12xx WLAN module to the omap3evm

[Reizer, Eyal]

Sure,

Will test it first thing on Sunday.

Best Regards,
Eyal

________________________________________
From: Tony Lindgren [tony@atomide.com]
Sent: Friday, February 18, 2011 12:20 AM
To: Reizer, Eyal
Cc: linux-omap@vger.kernel.org
Subject: Re: Ping-> Subject:    [PATCH] omap: omap3evm: add support for the WL12xx WLAN module to the omap3evm

* Reizer, Eyal <eyalr@ti.com> [110215 07:11]:
> Dear Tony,
>
> I did not receive any comments to the patch I have send in the following link:
>
> http://marc.info/?l=linux-omap&m=129612179900695&w=2
>
> Are there any issues with excepting this patch?

Pushing to devel-board branch for the upcoming merge window.
Can you please check it's working? I had to merge some other
evm board changes manually..

Tony

Re: Re: Ping-> Subject: [PATCH] omap: omap3evm: add support for the WL12xx WLAN module to the omap3evm

[Reizer, Eyal]

[-- Attachment #1: Type: text/plain, Size: 2244 bytes --]

On Thu, 2011-02-17 at 14:20 -0800, Tony Lindgren wrote:
> * Reizer, Eyal <eyalr@ti.com> [110215 07:11]:
> > Dear Tony,
> > 
> > I did not receive any comments to the patch I have send in the following link:
> > 
> > http://marc.info/?l=linux-omap&m=129612179900695&w=2
> > 
> > Are there any issues with excepting this patch?
> 
> Pushing to devel-board branch for the upcoming merge window.
> Can you please check it's working? I had to merge some other
> evm board changes manually..
> 
> Tony

Dear Tony,

As you requested, I have tested the devel-board branch this morning and
found one merge issue. 
I see that there are now two mux arrays, one for omap35x and one for
omap36x.
You have merged the muxes changes to the omap35x_board_mux[] array, but
have missed the other structure called omap36x_board_mux[]. 
The same change should be merged there as well.
The result is that it would work OK on an evm with an omap35x SOM but
not on  aboard with an omap37x SOM.
Please find below a fix for that.

Best Regards,
Eyal Reizer


diff --git a/arch/arm/mach-omap2/board-omap3evm.c
b/arch/arm/mach-omap2/board-om
index d4a1157..b77140f 100644
--- a/arch/arm/mach-omap2/board-omap3evm.c
+++ b/arch/arm/mach-omap2/board-omap3evm.c
@@ -815,6 +815,21 @@ static struct omap_board_mux omap36x_board_mux[]
__initdata
        OMAP3_MUX(SYS_BOOT4, OMAP_MUX_MODE3 | OMAP_PIN_OFF_NONE),
        OMAP3_MUX(SYS_BOOT5, OMAP_MUX_MODE3 | OMAP_PIN_OFF_NONE),
        OMAP3_MUX(SYS_BOOT6, OMAP_MUX_MODE3 | OMAP_PIN_OFF_NONE),
+#ifdef CONFIG_WL12XX_PLATFORM_DATA
+       /* WLAN IRQ - GPIO 149 */
+       OMAP3_MUX(UART1_RTS, OMAP_MUX_MODE4 | OMAP_PIN_INPUT_PULLUP),
+
+       /* WLAN POWER ENABLE - GPIO 150 */
+       OMAP3_MUX(UART1_CTS, OMAP_MUX_MODE4 | OMAP_PIN_OUTPUT),
+
+       /* MMC2 SDIO pin muxes for WL12xx */
+       OMAP3_MUX(SDMMC2_CLK, OMAP_MUX_MODE0 | OMAP_PIN_INPUT_PULLUP),
+       OMAP3_MUX(SDMMC2_CMD, OMAP_MUX_MODE0 | OMAP_PIN_INPUT_PULLUP),
+       OMAP3_MUX(SDMMC2_DAT0, OMAP_MUX_MODE0 | OMAP_PIN_INPUT_PULLUP),
+       OMAP3_MUX(SDMMC2_DAT1, OMAP_MUX_MODE0 | OMAP_PIN_INPUT_PULLUP),
+       OMAP3_MUX(SDMMC2_DAT2, OMAP_MUX_MODE0 | OMAP_PIN_INPUT_PULLUP),
+       OMAP3_MUX(SDMMC2_DAT3, OMAP_MUX_MODE0 | OMAP_PIN_INPUT_PULLUP),
+#endif


[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 4254 bytes --]

Re: Re: Ping-> Subject: [PATCH] omap: omap3evm: add support for the WL12xx WLAN module to the omap3evm

[Reizer, Eyal]

[-- Attachment #1: Type: text/plain, Size: 777 bytes --]

Hi Ohad,

On Sun, 2011-02-20 at 13:32 +0200, Ohad Ben-Cohen wrote:
> Hi Eyal,
> 
> 
> 
> (posting from a mobile device, so formatting maybe funky)
> 
> On Feb 20, 2011, at 12:50 PM, "Reizer, Eyal" <eyalr@ti.com> wrote:
> ...
> > +#ifdef CONFIG_WL12XX_PLATFORM_DATA
> > 
> 
> 
> [?][?]CONFIG_WL12XX_PLATFORM_DATAhere is a bit problematic. But we can
> change that once those "other" modules show up (if any)
> 
> 
er: there is only one wlan module available for the omap3evm board (both
made by Mistral) so this should be ok.

> > [?]
> > [?]
> > 
> 
> 
> No need to have the host pulling up the 1271's interrupt line (it's
> just wasting power).
> 
> 
> Yeah, we have that on ZOOM, too, but it's redundant.
> 
er: ok, I will change that for the omap3evm.


Best Regards,
Eyal


[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 3795 bytes --]

RE: Re: Ping-> Subject: [PATCH] omap: omap3evm: add support for the WL12xx WLAN module to the omap3evm

[Premi, Sanjeev]

> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> owner@vger.kernel.org] On Behalf Of Reizer, Eyal
> Sent: Sunday, February 20, 2011 4:20 PM
> To: tony@atomide.com
> Cc: linux-omap@vger.kernel.org
> Subject: Re: Re: Ping-> Subject: [PATCH] omap: omap3evm: add support for
> the WL12xx WLAN module to the omap3evm
> 
> On Thu, 2011-02-17 at 14:20 -0800, Tony Lindgren wrote:
> > * Reizer, Eyal <eyalr@ti.com> [110215 07:11]:
> > > Dear Tony,
> > >
> > > I did not receive any comments to the patch I have send in the
> following link:
> > >
> > > http://marc.info/?l=linux-omap&m=129612179900695&w=2
> > >
> > > Are there any issues with excepting this patch?
> >
> > Pushing to devel-board branch for the upcoming merge window.
> > Can you please check it's working? I had to merge some other
> > evm board changes manually..
> >
> > Tony
> 
> Dear Tony,
> 
> As you requested, I have tested the devel-board branch this morning and
> found one merge issue.
> I see that there are now two mux arrays, one for omap35x and one for
> omap36x.
> You have merged the muxes changes to the omap35x_board_mux[] array, but
> have missed the other structure called omap36x_board_mux[].
> The same change should be merged there as well.
> The result is that it would work OK on an evm with an omap35x SOM but
> not on  aboard with an omap37x SOM.
> Please find below a fix for that.
> 

Eyal,

I am assuming that you will be sending an updated version of the patch
fixing some of the issues pointed in this response:
http://marc.info/?l=linux-omap&m=129820402332111&w=2

You can add the patch below to updated submission.

~sanjeev

> Best Regards,
> Eyal Reizer
> 

[snip]...[snip]

Re: Re: Ping-> Subject: [PATCH] omap: omap3evm: add support for the WL12xx WLAN module to the omap3evm

[Reizer, Eyal]

[-- Attachment #1: Type: text/plain, Size: 5376 bytes --]

Hi Tony,

Below is an updated patch that addresses comments received from
community members over the weekend.
Please use this patch instead of the previous one.
Please notice that on the devel-board branch there are now two mux
arrays, one for omap35x and one for omap36x.
Please merge the mux intialization part of the patch to both structures.

Many Thanks,
Eyal

...
...

Adds platform initialization for working with the WLAN module
attached to the omap3evm.
The patch includes MMC2 initialization, SDIO and control pins
muxing and platform device registration.

Signed-off-by: Eyal Reizer <eyalr@ti.com>
---
 arch/arm/mach-omap2/board-omap3evm.c |   74
++++++++++++++++++++++++++++++++++
 1 files changed, 74 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/board-omap3evm.c
b/arch/arm/mach-omap2/board-omap3evm.c
index 323c380..349aac9 100644
--- a/arch/arm/mach-omap2/board-omap3evm.c
+++ b/arch/arm/mach-omap2/board-omap3evm.c
@@ -30,6 +30,8 @@
 #include <linux/usb/otg.h>
 #include <linux/smsc911x.h>
 
+#include <linux/wl12xx.h>
+#include <linux/regulator/fixed.h>
 #include <linux/regulator/machine.h>
 #include <linux/mmc/host.h>
 
@@ -381,6 +383,16 @@ static struct omap2_hsmmc_info mmc[] = {
                .gpio_cd        = -EINVAL,
                .gpio_wp        = 63,
        },
+#ifdef CONFIG_WL12XX_PLATFORM_DATA
+       {
+               .name           = "wl1271",
+               .mmc            = 2,
+               .caps           = MMC_CAP_4_BIT_DATA |
MMC_CAP_POWER_OFF_CARD,
+               .gpio_wp        = -EINVAL,
+               .gpio_cd        = -EINVAL,
+               .nonremovable   = true,
+       },
+#endif
        {}      /* Terminator */
 };
 
@@ -538,6 +550,47 @@ static struct regulator_init_data omap3_evm_vpll2 =
{
        .consumer_supplies      = &omap3_evm_vpll2_supply,
 };
 
+#ifdef CONFIG_WL12XX_PLATFORM_DATA
+
+#define OMAP3EVM_WLAN_PMENA_GPIO       (150)
+#define OMAP3EVM_WLAN_IRQ_GPIO         (149)
+
+static struct regulator_consumer_supply omap3evm_vmmc2_supply =
+       REGULATOR_SUPPLY("vmmc", "mmci-omap-hs.1");
+
+/* VMMC2 for driving the WL12xx module */
+static struct regulator_init_data omap3evm_vmmc2 = {
+       .constraints = {
+               .valid_ops_mask = REGULATOR_CHANGE_STATUS,
+       },
+       .num_consumer_supplies  = 1,
+       .consumer_supplies = &omap3evm_vmmc2_supply,
+};
+
+static struct fixed_voltage_config omap3evm_vwlan = {
+       .supply_name            = "vwl1271",
+       .microvolts             = 1800000, /* 1.80V */
+       .gpio                   = OMAP3EVM_WLAN_PMENA_GPIO,
+       .startup_delay          = 70000, /* 70ms */
+       .enable_high            = 1,
+       .enabled_at_boot        = 0,
+       .init_data              = &omap3evm_vmmc2,
+};
+
+static struct platform_device omap3evm_wlan_regulator = {
+       .name           = "reg-fixed-voltage",
+       .id             = 1,
+       .dev = {
+               .platform_data  = &omap3evm_vwlan,
+       },
+};
+
+struct wl12xx_platform_data omap3evm_wlan_data __initdata = {
+       .irq = OMAP_GPIO_IRQ(OMAP3EVM_WLAN_IRQ_GPIO),
+       .board_ref_clock = 2, /* ref clock is 38.4 MHz */
+};
+#endif
+
 static struct twl4030_platform_data omap3evm_twldata = {
        .irq_base       = TWL4030_IRQ_BASE,
        .irq_end        = TWL4030_IRQ_END,
@@ -658,6 +711,21 @@ static struct omap_board_mux board_mux[] __initdata
= {
                                OMAP_PIN_OFF_WAKEUPENABLE),
        OMAP3_MUX(MCSPI1_CS1, OMAP_MUX_MODE4 | OMAP_PIN_INPUT_PULLUP |
                                OMAP_PIN_OFF_INPUT_PULLUP |
OMAP_PIN_OFF_OUTPUT_LOW),
+#ifdef CONFIG_WL12XX_PLATFORM_DATA
+       /* WLAN IRQ - GPIO 149 */
+       OMAP3_MUX(UART1_RTS, OMAP_MUX_MODE4 | OMAP_PIN_INPUT),
+
+       /* WLAN POWER ENABLE - GPIO 150 */
+       OMAP3_MUX(UART1_CTS, OMAP_MUX_MODE4 | OMAP_PIN_OUTPUT),
+
+       /* MMC2 SDIO pin muxes for WL12xx */
+       OMAP3_MUX(SDMMC2_CLK, OMAP_MUX_MODE0 | OMAP_PIN_INPUT_PULLUP),
+       OMAP3_MUX(SDMMC2_CMD, OMAP_MUX_MODE0 | OMAP_PIN_INPUT_PULLUP),
+       OMAP3_MUX(SDMMC2_DAT0, OMAP_MUX_MODE0 | OMAP_PIN_INPUT_PULLUP),
+       OMAP3_MUX(SDMMC2_DAT1, OMAP_MUX_MODE0 | OMAP_PIN_INPUT_PULLUP),
+       OMAP3_MUX(SDMMC2_DAT2, OMAP_MUX_MODE0 | OMAP_PIN_INPUT_PULLUP),
+       OMAP3_MUX(SDMMC2_DAT3, OMAP_MUX_MODE0 | OMAP_PIN_INPUT_PULLUP),
+#endif
        { .reg_offset = OMAP_MUX_TERMINATOR },
 };
 #endif
@@ -715,6 +783,12 @@ static void __init omap3_evm_init(void)
        ads7846_dev_init();
        omap3evm_init_smsc911x();
        omap3_evm_display_init();
+
+#ifdef CONFIG_WL12XX_PLATFORM_DATA
+       /* WL12xx WLAN Init */
+       if (wl12xx_set_platform_data(&omap3evm_wlan_data))
+               pr_err("error setting wl12xx data\n");
+       platform_device_register(&omap3evm_wlan_regulator);
+#endif
 }
 
 MACHINE_START(OMAP3EVM, "OMAP3 EVM")
-- 
1.7.0.4


On Thu, 2011-02-17 at 14:20 -0800, Tony Lindgren wrote:
> * Reizer, Eyal <eyalr@ti.com> [110215 07:11]:
> > Dear Tony,
> > 
> > I did not receive any comments to the patch I have send in the following link:
> > 
> > http://marc.info/?l=linux-omap&m=129612179900695&w=2
> > 
> > Are there any issues with excepting this patch?
> 
> Pushing to devel-board branch for the upcoming merge window.
> Can you please check it's working? I had to merge some other
> evm board changes manually..
> 
> Tony


[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 5710 bytes --]

Re: Re: Ping-> Subject: [PATCH] omap: omap3evm: add support for the WL12xx WLAN module to the omap3evm

[Tony Lindgren]

* Reizer, Eyal <eyalr@ti.com> [110223 04:22]:
> Hi Tony,
> 
> Below is an updated patch that addresses comments received from
> community members over the weekend.
> Please use this patch instead of the previous one.
> Please notice that on the devel-board branch there are now two mux
> arrays, one for omap35x and one for omap36x.
> Please merge the mux intialization part of the patch to both structures.

Sorry looks like already merged your previous patch into omap-for-linus.
Would apply this, but the patch is wrapped. Can you please resend?

Tony

RE: Re: Ping-> Subject: [PATCH] omap: omap3evm: add support for the WL12xx WLAN module to the omap3evm

[Reizer, Eyal]

Adds platform initialization for working with the WLAN module
attached to the omap3evm.
The patch includes MMC2 initialization, SDIO and control pins
muxing and platform device registration.

Signed-off-by: Eyal Reizer <eyalr@ti.com>
---
 arch/arm/mach-omap2/board-omap3evm.c |   74 ++++++++++++++++++++++++++++++++++
 1 files changed, 74 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach-omap2/board-omap3evm.c
index 323c380..349aac9 100644
--- a/arch/arm/mach-omap2/board-omap3evm.c
+++ b/arch/arm/mach-omap2/board-omap3evm.c
@@ -30,6 +30,8 @@
 #include <linux/usb/otg.h>
 #include <linux/smsc911x.h>
 
+#include <linux/wl12xx.h>
+#include <linux/regulator/fixed.h>
 #include <linux/regulator/machine.h>
 #include <linux/mmc/host.h>
 
@@ -381,6 +383,16 @@ static struct omap2_hsmmc_info mmc[] = {
                .gpio_cd        = -EINVAL,
                .gpio_wp        = 63,
        },
+#ifdef CONFIG_WL12XX_PLATFORM_DATA
+       {
+               .name           = "wl1271",
+               .mmc            = 2,
+               .caps           = MMC_CAP_4_BIT_DATA | MMC_CAP_POWER_OFF_CARD,
+               .gpio_wp        = -EINVAL,
+               .gpio_cd        = -EINVAL,
+               .nonremovable   = true,
+       },
+#endif
        {}      /* Terminator */
 };
 
@@ -538,6 +550,47 @@ static struct regulator_init_data omap3_evm_vpll2 = {
        .consumer_supplies      = &omap3_evm_vpll2_supply,
 };
 
+#ifdef CONFIG_WL12XX_PLATFORM_DATA
+
+#define OMAP3EVM_WLAN_PMENA_GPIO       (150)
+#define OMAP3EVM_WLAN_IRQ_GPIO         (149)
+
+static struct regulator_consumer_supply omap3evm_vmmc2_supply =
+       REGULATOR_SUPPLY("vmmc", "mmci-omap-hs.1");
+
+/* VMMC2 for driving the WL12xx module */
+static struct regulator_init_data omap3evm_vmmc2 = {
+       .constraints = {
+               .valid_ops_mask = REGULATOR_CHANGE_STATUS,
+       },
+       .num_consumer_supplies  = 1,
+       .consumer_supplies = &omap3evm_vmmc2_supply,
+};
+
+static struct fixed_voltage_config omap3evm_vwlan = {
+       .supply_name            = "vwl1271",
+       .microvolts             = 1800000, /* 1.80V */
+       .gpio                   = OMAP3EVM_WLAN_PMENA_GPIO,
+       .startup_delay          = 70000, /* 70ms */
+       .enable_high            = 1,
+       .enabled_at_boot        = 0,
+       .init_data              = &omap3evm_vmmc2,
+};
+
+static struct platform_device omap3evm_wlan_regulator = {
+       .name           = "reg-fixed-voltage",
+       .id             = 1,
+       .dev = {
+               .platform_data  = &omap3evm_vwlan,
+       },
+};
+
+struct wl12xx_platform_data omap3evm_wlan_data __initdata = {
+       .irq = OMAP_GPIO_IRQ(OMAP3EVM_WLAN_IRQ_GPIO),
+       .board_ref_clock = 2, /* ref clock is 38.4 MHz */
+};
+#endif
+
 static struct twl4030_platform_data omap3evm_twldata = {
        .irq_base       = TWL4030_IRQ_BASE,
        .irq_end        = TWL4030_IRQ_END,
@@ -658,6 +711,21 @@ static struct omap_board_mux board_mux[] __initdata = {
                                OMAP_PIN_OFF_WAKEUPENABLE),
        OMAP3_MUX(MCSPI1_CS1, OMAP_MUX_MODE4 | OMAP_PIN_INPUT_PULLUP |
                                OMAP_PIN_OFF_INPUT_PULLUP | OMAP_PIN_OFF_OUTPUT_LOW),
+#ifdef CONFIG_WL12XX_PLATFORM_DATA
+       /* WLAN IRQ - GPIO 149 */
+       OMAP3_MUX(UART1_RTS, OMAP_MUX_MODE4 | OMAP_PIN_INPUT),
+
+       /* WLAN POWER ENABLE - GPIO 150 */
+       OMAP3_MUX(UART1_CTS, OMAP_MUX_MODE4 | OMAP_PIN_OUTPUT),
+
+       /* MMC2 SDIO pin muxes for WL12xx */
+       OMAP3_MUX(SDMMC2_CLK, OMAP_MUX_MODE0 | OMAP_PIN_INPUT_PULLUP),
+       OMAP3_MUX(SDMMC2_CMD, OMAP_MUX_MODE0 | OMAP_PIN_INPUT_PULLUP),
+       OMAP3_MUX(SDMMC2_DAT0, OMAP_MUX_MODE0 | OMAP_PIN_INPUT_PULLUP),
+       OMAP3_MUX(SDMMC2_DAT1, OMAP_MUX_MODE0 | OMAP_PIN_INPUT_PULLUP),
+       OMAP3_MUX(SDMMC2_DAT2, OMAP_MUX_MODE0 | OMAP_PIN_INPUT_PULLUP),
+       OMAP3_MUX(SDMMC2_DAT3, OMAP_MUX_MODE0 | OMAP_PIN_INPUT_PULLUP),
+#endif
        { .reg_offset = OMAP_MUX_TERMINATOR },
 };
 #endif
@@ -715,6 +783,12 @@ static void __init omap3_evm_init(void)
        ads7846_dev_init();
        omap3evm_init_smsc911x();
        omap3_evm_display_init();
+#ifdef CONFIG_WL12XX_PLATFORM_DATA
+       /* WL12xx WLAN Init */
+       if (wl12xx_set_platform_data(&omap3evm_wlan_data))
+               pr_err("error setting wl12xx data\n");
+       platform_device_register(&omap3evm_wlan_regulator);
+#endif
 }
 
 MACHINE_START(OMAP3EVM, "OMAP3 EVM")
-- 
1.7.0.4

Re: Re: Ping-> Subject: [PATCH] omap: omap3evm: add support for the WL12xx WLAN module to the omap3evm

[Tony Lindgren]

* Reizer, Eyal <eyalr@ti.com> [110223 23:25]:
> Adds platform initialization for working with the WLAN module
> attached to the omap3evm.
> The patch includes MMC2 initialization, SDIO and control pins
> muxing and platform device registration.

Sorry still can't get this one to apply. Can you please rebase
this on top of the current omap-for-linus branch?

Thanks,

Tony

Re: Re: Ping-> Subject: [PATCH] omap: omap3evm: add support for the WL12xx WLAN module to the omap3evm

[Ohad Ben-Cohen]

Hi Eyal,

On Thu, Feb 24, 2011 at 1:47 PM, Tony Lindgren <tony@atomide.com> wrote:
> Sorry still can't get this one to apply. Can you please rebase
> this on top of the current omap-for-linus branch?
...
>> +#include <linux/wl12xx.h>
...
>> +struct wl12xx_platform_data omap3evm_wlan_data __initdata = {
>> +       .irq = OMAP_GPIO_IRQ(OMAP3EVM_WLAN_IRQ_GPIO),
>> +       .board_ref_clock = 2, /* ref clock is 38.4 MHz */
>> +};

If you're anyway resubmitting the patch, could you please use
WL12XX_REFCLOCK_38 (defined in linux/wl12xx.h) instead of the direct
value ? It will make it easier for others to understand where is this
value taken from, and how to port it to other boards.

Thanks,
Ohad.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html