Re: [PATCH] omap: Move omap_hwmod_late_init() to mdesc->timer->init() code

Paul Walmsley
2011-02-24T08:49:51Z

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1326 bytes --]

Salut Benoît,

On Wed, 23 Feb 2011, Cousson, Benoit wrote:

> This is indeed a little bit cleaner to init only the timer hwmod in the timer
> code, but I'm still wondering it it worth the extra complexity.
>
> As soon as we have one hwmod to initialize, why cannot we initialize the whole
> list like before?

Tony has mentioned that he wishes to move any code unnecessary for early
initialization to late in the boot process. This patch series was an
attempt to do that with the current usage of the hwmod code.

> If tomorrow we want to handle PRCM and control module using hwmod, like I'd
> like to do, we will have to init these hwmods early as well.
> Even earlier that init_early for the control module at least.

Yes, that makes sense to me. I'd suggest that the best time to deal with
that is when the patches to handle PRCM and the SCM via hwmod are done.
Then we would have a clear example of the need to move that code earlier.

> And then we will have a bunch of different init paths from different
> parts of the boot sequence that might become tricky to handle.

If we're just initializing individual hwmods right before we use them in
the early boot process, I hope this won't become too big of a problem.
But perhaps you are foreseeing a problem which I am not?

- Paul