From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: fix build failure
Date: Tue, 22 Feb 2011 22:26:28 +0000 [thread overview]
Message-ID: <20110222222628.GC31275@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1298406402-31572-1-git-send-email-u.kleine-koenig@pengutronix.de>
Looks good. Can you stick it in the patch system please?
On Tue, Feb 22, 2011 at 09:26:42PM +0100, Uwe Kleine-König wrote:
> Commit
>
> 06824ba (ARM: tlb: delay page freeing for SMP and ARMv7 CPUs)
>
> introduced a build failure for builds with CONFIG_SWAP=n:
>
> In file included from arch/arm/mm/init.c:27:
> arch/arm/include/asm/tlb.h: In function 'tlb_flush_mmu':
> arch/arm/include/asm/tlb.h:101: error: implicit declaration of function 'release_pages'
> arch/arm/include/asm/tlb.h: In function 'tlb_remove_page':
> arch/arm/include/asm/tlb.h:165: error: implicit declaration of function 'page_cache_release'
>
> Fix that by #including <linux/pagemap.h> in <asm/pgalloc.h> as it's done
> by x86.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> arch/arm/include/asm/pgalloc.h | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/include/asm/pgalloc.h b/arch/arm/include/asm/pgalloc.h
> index 9763be0..22de005 100644
> --- a/arch/arm/include/asm/pgalloc.h
> +++ b/arch/arm/include/asm/pgalloc.h
> @@ -10,6 +10,8 @@
> #ifndef _ASMARM_PGALLOC_H
> #define _ASMARM_PGALLOC_H
>
> +#include <linux/pagemap.h>
> +
> #include <asm/domain.h>
> #include <asm/pgtable-hwdef.h>
> #include <asm/processor.h>
> --
> 1.7.2.3
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-02-22 22:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 19:43 [PATCH] ARM: Fix compile after delay page freeing patch Tony Lindgren
2011-02-22 19:51 ` Sergei Shtylyov
2011-02-22 19:59 ` Tony Lindgren
2011-02-22 20:01 ` Uwe Kleine-König
2011-02-22 19:59 ` Russell King - ARM Linux
2011-02-22 20:10 ` Uwe Kleine-König
2011-02-22 20:18 ` Russell King - ARM Linux
2011-02-22 20:26 ` [PATCH] ARM: fix build failure Uwe Kleine-König
2011-02-22 21:57 ` Tony Lindgren
2011-02-22 22:26 ` Russell King - ARM Linux [this message]
2011-02-22 22:46 ` Uwe Kleine-König
2011-02-22 20:20 ` [PATCH] ARM: Fix compile after delay page freeing patch Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110222222628.GC31275@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox