public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Sanjeev Premi <premi@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] omap2plus: Remove auto selection on PMICs
Date: Fri, 25 Feb 2011 10:16:40 -0800	[thread overview]
Message-ID: <20110225181640.GA20560@atomide.com> (raw)
In-Reply-To: <1298463072-19891-1-git-send-email-premi@ti.com>

* Sanjeev Premi <premi@ti.com> [110223 04:11]:
> The current implementation almost assumes that only
> TWL4030/TWL5030/TWl6030 are (or can be) used with the
> OMAP processors. This is, however, not true.

If selecting these on platforms that don't have twl
causes problems the problem should be fixed.

You can disable CONFIG_ARCH_OMAP2PLUS_TYPICAL, and
then these don't get selected.
 
> This patch removes the automatic selection of the PMIC
> from Kconfig. Current defaults are chosen in default
> configuration omap2plus_defconfig and can easily be
> added to configuration for any board, there should be
> no compile/run-time impact.

The reason for CONFIG_ARCH_OMAP2PLUS_TYPICAL is to
produce a booting kernel if you do the following:

$ echo CONFIG_ARCH_OMAP=y > .config
$ yes "" | ARCH=arm make oldconfig
$ ARCH=arm CROSS_COMPILE=mycompiler uImage

So I'd rather keep it around for now. In the long run
omap2plus_defconfig should build a working kernel with
everything as modules though..

BTW, looks like small patch is needed with the patches queued
in omap-for-linus to make the above compile. Will post
as a reply to this mail.

Regards,

Tony


  reply	other threads:[~2011-02-25 18:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-23 12:11 [PATCH] omap2plus: Remove auto selection on PMICs Sanjeev Premi
2011-02-25 18:16 ` Tony Lindgren [this message]
2011-02-25 18:17   ` [PATCH] omap: Fix compile if MTD_NAND_OMAP2 is not selected Tony Lindgren
2011-02-26  8:29   ` [PATCH] omap2plus: Remove auto selection on PMICs Premi, Sanjeev
2011-03-02 18:04     ` Tony Lindgren
2011-03-07  9:33       ` Premi, Sanjeev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110225181640.GA20560@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=premi@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox