public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Kishore Kadiyala <kishore.kadiyala@ti.com>
Cc: linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org,
	cjb@laptop.org, madhu.cr@ti.com, khilman@deeprootsystems.com,
	paul@pwsan.com, b-cousson@ti.com
Subject: Re: [PATCH v5 7/8] OMAP: adapt hsmmc to hwmod framework
Date: Fri, 25 Feb 2011 12:57:11 -0800	[thread overview]
Message-ID: <20110225205711.GE20560@atomide.com> (raw)
In-Reply-To: <20110225204343.GD20560@atomide.com>

* Tony Lindgren <tony@atomide.com> [110225 12:42]:
> * Kishore Kadiyala <kishore.kadiyala@ti.com> [110225 09:00]:
> > +static int omap_mmc_init(struct omap_hwmod *oh, void *hsmmcinfo)
> ...
> 
> > +	static int mmc_num;
> > +
> > +	c += mmc_num;
> 
> This does not look right..

So since mmc_num is static, it gets initialized to 0, then increased
for each call.. What if you want to intialize controller 1 and 3 but
not 2?

Also, why do you pass void *hsmmcinfo to the function and then cast
it to struct omap2_hsmmc_inf *? Why not pass struct omap2_hsmmc_info *
to start with?

Regards,

Tony

  reply	other threads:[~2011-02-25 20:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-25 17:09 [PATCH v5 0/8] OMAP: HSMMC: hwmod adaptation Kishore Kadiyala
2011-02-25 17:09 ` [PATCH v5 1/8] omap: mmc: split out init for 2420 Kishore Kadiyala
2011-02-25 17:09 ` [PATCH v5 2/8] OMAP2430: hwmod data: Add HSMMC Kishore Kadiyala
2011-02-25 21:37   ` Paul Walmsley
2011-02-26 11:11     ` Kadiyala, Kishore
2011-02-25 17:09 ` [PATCH v5 3/8] OMAP3: " Kishore Kadiyala
2011-02-25 17:09 ` [PATCH v5 4/8] OMAP4: hwmod data: enable HSMMC Kishore Kadiyala
2011-02-25 17:09 ` [PATCH v5 5/8] OMAP: hwmod data: Add dev_attr and use in the host driver Kishore Kadiyala
2011-02-25 17:09 ` [PATCH v5 6/8] OMAP: hsmmc: Move mux configuration to hsmmc.c Kishore Kadiyala
2011-02-25 17:09 ` [PATCH v5 7/8] OMAP: adapt hsmmc to hwmod framework Kishore Kadiyala
2011-02-25 20:43   ` Tony Lindgren
2011-02-25 20:57     ` Tony Lindgren [this message]
2011-02-26 11:29       ` Kadiyala, Kishore
2011-02-28  9:09         ` Kadiyala, Kishore
2011-02-25 17:09 ` [PATCH v5 8/8] OMAP: hsmmc: Rename the device and driver Kishore Kadiyala
2011-03-01 22:51 ` [PATCH v5 0/8] OMAP: HSMMC: hwmod adaptation Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110225205711.GE20560@atomide.com \
    --to=tony@atomide.com \
    --cc=b-cousson@ti.com \
    --cc=cjb@laptop.org \
    --cc=khilman@deeprootsystems.com \
    --cc=kishore.kadiyala@ti.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=madhu.cr@ti.com \
    --cc=paul@pwsan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox