Re: Re: Ping-> Subject: [PATCH] omap: omap3evm: add support for the WL12xx WLAN module to the omap3evm

Ohad Ben-Cohen
2011-02-24T22:24:32Z

Hi Eyal,

On Thu, Feb 24, 2011 at 1:47 PM, Tony Lindgren <tony@atomide.com> wrote:
> Sorry still can't get this one to apply. Can you please rebase
> this on top of the current omap-for-linus branch?
...
>> +#include <linux/wl12xx.h>
...
>> +struct wl12xx_platform_data omap3evm_wlan_data __initdata = {
>> +       .irq = OMAP_GPIO_IRQ(OMAP3EVM_WLAN_IRQ_GPIO),
>> +       .board_ref_clock = 2, /* ref clock is 38.4 MHz */
>> +};

If you're anyway resubmitting the patch, could you please use
WL12XX_REFCLOCK_38 (defined in linux/wl12xx.h) instead of the direct
value ? It will make it easier for others to understand where is this
value taken from, and how to port it to other boards.

Thanks,
Ohad.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html