From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Michael Buesch <mb@bu3sch.de>, linux-omap <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] cbus-retu: Add locking around register access in irq handler
Date: Tue, 1 Mar 2011 15:11:49 -0800 [thread overview]
Message-ID: <20110301231149.GR20560@atomide.com> (raw)
In-Reply-To: <20110228190931.GS2459@legolas.emea.dhcp.ti.com>
* Felipe Balbi <balbi@ti.com> [110228 11:07]:
> On Mon, Feb 28, 2011 at 05:06:08PM +0100, Michael Buesch wrote:
> > This adds locking around the register access in the
> > interrupt service routine.
> >
> > Signed-off-by: Michael Buesch <mb@bu3sch.de>
> > Reported-by: Felipe Balbi <balbi@ti.com>
>
> Fine by me. Tony, you can apply.
Only applied the first two to add the register defines because of:
BUG: sleeping function called from invalid context at kernel/mutex.c:278
in_atomic(): 1, irqs_disabled(): 0, pid: 0, name: swapper
INFO: lockdep is turned off.
[<c0063c24>] (unwind_backtrace+0x0/0xec) from [<c0402f98>] (mutex_lock_nested+0x24/0x340)
[<c0402f98>] (mutex_lock_nested+0x24/0x340) from [<c032b4e4>] (retu_write_reg+0x20/0x3c)
[<c032b4e4>] (retu_write_reg+0x20/0x3c) from [<c032bc4c>] (_retu_modify_counter+0x28/0x34)
[<c032bc4c>] (_retu_modify_counter+0x28/0x34) from [<c032be48>] (retu_wdt_set_ping_timer+0x10/0x50)
[<c032be48>] (retu_wdt_set_ping_timer+0x10/0x50) from [<c00a2000>] (run_timer_softirq+0x260/0x368)
[<c00a2000>] (run_timer_softirq+0x260/0x368) from [<c009bdb8>] (__do_softirq+0xe8/0x1e0)
[<c009bdb8>] (__do_softirq+0xe8/0x1e0) from [<c009bf04>] (irq_exit+0x54/0xa0)
[<c009bf04>] (irq_exit+0x54/0xa0) from [<c0052090>] (asm_do_IRQ+0x90/0xcc)
[<c0052090>] (asm_do_IRQ+0x90/0xcc) from [<c0404adc>] (__irq_svc+0x3c/0x100)
Tony
prev parent reply other threads:[~2011-03-01 23:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-28 16:06 [PATCH] cbus-retu: Add locking around register access in irq handler Michael Buesch
2011-02-28 19:09 ` Felipe Balbi
2011-03-01 23:11 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110301231149.GR20560@atomide.com \
--to=tony@atomide.com \
--cc=balbi@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox