From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] cbus-retu: Add locking around register access in irq handler Date: Tue, 1 Mar 2011 15:11:49 -0800 Message-ID: <20110301231149.GR20560@atomide.com> References: <1298909168.16391.6.camel@marge> <20110228190931.GS2459@legolas.emea.dhcp.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-01-ewr.mailhop.org ([204.13.248.71]:44551 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756749Ab1CAXL5 (ORCPT ); Tue, 1 Mar 2011 18:11:57 -0500 Content-Disposition: inline In-Reply-To: <20110228190931.GS2459@legolas.emea.dhcp.ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Felipe Balbi Cc: Michael Buesch , linux-omap * Felipe Balbi [110228 11:07]: > On Mon, Feb 28, 2011 at 05:06:08PM +0100, Michael Buesch wrote: > > This adds locking around the register access in the > > interrupt service routine. > > > > Signed-off-by: Michael Buesch > > Reported-by: Felipe Balbi > > Fine by me. Tony, you can apply. Only applied the first two to add the register defines because of: BUG: sleeping function called from invalid context at kernel/mutex.c:278 in_atomic(): 1, irqs_disabled(): 0, pid: 0, name: swapper INFO: lockdep is turned off. [] (unwind_backtrace+0x0/0xec) from [] (mutex_lock_nested+0x24/0x340) [] (mutex_lock_nested+0x24/0x340) from [] (retu_write_reg+0x20/0x3c) [] (retu_write_reg+0x20/0x3c) from [] (_retu_modify_counter+0x28/0x34) [] (_retu_modify_counter+0x28/0x34) from [] (retu_wdt_set_ping_timer+0x10/0x50) [] (retu_wdt_set_ping_timer+0x10/0x50) from [] (run_timer_softirq+0x260/0x368) [] (run_timer_softirq+0x260/0x368) from [] (__do_softirq+0xe8/0x1e0) [] (__do_softirq+0xe8/0x1e0) from [] (irq_exit+0x54/0xa0) [] (irq_exit+0x54/0xa0) from [] (asm_do_IRQ+0x90/0xcc) [] (asm_do_IRQ+0x90/0xcc) from [] (__irq_svc+0x3c/0x100) Tony