From: Jarkko Nikula <jhnikula@gmail.com>
To: Nishanth Menon <nm@ti.com>
Cc: Kevin Hilman <khilman@ti.com>,
linux-omap@vger.kernel.org, Thara Gopinath <thara@ti.com>
Subject: Re: [RFC 3/3] omap3+: sr: Reuse sr_[start|stop]_vddautocomp functions
Date: Thu, 3 Mar 2011 08:57:09 +0200 [thread overview]
Message-ID: <20110303085709.b443794f.jhnikula@gmail.com> (raw)
In-Reply-To: <4D6EE654.1090207@ti.com>
On Thu, 03 Mar 2011 06:22:36 +0530
Nishanth Menon <nm@ti.com> wrote:
> Kevin Hilman wrote, on 03/03/2011 06:18 AM:
> > Nishanth Menon<nm@ti.com> writes:
> >> Looks like a nice cleanup to me.
> >>
> >> if the motivation of patch 1/3 is to do this cleanup, I am altogether
> >> for it (lesser code == lesser bugs ;) ). btw, this should not impact
> >> class1.5 either - core sr.c sequencing has not been modified in sr1.5
> >> :)
> >>
Heh, no any hidded motivation here. I was just blind to see your 12/18
and I found the issue and cleanup possibilities at the same time and
decided to put them into same RFC set :-)
> > Nishanth,
> >
> > I'd prefer if you handle these. You can add them to the fixup/cleanup
> > part of your SR1.5 series.
>
> ok will pull this in as part of sr1.5 series if no further review comments.
>
Ok, that's fine to me (though your set has the priority as I didn't
notice the 12/18).
--
Jarkko
prev parent reply other threads:[~2011-03-03 6:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 15:57 [RFC 0/3] omap3+: sr: Minor fix and cleanups Jarkko Nikula
2011-03-02 15:57 ` [RFC 1/3] omap3+: sr: Prevent multiple smartreflex class driver enable calls Jarkko Nikula
2011-03-02 16:52 ` Nishanth Menon
2011-03-02 15:57 ` [RFC 2/3] omap3+: sr: Sync sr_stop_vddautocomp implementation with sr_start_vddautocomp Jarkko Nikula
2011-03-02 15:57 ` [RFC 3/3] omap3+: sr: Reuse sr_[start|stop]_vddautocomp functions Jarkko Nikula
2011-03-02 16:59 ` Nishanth Menon
2011-03-03 0:48 ` Kevin Hilman
2011-03-03 0:52 ` Nishanth Menon
2011-03-03 6:57 ` Jarkko Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110303085709.b443794f.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=thara@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox