From: Felipe Balbi <balbi@ti.com>
To: "Michael Büsch" <mb@bu3sch.de>
Cc: balbi@ti.com, Tony Lindgren <tony@atomide.com>,
linux-omap <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] cbus-retu-wdt: Fix bitfield access
Date: Thu, 3 Mar 2011 16:27:18 +0200 [thread overview]
Message-ID: <20110303142718.GS2644@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <1299162089.31972.4.camel@maggie>
On Thu, Mar 03, 2011 at 03:21:29PM +0100, Michael Büsch wrote:
> On Thu, 2011-03-03 at 11:43 +0200, Felipe Balbi wrote:
> > On Wed, Mar 02, 2011 at 05:11:53PM +0100, Michael Buesch wrote:
> > > An unsigned int pointer must not be casted to an unsigned
> > > long pointer before use. Convert the bitfield to unsigned long
> > > to fix this.
> > > Also use clear_bit() in the release path.
> > >
> > > Signed-off-by: Michael Buesch <mb@bu3sch.de>
> >
> > This looks ok, I'm just wondering if the change on test_and_set_bit()
> > from bit 1 to bit 0 should be on this patch. I guess not.
>
> Uh, well. If that's worth doing a separate patch, I'll do it.
> It doesn't actually really matter if we use bit 0, 1 or ... for this.
> I just thought it was weird to use the second bit.
yeah, I didn't read the whole code before making the comment, if you're
sure no-one is using bit 0, then go for it. Having it separate, would
help on bisecting should things go wrong.
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-03-03 14:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 16:11 [PATCH] cbus-retu-wdt: Fix bitfield access Michael Buesch
2011-03-03 9:43 ` Felipe Balbi
2011-03-03 14:21 ` Michael Büsch
2011-03-03 14:27 ` Felipe Balbi [this message]
2011-03-03 14:36 ` Michael Büsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110303142718.GS2644@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox