From: Tony Lindgren <tony@atomide.com>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Benoit Cousson <b-cousson@ti.com>,
linux-omap@vger.kernel.org, Felipe Balbi <balbi@ti.com>,
Sricharan R <r.sricharan@ti.com>
Subject: Re: [PATCH 5/6] omap4: Initialise the l3 device with the hwmod data.
Date: Thu, 3 Mar 2011 10:31:11 -0800 [thread overview]
Message-ID: <20110303183111.GO20560@atomide.com> (raw)
In-Reply-To: <295be59bd43a2e9f0961c10263ce19c0@mail.gmail.com>
* Santosh Shilimkar <santosh.shilimkar@ti.com> [110221 11:01]:
> > -----Original Message-----
> > From: Cousson, Benoit [mailto:b-cousson@ti.com]
> > Sent: Monday, February 21, 2011 11:41 PM
> > To: Shilimkar, Santosh
> > Cc: linux-omap@vger.kernel.org; Balbi, Felipe; R, Sricharan
> > Subject: Re: [PATCH 5/6] omap4: Initialise the l3 device with the
> > hwmod data.
> >
> > On 2/21/2011 2:46 PM, Shilimkar, Santosh wrote:
> > > From: sricharan<r.sricharan@ti.com>
> > >
> > > The l3 interconnect device is build with all the data required
> > > to handle the error logging. The data is extracted from the
> > > hwmod data base.
> > >
> > > Signed-off-by: sricharan<r.sricharan@ti.com>
> > > Signed-off-by: sricharan<r.sricharan@ti.com>
> > > Tested-by: sricharan<r.sricharan@ti.com>
> >
> > Mmm, I'm not sure the tested-by is meaningfull in your case, since
> > you wrote the code and so everybody will assume you tested it.
> > One s-o-b should be probably enough.
> >
>
> Well he tested whole series including the patch from Felipe.
> So a tested-by on whole series doesn't hurt, right ?
>
> Just for record, I have seen tested by applied on whole series
> Where as some of the patches in this series are just comment
> updates.
Well Signed-off-by also means Tested-by. If not, it should
be specifically mentioned when the patch is posted. Something
like "PLEASE NOTE THAT THIS PATCH IS COMPLETELY UNTESTED".
Also one Signed-off-by is enough like Benoit pointed out :)
Tony
next prev parent reply other threads:[~2011-03-03 18:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 13:46 [PATCH 0/6] omap3/4: Add l3-interconnect error logging support Santosh Shilimkar
2011-02-21 13:46 ` [PATCH 1/6] omap3: hwmod_data: Add l3 error log data to hwmod database Santosh Shilimkar
2011-02-23 8:03 ` Sricharan R
2011-02-23 8:14 ` Sricharan R
2011-02-21 13:46 ` [PATCH 2/6] omap3: Initialise the l3 device with the hwmod data Santosh Shilimkar
2011-02-21 13:46 ` [PATCH 3/6] omap3: l3: Introduce l3-interconnect error handling driver Santosh Shilimkar
2011-02-21 13:46 ` [PATCH 4/6] omap4: hwmod_data: Add l3 errorlog data to hwmod database Santosh Shilimkar
2011-02-21 14:39 ` Cousson, Benoit
2011-02-23 5:38 ` Sricharan R
2011-02-23 8:04 ` Sricharan R
2011-03-04 21:34 ` Cousson, Benoit
2011-03-05 7:51 ` Santosh Shilimkar
2011-02-23 8:14 ` Sricharan R
2011-02-21 13:46 ` [PATCH 5/6] omap4: Initialise the l3 device with the hwmod data Santosh Shilimkar
2011-02-21 18:10 ` Cousson, Benoit
2011-02-21 19:03 ` Santosh Shilimkar
2011-03-03 18:31 ` Tony Lindgren [this message]
2011-03-04 6:20 ` Santosh Shilimkar
2011-03-04 18:08 ` Tony Lindgren
2011-03-05 7:46 ` Santosh Shilimkar
2011-03-07 10:22 ` Cousson, Benoit
2011-03-07 11:19 ` Santosh Shilimkar
2011-03-07 11:25 ` Santosh Shilimkar
2011-02-21 13:46 ` [PATCH 6/6] omap4: l3: Introduce l3-interconnect error handling driver Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110303183111.GO20560@atomide.com \
--to=tony@atomide.com \
--cc=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=r.sricharan@ti.com \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).