linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Sricharan R <r.sricharan@ti.com>
Cc: linux-omap@vger.kernel.org, Benoit Cousson <b-cousson@ti.com>,
	paul@pswan.com, Santosh Shilimkar <santosh.shilimkar@ti.com>
Subject: Re: [PATCH] omap2+: mux: Initialise the static pads.
Date: Fri, 4 Mar 2011 09:43:01 -0800	[thread overview]
Message-ID: <20110304174301.GA20560@atomide.com> (raw)
In-Reply-To: <4ad439dff008aeca2a058207ef744650@mail.gmail.com>

* Sricharan R <r.sricharan@ti.com> [110304 09:31]:
> Hi Tony,
> 
> >Hmm it's there as commit 93c5f165e10c21a3813a687204388a34072b2a62
> 
> >in devel-mux branch. Can you please update your patch against
> 
> >that commit so it's easier to see what your changes are?
> 
> >
> 
> >BTW, the patch you posted got trashed by your email client
> 
> >or server..
> 
> >
> 
> Here is the updated patch on top of your previous patch.

The patch formatting is still trashed, notice the double line
spacing..
 
> +++ b/arch/arm/mach-omap2/mux.c
> 
> @@ -359,7 +359,6 @@ void omap_hwmod_mux(struct omap_hwmod_mux_info *hmux, u8
> state)

..and the line wrapping of the patch lines.

> 
> +     if ((state == _HWMOD_STATE_ENABLED) && hmux->pads_dynamic
> 
> +                             && hmux->enabled) {

Yes I see that might allow removing the idle flag. Will give it
a try with my testcase once you get your mail issue sorted out
and can post a patch that applies.

Tony
 

  parent reply	other threads:[~2011-03-04 17:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-01 18:16 [PATCH] omap2+: mux: Initialise the static pads sricharan
2011-03-04  2:28 ` Tony Lindgren
     [not found]   ` <44e29d555f2b399b7067d827603897cc@mail.gmail.com>
2011-03-04 16:28     ` Tony Lindgren
     [not found]       ` <4ad439dff008aeca2a058207ef744650@mail.gmail.com>
2011-03-04 17:43         ` Tony Lindgren [this message]
2011-03-07  4:39           ` Sricharan R

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110304174301.GA20560@atomide.com \
    --to=tony@atomide.com \
    --cc=b-cousson@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pswan.com \
    --cc=r.sricharan@ti.com \
    --cc=santosh.shilimkar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).