From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Nikula Subject: Re: [PATCH V3 13/19] OMAP3+: SR: Reuse sr_[start|stop]_vddautocomp functions Date: Mon, 7 Mar 2011 16:40:33 +0200 Message-ID: <20110307164033.01a3b67c.jhnikula@gmail.com> References: <1299338962-5602-1-git-send-email-nm@ti.com> <1299338962-5602-14-git-send-email-nm@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from mail-fx0-f46.google.com ([209.85.161.46]:42978 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752021Ab1CGOki (ORCPT ); Mon, 7 Mar 2011 09:40:38 -0500 Received: by fxm17 with SMTP id 17so4127280fxm.19 for ; Mon, 07 Mar 2011 06:40:37 -0800 (PST) In-Reply-To: <1299338962-5602-14-git-send-email-nm@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Nishanth Menon Cc: linux-omap , linux-arm , Kevin Hilman , Tony , Paul On Sat, 5 Mar 2011 20:59:16 +0530 Nishanth Menon wrote: > From: Jarkko Nikula > > sr_start_vddautocomp and sr_stop_autocomp functions can be reused from > omap_sr_enable, omap_sr_disable and omap_sr_disable_reset_volt and by > adding one additional argument sr_stop_autocomp. This allows us to have > a single point where SR enable and disable operations are controlled from. > > [nm@ti.com: synced it up with class start/stop as well. autocomp flag > should only be disabled when SR is disabled for that domain] > Signed-off-by: Nishanth Menon > Signed-off-by: Jarkko Nikula > --- > Side note: Jarkko has'nt seen this rev as I just finished the rebase and tested > but adding his signed-off anyways as he is primary contributor to the idea > and the patch. > This version looks good to me. We agreed with Nishant that squashing my trivial patches with Nishant's set makes the most sense. -- Jarkko