From: Tony Lindgren <tony@atomide.com>
To: "Michael Büsch" <mb@bu3sch.de>
Cc: balbi@ti.com, linux-omap <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] cbus-retu-wdt: Remove unused nonstandard interfaces
Date: Tue, 8 Mar 2011 15:02:35 -0800 [thread overview]
Message-ID: <20110308230234.GF26463@atomide.com> (raw)
In-Reply-To: <1299161893.31972.0.camel@maggie>
* Michael Büsch <mb@bu3sch.de> [110303 06:16]:
> On Thu, 2011-03-03 at 11:42 +0200, Felipe Balbi wrote:
> > On Wed, Mar 02, 2011 at 05:11:58PM +0100, Michael Buesch wrote:
> > > @@ -175,9 +124,9 @@ static int retu_wdt_release(struct inode
> > > struct retu_wdt_dev *wdev = file->private_data;
> > >
> > > #ifndef CONFIG_WATCHDOG_NOWAYOUT
> > > - retu_wdt_ping_enable(retu_wdt);
> > > + retu_wdt_ping_enable(wdev);
> > > #endif
> > > - clear_bit(0, &retu_wdt->users);
> > > + clear_bit(0, &wdev->users);
> >
> > this hunk isn't part of this patch.
>
> Well, it's a compiler warning cleanup, so I thought it would be fine
> to go with the big cleanup patch.
> Is it necessary to do a separate patch for this?
Well looks like I already applied some earlier version of
this.. Sorry.
Anyways, can you please check what's still missing from
the cbus branch? I've now applied the ones Felipe acked.
At least this patch needs to be refreshed to apply on
top of the cbus branch.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-03-08 23:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 16:11 [PATCH] cbus-retu-wdt: Remove unused nonstandard interfaces Michael Buesch
2011-03-03 9:42 ` Felipe Balbi
2011-03-03 14:18 ` Michael Büsch
2011-03-03 14:27 ` Felipe Balbi
2011-03-08 23:02 ` Tony Lindgren [this message]
2011-03-09 17:40 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110308230234.GF26463@atomide.com \
--to=tony@atomide.com \
--cc=balbi@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox