From: "G, Manjunath Kondaiah" <manjugk@ti.com>
To: "DebBarma, Tarun Kanti" <tarun.kanti@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v12 6/9] dmtimer: switch-over to platform device driver
Date: Fri, 11 Mar 2011 18:15:33 +0530 [thread overview]
Message-ID: <20110311124533.GA7492@m-desktop> (raw)
In-Reply-To: <5A47E75E594F054BAF48C5E4FC4B92AB037A4DD9D2@dbde02.ent.ti.com>
On Fri, Mar 11, 2011 at 11:05:25AM +0530, DebBarma, Tarun Kanti wrote:
> [...]
> > > >
> > > > * Tarun Kanti DebBarma <tarun.kanti@ti.com> [110308 15:41]:
> > > > > switch-over to platform device driver through following changes:
> > > > > (a) initiate dmtimer early initialization from omap2_gp_timer_init()
> > > > > in timer-gp.c. This is equivalent of timer_init()->timer->init().
> > > > > (b) modify plat-omap/dmtimer routines to use new register map and
> > > > > platform data.
> > > >
> > > > This patch breaks booting for 2420 and makes boot hang early
> > > > on 2430. Note that to test with omap-for-linus branch you need
> > > > to disable the following in omap2plus_defconfig:
> > > >
> > > > CONFIG_ARCH_OMAP3
> > > > CONFIG_ARCH_OMAP4
> > > > CONFIG_CPU_32v6K
> > > I disabled above options on omap-for-linus *WITHOUT* my patch series.
> > > I am still seeing crash. Here is the log.
> > > I tried on two different setups. Not sure if I am missing something.
> >
> > Hmm sounds like H4 needs some attention. Can you try the following
> > completely untested patch?
>
> This works fine!
I tried to use below patch for booting OMAP2420 H4 on top of:
git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git
Branch: omap-for-linus
commit 94a06b74e724caabcf0464c81527cfbcae0c8aff
Merge: 0dde52a 9062511
Author: Tony Lindgren <tony@atomide.com>
Merge branch 'for_2.6.39/pm-misc' of
ssh://master.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm
into omap-for-linus
Looks like it stops after uncompressing kernel. Same setup works fine
with tag v2.6.37.
OMAP242x H4 # boot
Using MAC Address 10:20:30:40:50:61
TFTP from server 10.24.244.97; our IP address is 10.24.244.196
Filename 'uImage'.
Load address: 0x80300000
Loading:
#################################################################
#################################################################
#################################################################
#################################################################
#################################################################
#################################################################
#################################################################
#################################################################
#########################################################
done
Bytes transferred = 2950216 (2d0448 hex)
## Booting image at 80300000 ...
Image Name: Linux-2.6.38-rc8-00188-g94a06b7-
Image Type: ARM Linux Kernel Image (uncompressed)
Data Size: 2950152 Bytes = 2.8 MB
Load Address: 80008000
Entry Point: 80008000
Verifying Checksum ... OK
OK
Starting kernel ...
Uncompressing Linux... done, booting the kernel.
-Manjunath
> --
> Tarun
>
> >
> > Tony
> >
> > From: Tony Lindgren <tony@atomide.com>
> > Date: Thu, 10 Mar 2011 09:51:29 -0800
> > Subject: [PATCH] omap: Fix H4 init_irq to not call h4_init_flash
> >
> > There should be no reason to call h4_init_flash this
> > early. It causes problems as things are not yet initialized.
> >
> > Note: This patch has not been tested.
> >
> > Not-Yet-Signed-off-by: Tony Lindgren <tony@atomide.com>
> >
> > --- a/arch/arm/mach-omap2/board-h4.c
> > +++ b/arch/arm/mach-omap2/board-h4.c
> > @@ -299,7 +299,6 @@ static void __init omap_h4_init_early(void)
> > static void __init omap_h4_init_irq(void)
> > {
> > omap_init_irq();
> > - h4_init_flash();
> > }
> >
> > static struct at24_platform_data m24c01 = {
> > @@ -372,6 +371,7 @@ static void __init omap_h4_init(void)
> > platform_add_devices(h4_devices, ARRAY_SIZE(h4_devices));
> > omap2_usbfs_init(&h4_usb_config);
> > omap_serial_init();
> > + h4_init_flash();
> > }
> >
> > static void __init omap_h4_map_io(void)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-03-11 12:47 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 23:45 [PATCH v12 0/9] dmtimer adaptation to platform_driver Tarun Kanti DebBarma
2011-03-08 23:45 ` [PATCH v12 1/9] OMAP2+: dmtimer: add device names to flck nodes Tarun Kanti DebBarma
2011-03-08 23:45 ` [PATCH v12 2/9] OMAP4: hwmod data: add dmtimer version information Tarun Kanti DebBarma
2011-03-08 23:45 ` [PATCH v12 3/9] OMAP1: dmtimer: conversion to platform devices Tarun Kanti DebBarma
2011-03-08 23:45 ` [PATCH v12 4/9] OMAP2+: dmtimer: convert " Tarun Kanti DebBarma
2011-03-09 21:42 ` Tony Lindgren
2011-03-10 15:29 ` DebBarma, Tarun Kanti
2011-03-10 22:52 ` Kevin Hilman
2011-03-11 4:36 ` DebBarma, Tarun Kanti
2011-03-10 23:14 ` Kevin Hilman
2011-03-11 4:20 ` DebBarma, Tarun Kanti
2011-03-11 19:13 ` Tony Lindgren
2011-03-12 0:03 ` Kevin Hilman
2011-03-14 17:12 ` Tony Lindgren
2011-03-17 22:00 ` Kevin Hilman
2011-03-19 0:27 ` Tony Lindgren
2011-03-19 4:34 ` Santosh Shilimkar
2011-03-21 17:07 ` Tony Lindgren
2011-03-21 18:33 ` Kevin Hilman
2011-03-21 19:11 ` Tony Lindgren
2011-03-25 6:55 ` DebBarma, Tarun Kanti
2011-03-25 15:55 ` Tony Lindgren
2011-03-29 17:13 ` Tony Lindgren
2011-03-29 17:52 ` Tony Lindgren
2011-03-10 23:21 ` Kevin Hilman
2011-03-11 4:13 ` DebBarma, Tarun Kanti
2011-03-08 23:45 ` [PATCH v12 5/9] OMAP: dmtimer: platform driver Tarun Kanti DebBarma
2011-03-08 23:45 ` [PATCH v12 6/9] dmtimer: switch-over to platform device driver Tarun Kanti DebBarma
2011-03-09 22:02 ` Tony Lindgren
2011-03-10 15:27 ` DebBarma, Tarun Kanti
2011-03-10 17:56 ` Tony Lindgren
2011-03-11 5:35 ` DebBarma, Tarun Kanti
2011-03-11 12:45 ` G, Manjunath Kondaiah [this message]
2011-03-11 19:15 ` Tony Lindgren
2011-03-12 4:20 ` G, Manjunath Kondaiah
2011-03-11 19:14 ` Tony Lindgren
2011-03-14 6:48 ` DebBarma, Tarun Kanti
2011-03-08 23:45 ` [PATCH v12 7/9] OMAP: dmtimer: pm_runtime support Tarun Kanti DebBarma
2011-03-08 23:45 ` [PATCH v12 8/9] OMAP: dmtimer: add timeout to low-level routines Tarun Kanti DebBarma
2011-03-08 23:45 ` [PATCH v12 9/9] OMAP: dmtimer: use mutex instead of spinlock Tarun Kanti DebBarma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110311124533.GA7492@m-desktop \
--to=manjugk@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=tarun.kanti@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).