Re: [PATCH v2 0/4] OMAP: DMA: mstandby mode and runtime pm support

["G, Manjunath Kondaiah" <manjugk@ti.com>]

Kevin,

On Sat, Mar 19, 2011 at 08:46:05AM +0530, G, Manjunath Kondaiah wrote:
> On Fri, Mar 18, 2011 at 11:27:00AM -0700, Kevin Hilman wrote:
> > "G, Manjunath Kondaiah" <manjugk@ti.com> writes:
> > 
> > > On Thu, Mar 17, 2011 at 02:29:18PM -0700, Kevin Hilman wrote:
> > >> "G, Manjunath Kondaiah" <manjugk@ti.com> writes:
> > >> 
> > >> > Patch series to support mstandby mode handling and enabling runtime PM
> > >> > support for DMA driver.
> > >> 
> > >> I still have the same problems as with the previous revision: 
> > >> 
> > >> 
> > >> This is still not runtime-suspending when I use my DMA test in linking
> > >> mode.
> > >> 
> > >> If I put a large enough period between transfers, it should autosuspend
> > >> during transfers.  It seems to do auto-suspend and resume once, but then
> > >> it never suspends again.
> > >> 
> > >> I tested with my dmatest module[1], and loaded with:
> > >> 
> > >>   # insmod ./dmatest.ko linking=1 forever=1 forever_period=1024
> > >> 
> > >> Not only does it not auto-suspend between transfers (which I expected),
> > >> it also doesn't suspend after removing the module which stops all active
> > >> channels.
> > >
> > > Tested again on 2.6.38 with patches pulled from patchworks and for me,
> > > the same test case seems to be passing. Here is the log:
> > > http://pastebin.com/ccEmTZS5
> > >
> > > The above test case is executed on blaze and same result is observed
> > > with other OMAP2+ boards also.
> > 
> > Can you try again with dmatest loaded without 'debug=1'
> > 
> > What's strange is that I noticed it worked with debug=1 also, but didn't
> > with debug disabled.
> > 
> > I *think* it's a bug in my test, which I fixed, but can you try the
> > above before pulling a new version of my test?
> done. without pulling latest dmatest changes, your observation is correct.
> With latest changes, it is working fine.

If you don't see any further issues with this patch series, there are no
more changes to this patch series except one warning fix:
http://thread.gmane.org/gmane.linux.ports.arm.omap/54753/focus=55097
 
If it is only warning fix, I can send pull request on top of
omap-for-linus branch.

-Manjunath