From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [PATCH v2 2/2] RX-51: Enable isp1704 power on/off Date: Mon, 28 Mar 2011 11:39:54 +0300 Message-ID: <20110328083953.GG2251@legolas.emea.dhcp.ti.com> References: <1301295099-22066-1-git-send-email-kalle.jokiniemi@nokia.com> <1301295099-22066-3-git-send-email-kalle.jokiniemi@nokia.com> <4D9044B2.5020607@ru.mvista.com> Reply-To: balbi-l0cyMroinI0@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4D9044B2.5020607-hkdhdckH98+B+jHODAdFcQ@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sergei Shtylyov Cc: Kalle Jokiniemi , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, balbi-l0cyMroinI0@public.gmane.org, heikki.krogerus-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org, jhnikula-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, khilman-l0cyMroinI0@public.gmane.org List-Id: linux-omap@vger.kernel.org On Mon, Mar 28, 2011 at 12:20:02PM +0400, Sergei Shtylyov wrote: > >+static void __init rx51_charger_init(void) > >+{ > >+ BUG_ON(gpio_request_one(RX51_USB_TRANSCEIVER_RST_GPIO, > >+ GPIOF_OUT_INIT_LOW, "isp1704_reset")); > > I'm not sure we should kill the machine if this fails... agreed. -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html