From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [pm-core][PATCH v3 01/21] OMAP4: PM: Add omap WakeupGen module support Date: Mon, 28 Mar 2011 13:50:27 -0700 Message-ID: <20110328205027.GC30616@atomide.com> References: <1301304157-2466-1-git-send-email-santosh.shilimkar@ti.com> <1301304157-2466-2-git-send-email-santosh.shilimkar@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-01-ewr.mailhop.org ([204.13.248.71]:22948 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753245Ab1C1Uub (ORCPT ); Mon, 28 Mar 2011 16:50:31 -0400 Content-Disposition: inline In-Reply-To: <1301304157-2466-2-git-send-email-santosh.shilimkar@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Santosh Shilimkar Cc: linux-omap@vger.kernel.org, khilman@ti.com, rnayak@ti.com, linux-arm-kernel@lists.infradead.org * Santosh Shilimkar [110328 02:20]: > --- a/arch/arm/mach-omap2/omap4-common.c > +++ b/arch/arm/mach-omap2/omap4-common.c > @@ -21,6 +21,7 @@ > > #include > #include > +#include > > #ifdef CONFIG_CACHE_L2X0 > void __iomem *l2cache_base; > @@ -41,6 +42,8 @@ void __init gic_init_irq(void) > gic_cpu_base = ioremap(OMAP44XX_GIC_CPU_BASE, SZ_512); > BUG_ON(!gic_cpu_base); > > + omap_wakeupgen_init(); > + > gic_init(0, 29, gic_dist_base_addr, gic_cpu_base); > } Do you really need to initialize all of this that early? Tony