From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [pm-core][PATCH v3 14/21] OMAP4: pm-debug: Add wakeup timer and debug counters Date: Mon, 28 Mar 2011 14:00:46 -0700 Message-ID: <20110328210046.GE30616@atomide.com> References: <1301304157-2466-1-git-send-email-santosh.shilimkar@ti.com> <1301304157-2466-15-git-send-email-santosh.shilimkar@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:33379 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755226Ab1C1VAu (ORCPT ); Mon, 28 Mar 2011 17:00:50 -0400 Content-Disposition: inline In-Reply-To: <1301304157-2466-15-git-send-email-santosh.shilimkar@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Santosh Shilimkar Cc: linux-omap@vger.kernel.org, khilman@ti.com, rnayak@ti.com, linux-arm-kernel@lists.infradead.org * Santosh Shilimkar [110328 02:21]: > --- a/arch/arm/mach-omap2/pm-debug.c > +++ b/arch/arm/mach-omap2/pm-debug.c > @@ -40,6 +41,11 @@ static int omap4_pm_suspend(void) > int state, ret = 0; > u32 cpu_id = smp_processor_id(); > > + /* Wakeup timer from suspend */ > + if (wakeup_timer_seconds || wakeup_timer_milliseconds) > + omap2_pm_wakeup_on_timer(wakeup_timer_seconds, > + wakeup_timer_milliseconds); > + > /* Save current powerdomain state */ > list_for_each_entry(pwrst, &pwrst_list, node) { > pwrst->saved_state = pwrdm_read_next_pwrst(pwrst->pwrdm); This hack to mess diretly with sys_timer will be ripped out, so please drop this patch. In the long run we'll have dmtimer1 dedicated to the PM code, so then it's possible to do similar things. Tony