* RE: [PATCH] mfd: Fix usbhs_enable error handling
[not found] <1301393275.2253.7.camel@phoenix>
@ 2011-03-29 10:35 ` Keshava Munegowda
2011-03-29 11:06 ` Felipe Balbi
0 siblings, 1 reply; 10+ messages in thread
From: Keshava Munegowda @ 2011-03-29 10:35 UTC (permalink / raw)
To: Axel Lin, linux-kernel, linux-usb, linux-omap; +Cc: Samuel Ortiz
> -----Original Message-----
> From: Axel Lin [mailto:axel.lin@gmail.com]
> Sent: Tuesday, March 29, 2011 3:38 PM
> To: linux-kernel@vger.kernel.org
> Cc: Keshava Munegowda; Samuel Ortiz
> Subject: [PATCH] mfd: Fix usbhs_enable error handling
>
> In the case of missing platform_data we do not hold a spin_lock,
> thus we should not call spin_unlock_irqrestore in the error path.
>
> Also simplify the error handling by separating the successful path
> from error path. I think this change improves readability.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/mfd/omap-usb-host.c | 8 +++-----
> 1 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
> index cb01209..4157d76 100644
> --- a/drivers/mfd/omap-usb-host.c
> +++ b/drivers/mfd/omap-usb-host.c
> @@ -700,8 +700,7 @@ static int usbhs_enable(struct device *dev)
> dev_dbg(dev, "starting TI HSUSB Controller\n");
> if (!pdata) {
> dev_dbg(dev, "missing platform_data\n");
> - ret = -ENODEV;
> - goto end_enable;
> + return -ENODEV;
> }
>
> spin_lock_irqsave(&omap->lock, flags);
> @@ -915,7 +914,8 @@ static int usbhs_enable(struct device *dev)
>
> end_count:
> omap->count++;
> - goto end_enable;
> + spin_unlock_irqrestore(&omap->lock, flags);
> + return 0;
>
> err_tll:
> if (pdata->ehci_data->phy_reset) {
> @@ -931,8 +931,6 @@ err_tll:
> clk_disable(omap->usbhost_fs_fck);
> clk_disable(omap->usbhost_hs_fck);
> clk_disable(omap->usbhost_ick);
> -
> -end_enable:
> spin_unlock_irqrestore(&omap->lock, flags);
> return ret;
> }
> --
> 1.7.1
Thanks Axel!
Acked-by: Keshava Munegowda < keshava_mgowda@ti.com>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] mfd: Fix usbhs_enable error handling
2011-03-29 10:35 ` [PATCH] mfd: Fix usbhs_enable error handling Keshava Munegowda
@ 2011-03-29 11:06 ` Felipe Balbi
0 siblings, 0 replies; 10+ messages in thread
From: Felipe Balbi @ 2011-03-29 11:06 UTC (permalink / raw)
To: Keshava Munegowda
Cc: Axel Lin, linux-kernel, linux-usb, linux-omap, Samuel Ortiz
On Tue, Mar 29, 2011 at 04:05:40PM +0530, Keshava Munegowda wrote:
> > -----Original Message-----
> > From: Axel Lin [mailto:axel.lin@gmail.com]
> > Sent: Tuesday, March 29, 2011 3:38 PM
> > To: linux-kernel@vger.kernel.org
> > Cc: Keshava Munegowda; Samuel Ortiz
> > Subject: [PATCH] mfd: Fix usbhs_enable error handling
> >
> > In the case of missing platform_data we do not hold a spin_lock,
> > thus we should not call spin_unlock_irqrestore in the error path.
> >
> > Also simplify the error handling by separating the successful path
> > from error path. I think this change improves readability.
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
> > ---
> > drivers/mfd/omap-usb-host.c | 8 +++-----
> > 1 files changed, 3 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
> > index cb01209..4157d76 100644
> > --- a/drivers/mfd/omap-usb-host.c
> > +++ b/drivers/mfd/omap-usb-host.c
> > @@ -700,8 +700,7 @@ static int usbhs_enable(struct device *dev)
> > dev_dbg(dev, "starting TI HSUSB Controller\n");
> > if (!pdata) {
> > dev_dbg(dev, "missing platform_data\n");
> > - ret = -ENODEV;
> > - goto end_enable;
> > + return -ENODEV;
> > }
> >
> > spin_lock_irqsave(&omap->lock, flags);
> > @@ -915,7 +914,8 @@ static int usbhs_enable(struct device *dev)
> >
> > end_count:
> > omap->count++;
> > - goto end_enable;
> > + spin_unlock_irqrestore(&omap->lock, flags);
> > + return 0;
> >
> > err_tll:
> > if (pdata->ehci_data->phy_reset) {
> > @@ -931,8 +931,6 @@ err_tll:
> > clk_disable(omap->usbhost_fs_fck);
> > clk_disable(omap->usbhost_hs_fck);
> > clk_disable(omap->usbhost_ick);
> > -
> > -end_enable:
> > spin_unlock_irqrestore(&omap->lock, flags);
> > return ret;
> > }
> > --
> > 1.7.1
>
> Thanks Axel!
> Acked-by: Keshava Munegowda < keshava_mgowda@ti.com>
Samuel, Greg is out for the week, could you take this one through your
tree instead of waiting for a week until we get this fix merged. If you
need my Ack, here it goes:
Acked-by: Felipe Balbi <balbi@ti.com>
--
balbi
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] mfd: Fix usbhs_enable error handling
@ 2011-04-21 14:22 Keshava Munegowda
[not found] ` <1303395763-8702-1-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
0 siblings, 1 reply; 10+ messages in thread
From: Keshava Munegowda @ 2011-04-21 14:22 UTC (permalink / raw)
To: linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA
Cc: Keshava Munegowda, balbi-l0cyMroinI0, gadiyar-l0cyMroinI0,
p-basak2-l0cyMroinI0, axel.lin-Re5JQEeQqe8AvxtiuMwx3w,
johnstul-r/Jw6+rmf7HQT0dZR+AlfA, mpfj-list-kZtEnBLzDKq1Qrn1Bg8BZw
From: Axel Lin <axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
In the case of missing platform_data we do not hold a spin_lock,
thus we should not call spin_unlock_irqrestore in the error path.
Also simplify the error handling by separating the successful path
from error path. I think this change improves readability.
Signed-off-by: Axel Lin <axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
drivers/mfd/omap-usb-host.c | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
index 53450f4..b3bb3ac 100644
--- a/drivers/mfd/omap-usb-host.c
+++ b/drivers/mfd/omap-usb-host.c
@@ -700,8 +700,7 @@ static int usbhs_enable(struct device *dev)
dev_dbg(dev, "starting TI HSUSB Controller\n");
if (!pdata) {
dev_dbg(dev, "missing platform_data\n");
- ret = -ENODEV;
- goto end_enable;
+ return -ENODEV;
}
spin_lock_irqsave(&omap->lock, flags);
@@ -915,7 +914,8 @@ static int usbhs_enable(struct device *dev)
end_count:
omap->count++;
- goto end_enable;
+ spin_unlock_irqrestore(&omap->lock, flags);
+ return 0;
err_tll:
if (pdata->ehci_data->phy_reset) {
@@ -931,8 +931,6 @@ err_tll:
clk_disable(omap->usbhost_fs_fck);
clk_disable(omap->usbhost_hs_fck);
clk_disable(omap->usbhost_ick);
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] mfd: Fix usbhs_enable error handling
[not found] ` <1303395763-8702-1-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
@ 2011-04-26 8:58 ` Felipe Balbi
[not found] ` <20110426085846.GI13227-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-05-02 9:37 ` Felipe Balbi
1 sibling, 1 reply; 10+ messages in thread
From: Felipe Balbi @ 2011-04-26 8:58 UTC (permalink / raw)
To: Keshava Munegowda
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA, balbi-l0cyMroinI0,
gadiyar-l0cyMroinI0, p-basak2-l0cyMroinI0,
axel.lin-Re5JQEeQqe8AvxtiuMwx3w, johnstul-r/Jw6+rmf7HQT0dZR+AlfA,
mpfj-list-kZtEnBLzDKq1Qrn1Bg8BZw
Hi,
On Thu, Apr 21, 2011 at 07:52:41PM +0530, Keshava Munegowda wrote:
> From: Axel Lin <axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> In the case of missing platform_data we do not hold a spin_lock,
> thus we should not call spin_unlock_irqrestore in the error path.
>
> Also simplify the error handling by separating the successful path
> from error path. I think this change improves readability.
>
> Signed-off-by: Axel Lin <axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Can someone give me a Tested-by so I can take these patches.
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] mfd: Fix usbhs_enable error handling
[not found] ` <20110426085846.GI13227-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
@ 2011-04-26 9:02 ` Keshava Munegowda
2011-04-26 9:04 ` Felipe Balbi
0 siblings, 1 reply; 10+ messages in thread
From: Keshava Munegowda @ 2011-04-26 9:02 UTC (permalink / raw)
To: balbi-l0cyMroinI0
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA, Anand Gadiyar, Partha Basak,
axel.lin-Re5JQEeQqe8AvxtiuMwx3w, johnstul-r/Jw6+rmf7HQT0dZR+AlfA,
mpfj-list-kZtEnBLzDKq1Qrn1Bg8BZw
> -----Original Message-----
> From: Felipe Balbi [mailto:balbi-l0cyMroinI0@public.gmane.org]
> Sent: Tuesday, April 26, 2011 2:29 PM
> To: Keshava Munegowda
> Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; balbi-l0cyMroinI0@public.gmane.org;
gadiyar-l0cyMroinI0@public.gmane.org; p-
> basak2-l0cyMroinI0@public.gmane.org; axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org; johnstul-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org;
mpfj-list-kZtEnBLzDKq1Qrn1Bg8BZw@public.gmane.org
> Subject: Re: [PATCH] mfd: Fix usbhs_enable error handling
>
> Hi,
>
> On Thu, Apr 21, 2011 at 07:52:41PM +0530, Keshava Munegowda wrote:
> > From: Axel Lin <axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >
> > In the case of missing platform_data we do not hold a spin_lock,
> > thus we should not call spin_unlock_irqrestore in the error path.
> >
> > Also simplify the error handling by separating the successful path
> > from error path. I think this change improves readability.
> >
> > Signed-off-by: Axel Lin <axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> Can someone give me a Tested-by so I can take these patches.
>
> --
> Balbi
Hi Balbi
I have validated this patch and it works :)
Tested-by: Keshava Munegowda <keshava_mgowda-l0cyMroinI0@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] mfd: Fix usbhs_enable error handling
2011-04-26 9:02 ` Keshava Munegowda
@ 2011-04-26 9:04 ` Felipe Balbi
[not found] ` <20110426090418.GJ13227-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
0 siblings, 1 reply; 10+ messages in thread
From: Felipe Balbi @ 2011-04-26 9:04 UTC (permalink / raw)
To: Keshava Munegowda
Cc: balbi, linux-usb, linux-omap, Anand Gadiyar, Partha Basak,
axel.lin, johnstul, mpfj-list
On Tue, Apr 26, 2011 at 02:32:04PM +0530, Keshava Munegowda wrote:
> > -----Original Message-----
> > From: Felipe Balbi [mailto:balbi@ti.com]
> > Sent: Tuesday, April 26, 2011 2:29 PM
> > To: Keshava Munegowda
> > Cc: linux-usb@vger.kernel.org; linux-omap@vger.kernel.org; balbi@ti.com;
> gadiyar@ti.com; p-
> > basak2@ti.com; axel.lin@gmail.com; johnstul@us.ibm.com;
> mpfj-list@mimc.co.uk
> > Subject: Re: [PATCH] mfd: Fix usbhs_enable error handling
> >
> > Hi,
> >
> > On Thu, Apr 21, 2011 at 07:52:41PM +0530, Keshava Munegowda wrote:
> > > From: Axel Lin <axel.lin@gmail.com>
> > >
> > > In the case of missing platform_data we do not hold a spin_lock,
> > > thus we should not call spin_unlock_irqrestore in the error path.
> > >
> > > Also simplify the error handling by separating the successful path
> > > from error path. I think this change improves readability.
> > >
> > > Signed-off-by: Axel Lin <axel.lin@gmail.com>
> >
> > Can someone give me a Tested-by so I can take these patches.
> >
> > --
> > Balbi
>
> Hi Balbi
>
> I have validated this patch and it works :)
>
> Tested-by: Keshava Munegowda <keshava_mgowda@ti.com>
what about the others ?
--
balbi
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] mfd: Fix usbhs_enable error handling
[not found] ` <20110426090418.GJ13227-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
@ 2011-04-26 15:09 ` Steve Calfee
[not found] ` <BANLkTi=NB5as-Kz8bSCvh3=KPQR1wwXUOQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 10+ messages in thread
From: Steve Calfee @ 2011-04-26 15:09 UTC (permalink / raw)
To: balbi-l0cyMroinI0
Cc: Keshava Munegowda, linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA, Anand Gadiyar, Partha Basak,
axel.lin-Re5JQEeQqe8AvxtiuMwx3w, johnstul-r/Jw6+rmf7HQT0dZR+AlfA,
mpfj-list-kZtEnBLzDKq1Qrn1Bg8BZw
On Tue, Apr 26, 2011 at 2:04 AM, Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org> wrote:
> On Tue, Apr 26, 2011 at 02:32:04PM +0530, Keshava Munegowda wrote:
>> > -----Original Message-----
>> > From: Felipe Balbi [mailto:balbi-l0cyMroinI0@public.gmane.org]
>> > Sent: Tuesday, April 26, 2011 2:29 PM
>> > To: Keshava Munegowda
>> > Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; balbi-l0cyMroinI0@public.gmane.org;
>> gadiyar-l0cyMroinI0@public.gmane.org; p-
>> > basak2-l0cyMroinI0@public.gmane.org; axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org; johnstul-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org;
>> mpfj-list-kZtEnBLzDKq1Qrn1Bg8BZw@public.gmane.org
>> > Subject: Re: [PATCH] mfd: Fix usbhs_enable error handling
>> >
>> > Hi,
>> >
>> > On Thu, Apr 21, 2011 at 07:52:41PM +0530, Keshava Munegowda wrote:
>> > > From: Axel Lin <axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> > >
>> > > In the case of missing platform_data we do not hold a spin_lock,
>> > > thus we should not call spin_unlock_irqrestore in the error path.
>> > >
>> > > Also simplify the error handling by separating the successful path
>> > > from error path. I think this change improves readability.
>> > >
>> > > Signed-off-by: Axel Lin <axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> >
>> > Can someone give me a Tested-by so I can take these patches.
>> >
>> > --
>> > Balbi
>>
>> Hi Balbi
>>
>> I have validated this patch and it works :)
>>
>> Tested-by: Keshava Munegowda <keshava_mgowda-l0cyMroinI0@public.gmane.org>
>
> what about the others ?
>
> --
> balbi
Hi Felipe,
I responded on another thread. I tested this on a beagleboardxm on
version 2.6.39-rc4
> Hi Keshava,
>
> I rebuilt my system to boot from flash and now I see what happened. I
> even remember it being discussed on this list. Someone renamed my usb
> ethernet device from usb0 to eth0 !!! The boot log shows it on this
line:
>
> > [ 4.596130] smsc95xx 1-2.1:1.0: eth0: register 'smsc95xx' at
> > usb-ehci-omap.0d
>
>
> So this broke my init scripts and uboot script... OK, so I can live with
> this (I hope the name doesn't change too often though).
>
> So I can manually configure my system to use eth0 and use the network. I
> am sure I will get nfs working shortly.
>
> I am using the 2.6.39-rc4 with your 3 patches. So from the Beagleboard
> XM perspective it works and you can include my
>
> Tested-by: Steve Calfee <stevecalfee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] mfd: Fix usbhs_enable error handling
[not found] ` <BANLkTi=NB5as-Kz8bSCvh3=KPQR1wwXUOQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2011-04-26 19:34 ` Felipe Balbi
[not found] ` <20110426193407.GR13227-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
0 siblings, 1 reply; 10+ messages in thread
From: Felipe Balbi @ 2011-04-26 19:34 UTC (permalink / raw)
To: Steve Calfee
Cc: balbi-l0cyMroinI0, Keshava Munegowda,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA, Anand Gadiyar, Partha Basak,
axel.lin-Re5JQEeQqe8AvxtiuMwx3w, johnstul-r/Jw6+rmf7HQT0dZR+AlfA,
mpfj-list-kZtEnBLzDKq1Qrn1Bg8BZw
On Tue, Apr 26, 2011 at 08:09:17AM -0700, Steve Calfee wrote:
> On Tue, Apr 26, 2011 at 2:04 AM, Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org> wrote:
> > On Tue, Apr 26, 2011 at 02:32:04PM +0530, Keshava Munegowda wrote:
> >> > -----Original Message-----
> >> > From: Felipe Balbi [mailto:balbi-l0cyMroinI0@public.gmane.org]
> >> > Sent: Tuesday, April 26, 2011 2:29 PM
> >> > To: Keshava Munegowda
> >> > Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; balbi-l0cyMroinI0@public.gmane.org;
> >> gadiyar-l0cyMroinI0@public.gmane.org; p-
> >> > basak2-l0cyMroinI0@public.gmane.org; axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org; johnstul-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org;
> >> mpfj-list-kZtEnBLzDKq1Qrn1Bg8BZw@public.gmane.org
> >> > Subject: Re: [PATCH] mfd: Fix usbhs_enable error handling
> >> >
> >> > Hi,
> >> >
> >> > On Thu, Apr 21, 2011 at 07:52:41PM +0530, Keshava Munegowda wrote:
> >> > > From: Axel Lin <axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >> > >
> >> > > In the case of missing platform_data we do not hold a spin_lock,
> >> > > thus we should not call spin_unlock_irqrestore in the error path.
> >> > >
> >> > > Also simplify the error handling by separating the successful path
> >> > > from error path. I think this change improves readability.
> >> > >
> >> > > Signed-off-by: Axel Lin <axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >> >
> >> > Can someone give me a Tested-by so I can take these patches.
> >> >
> >> > --
> >> > Balbi
> >>
> >> Hi Balbi
> >>
> >> I have validated this patch and it works :)
> >>
> >> Tested-by: Keshava Munegowda <keshava_mgowda-l0cyMroinI0@public.gmane.org>
> >
> > what about the others ?
> >
> > --
> > balbi
>
> Hi Felipe,
>
> I responded on another thread. I tested this on a beagleboardxm on
> version 2.6.39-rc4
care to reply to this one with your Tested-by so I add to all patches
and queue them to Greg ?
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] mfd: Fix usbhs_enable error handling
[not found] ` <20110426193407.GR13227-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
@ 2011-04-26 20:57 ` Steve Calfee
0 siblings, 0 replies; 10+ messages in thread
From: Steve Calfee @ 2011-04-26 20:57 UTC (permalink / raw)
To: balbi-l0cyMroinI0
Cc: Keshava Munegowda, linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA, Anand Gadiyar, Partha Basak,
axel.lin-Re5JQEeQqe8AvxtiuMwx3w, johnstul-r/Jw6+rmf7HQT0dZR+AlfA,
mpfj-list-kZtEnBLzDKq1Qrn1Bg8BZw
On 04/26/11 12:34, Felipe Balbi wrote:
>
> care to reply to this one with your Tested-by so I add to all patches
> and queue them to Greg ?
>
I just checked and these changes were part of the 3 patch set from
Keshava, and from the Beagleboard XM perspective it works and you can
include my
Tested-by: Steve Calfee <stevecalfee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] mfd: Fix usbhs_enable error handling
[not found] ` <1303395763-8702-1-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2011-04-26 8:58 ` Felipe Balbi
@ 2011-05-02 9:37 ` Felipe Balbi
1 sibling, 0 replies; 10+ messages in thread
From: Felipe Balbi @ 2011-05-02 9:37 UTC (permalink / raw)
To: Keshava Munegowda
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA, balbi-l0cyMroinI0,
gadiyar-l0cyMroinI0, p-basak2-l0cyMroinI0,
axel.lin-Re5JQEeQqe8AvxtiuMwx3w, johnstul-r/Jw6+rmf7HQT0dZR+AlfA,
mpfj-list-kZtEnBLzDKq1Qrn1Bg8BZw
On Thu, Apr 21, 2011 at 07:52:41PM +0530, Keshava Munegowda wrote:
> From: Axel Lin <axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> In the case of missing platform_data we do not hold a spin_lock,
> thus we should not call spin_unlock_irqrestore in the error path.
>
> Also simplify the error handling by separating the successful path
> from error path. I think this change improves readability.
>
> Signed-off-by: Axel Lin <axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
applied, thanks
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2011-05-02 9:37 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1301393275.2253.7.camel@phoenix>
2011-03-29 10:35 ` [PATCH] mfd: Fix usbhs_enable error handling Keshava Munegowda
2011-03-29 11:06 ` Felipe Balbi
2011-04-21 14:22 Keshava Munegowda
[not found] ` <1303395763-8702-1-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2011-04-26 8:58 ` Felipe Balbi
[not found] ` <20110426085846.GI13227-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-04-26 9:02 ` Keshava Munegowda
2011-04-26 9:04 ` Felipe Balbi
[not found] ` <20110426090418.GJ13227-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-04-26 15:09 ` Steve Calfee
[not found] ` <BANLkTi=NB5as-Kz8bSCvh3=KPQR1wwXUOQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-04-26 19:34 ` Felipe Balbi
[not found] ` <20110426193407.GR13227-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-04-26 20:57 ` Steve Calfee
2011-05-02 9:37 ` Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).