Linux on ARM based TI OMAP SoCs
 help / color / mirror / Atom feed
From: "Avinash.H.M." <avinashhm@ti.com>
To: Kevin Hilman <khilman@ti.com>
Cc: Paul Walmsley <paul@pwsan.com>,
	linux-omap@vger.kernel.org, Rajendra Nayak <rnayak@ti.com>,
	Benoit Cousson <b-cousson@ti.com>
Subject: Re: [PATCH] omap: hwmod: add syss reset done flags to omap2, omap3 hwmods
Date: Thu, 31 Mar 2011 21:21:42 +0530	[thread overview]
Message-ID: <20110331155142.GB18054@avinash-laptop> (raw)
In-Reply-To: <871v1njpq2.fsf@ti.com>

> > The problem is the FCLK isn't enabled for these gpios(2..6) while
> > resetting.  So the GPIO's are not resetting properly. Once i enable FCLK
> > for them and then set the SYSCONFIG.SOFTRESET, then they are resetting
> > and it is reflected in RESETDONE bit.
> 
> What do you mean by fclk here.  GPIO doesn't have an fclk.  The
> interface clock provides the functional clock, and the optional debounce
> clock (dbclk) is needed only when GPIO debounce is enabled.
> 
> I suggest you look at the "integration" sub chapter of the TRM for the
> GPIO module.

Hi Kevin , 

I looked at this section. Now i am clear about the code. I meant fclk as
functional clocks which is described by register CM_FCLKEN_PER, bit 12
to bit 17. These bits are described as they control 'GPIO x functional
clock'.

Looking at the GPIO chapter, i understood that this is same as the gpio
dbck. This was confirmed by section 'PER Power Domain Clock Controls'
where he says CM_FCLKEN_PER[12-17] control PER_32K_ALWON_FCLK which is
routed as GPIOx_DBCLK.

[...]

> 
> There are no GPIO fclks.
> 
> > Also 'fclk' is structured as 'gpio2_dbck' and made as an optional
> > clock.  I wasn't very sure, why the name 'dbck'?
> 
> dbck == debounce clock

I got it. Thanks for the clarification. 

Looks like without this clock, GPIO module isn't resetting even on
writing to SYSCONFIG register. Should we provide a seperate reset
function for gpio, like the way it was suggested for i2c ?

br ,
- Avinash

> 
> Kevin

  reply	other threads:[~2011-03-31 15:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-24 10:08 [PATCH] omap: hwmod: add syss reset done flags to omap2, omap3 hwmods Avinash.H.M
2011-03-03 21:28 ` Paul Walmsley
2011-03-14 16:16   ` Avinash.H.M.
2011-03-25  5:38     ` Paul Walmsley
2011-03-25  6:26       ` Avinash.H.M.
2011-03-25  7:20         ` Avinash.H.M.
2011-03-25 17:24           ` Paul Walmsley
2011-03-26 11:35             ` Avinash.H.M.
2011-03-26 19:38               ` Paul Walmsley
2011-03-31 14:40               ` Avinash.H.M.
2011-03-31 15:04                 ` Kevin Hilman
2011-03-31 15:51                   ` Avinash.H.M. [this message]
2011-03-31 15:56                     ` Cousson, Benoit
2011-03-31 16:22                       ` Avinash.H.M.
2011-03-25 14:42       ` Cousson, Benoit
2011-03-25 17:23         ` Paul Walmsley
2011-03-26 11:31           ` Avinash.H.M.
2011-03-31 13:06             ` Avinash.H.M.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110331155142.GB18054@avinash-laptop \
    --to=avinashhm@ti.com \
    --cc=b-cousson@ti.com \
    --cc=khilman@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=rnayak@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox