* RX-51: Platform support for lp5523 @ 2011-03-29 17:29 Sebastian Reichel 2011-03-29 17:36 ` Tony Lindgren 0 siblings, 1 reply; 14+ messages in thread From: Sebastian Reichel @ 2011-03-29 17:29 UTC (permalink / raw) To: linux-omap [-- Attachment #1: Type: text/plain, Size: 169 bytes --] Hi, Is there any reason, that the rx51 platform code does not support the lp5523 chip? The chip driver itself is in the mainline kernel since 2.6.37-rc2. -- Sebastian [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: RX-51: Platform support for lp5523 2011-03-29 17:29 RX-51: Platform support for lp5523 Sebastian Reichel @ 2011-03-29 17:36 ` Tony Lindgren 2011-03-29 18:16 ` Sebastian Reichel 0 siblings, 1 reply; 14+ messages in thread From: Tony Lindgren @ 2011-03-29 17:36 UTC (permalink / raw) To: Sebastian Reichel; +Cc: linux-omap * Sebastian Reichel <sre@debian.org> [110329 10:26]: > Hi, > > Is there any reason, that the rx51 platform code does not support > the lp5523 chip? The chip driver itself is in the mainline kernel > since 2.6.37-rc2. Got a patch for that? As always, patches related to blinking leds have a special high priority here! :) Regards, Tony ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: RX-51: Platform support for lp5523 2011-03-29 17:36 ` Tony Lindgren @ 2011-03-29 18:16 ` Sebastian Reichel 2011-03-29 19:33 ` Tony Lindgren 0 siblings, 1 reply; 14+ messages in thread From: Sebastian Reichel @ 2011-03-29 18:16 UTC (permalink / raw) To: Tony Lindgren; +Cc: linux-omap, Ameya Palande [-- Attachment #1: Type: text/plain, Size: 667 bytes --] On Tue, Mar 29, 2011 at 10:36:47AM -0700, Tony Lindgren wrote: > * Sebastian Reichel <sre@debian.org> [110329 10:26]: > > Is there any reason, that the rx51 platform code does not support > > the lp5523 chip? The chip driver itself is in the mainline kernel > > since 2.6.37-rc2. > > Got a patch for that? As always, patches related to blinking leds > have a special high priority here! :) Ameya Palande has written one, which is available at [0]. I added him to CC, so that he can comment on mainline inclusion. [0] http://gitorious.org/nokia-n900-kernel/nokia-n900-kernel/commit/54caed7bdc7e9f5aa84fe50f3bc321fc1ef600ad?format=patch -- Sebastian [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: RX-51: Platform support for lp5523 2011-03-29 18:16 ` Sebastian Reichel @ 2011-03-29 19:33 ` Tony Lindgren 2011-03-31 12:20 ` Ameya Palande 2011-04-05 12:10 ` Ameya Palande 0 siblings, 2 replies; 14+ messages in thread From: Tony Lindgren @ 2011-03-29 19:33 UTC (permalink / raw) To: Sebastian Reichel; +Cc: linux-omap, Ameya Palande * Sebastian Reichel <sre@debian.org> [110329 11:13]: > On Tue, Mar 29, 2011 at 10:36:47AM -0700, Tony Lindgren wrote: > > * Sebastian Reichel <sre@debian.org> [110329 10:26]: > > > Is there any reason, that the rx51 platform code does not support > > > the lp5523 chip? The chip driver itself is in the mainline kernel > > > since 2.6.37-rc2. > > > > Got a patch for that? As always, patches related to blinking leds > > have a special high priority here! :) > > Ameya Palande has written one, which is available at [0]. I added > him to CC, so that he can comment on mainline inclusion. OK. Ameya, can you please post it for review for this list with linux-arm-kernel list Cc'd? Regards, Tony > [0] http://gitorious.org/nokia-n900-kernel/nokia-n900-kernel/commit/54caed7bdc7e9f5aa84fe50f3bc321fc1ef600ad?format=patch ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: RX-51: Platform support for lp5523 2011-03-29 19:33 ` Tony Lindgren @ 2011-03-31 12:20 ` Ameya Palande 2011-04-05 12:10 ` Ameya Palande 1 sibling, 0 replies; 14+ messages in thread From: Ameya Palande @ 2011-03-31 12:20 UTC (permalink / raw) To: ext Tony Lindgren; +Cc: Sebastian Reichel, linux-omap Hi Tony, On 03/29/2011 10:33 PM, ext Tony Lindgren wrote: > * Sebastian Reichel<sre@debian.org> [110329 11:13]: >> On Tue, Mar 29, 2011 at 10:36:47AM -0700, Tony Lindgren wrote: >>> * Sebastian Reichel<sre@debian.org> [110329 10:26]: >>>> Is there any reason, that the rx51 platform code does not support >>>> the lp5523 chip? The chip driver itself is in the mainline kernel >>>> since 2.6.37-rc2. >>> >>> Got a patch for that? As always, patches related to blinking leds >>> have a special high priority here! :) >> >> Ameya Palande has written one, which is available at [0]. I added >> him to CC, so that he can comment on mainline inclusion. > > OK. Ameya, can you please post it for review for this list with > linux-arm-kernel list Cc'd? Done! Here is the patch: http://marc.info/?l=linux-omap&m=130157389724187&w=2 Cheers, Ameya. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: RX-51: Platform support for lp5523 2011-03-29 19:33 ` Tony Lindgren 2011-03-31 12:20 ` Ameya Palande @ 2011-04-05 12:10 ` Ameya Palande 2011-04-05 12:19 ` Felipe Balbi 1 sibling, 1 reply; 14+ messages in thread From: Ameya Palande @ 2011-04-05 12:10 UTC (permalink / raw) To: ext Tony Lindgren; +Cc: Sebastian Reichel, linux-omap Hi Tony, On 03/29/2011 10:33 PM, ext Tony Lindgren wrote: > * Sebastian Reichel<sre@debian.org> [110329 11:13]: >> On Tue, Mar 29, 2011 at 10:36:47AM -0700, Tony Lindgren wrote: >>> * Sebastian Reichel<sre@debian.org> [110329 10:26]: >>>> Is there any reason, that the rx51 platform code does not support >>>> the lp5523 chip? The chip driver itself is in the mainline kernel >>>> since 2.6.37-rc2. >>> >>> Got a patch for that? As always, patches related to blinking leds >>> have a special high priority here! :) >> >> Ameya Palande has written one, which is available at [0]. I added >> him to CC, so that he can comment on mainline inclusion. > > OK. Ameya, can you please post it for review for this list with > linux-arm-kernel list Cc'd? > > Regards, > > Tony > >> [0] http://gitorious.org/nokia-n900-kernel/nokia-n900-kernel/commit/54caed7bdc7e9f5aa84fe50f3bc321fc1ef600ad?format=patch Can we get following patch in for 2.6.39-rc2? http://marc.info/?l=linux-omap&m=130200500812156&w=2 Cheers, Ameya. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: RX-51: Platform support for lp5523 2011-04-05 12:10 ` Ameya Palande @ 2011-04-05 12:19 ` Felipe Balbi 2011-04-05 12:23 ` Ameya Palande 0 siblings, 1 reply; 14+ messages in thread From: Felipe Balbi @ 2011-04-05 12:19 UTC (permalink / raw) To: Ameya Palande; +Cc: ext Tony Lindgren, Sebastian Reichel, linux-omap On Tue, Apr 05, 2011 at 03:10:41PM +0300, Ameya Palande wrote: > Hi Tony, > > On 03/29/2011 10:33 PM, ext Tony Lindgren wrote: > >* Sebastian Reichel<sre@debian.org> [110329 11:13]: > >>On Tue, Mar 29, 2011 at 10:36:47AM -0700, Tony Lindgren wrote: > >>>* Sebastian Reichel<sre@debian.org> [110329 10:26]: > >>>>Is there any reason, that the rx51 platform code does not support > >>>>the lp5523 chip? The chip driver itself is in the mainline kernel > >>>>since 2.6.37-rc2. > >>> > >>>Got a patch for that? As always, patches related to blinking leds > >>>have a special high priority here! :) > >> > >>Ameya Palande has written one, which is available at [0]. I added > >>him to CC, so that he can comment on mainline inclusion. > > > >OK. Ameya, can you please post it for review for this list with > >linux-arm-kernel list Cc'd? > > > >Regards, > > > >Tony > > > >>[0] http://gitorious.org/nokia-n900-kernel/nokia-n900-kernel/commit/54caed7bdc7e9f5aa84fe50f3bc321fc1ef600ad?format=patch > > Can we get following patch in for 2.6.39-rc2? > http://marc.info/?l=linux-omap&m=130200500812156&w=2 Tony will say for sure, but I don't consider that a bugfix, so you need to wait next merge window for that to reach mainline :- -- balbi ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: RX-51: Platform support for lp5523 2011-04-05 12:19 ` Felipe Balbi @ 2011-04-05 12:23 ` Ameya Palande 2011-04-05 12:30 ` Felipe Balbi 0 siblings, 1 reply; 14+ messages in thread From: Ameya Palande @ 2011-04-05 12:23 UTC (permalink / raw) To: balbi; +Cc: ext Tony Lindgren, Sebastian Reichel, linux-omap On 04/05/2011 03:19 PM, ext Felipe Balbi wrote: > On Tue, Apr 05, 2011 at 03:10:41PM +0300, Ameya Palande wrote: >> Hi Tony, >> >> On 03/29/2011 10:33 PM, ext Tony Lindgren wrote: >>> * Sebastian Reichel<sre@debian.org> [110329 11:13]: >>>> On Tue, Mar 29, 2011 at 10:36:47AM -0700, Tony Lindgren wrote: >>>>> * Sebastian Reichel<sre@debian.org> [110329 10:26]: >>>>>> Is there any reason, that the rx51 platform code does not support >>>>>> the lp5523 chip? The chip driver itself is in the mainline kernel >>>>>> since 2.6.37-rc2. >>>>> >>>>> Got a patch for that? As always, patches related to blinking leds >>>>> have a special high priority here! :) >>>> >>>> Ameya Palande has written one, which is available at [0]. I added >>>> him to CC, so that he can comment on mainline inclusion. >>> >>> OK. Ameya, can you please post it for review for this list with >>> linux-arm-kernel list Cc'd? >>> >>> Regards, >>> >>> Tony >>> >>>> [0] http://gitorious.org/nokia-n900-kernel/nokia-n900-kernel/commit/54caed7bdc7e9f5aa84fe50f3bc321fc1ef600ad?format=patch >> >> Can we get following patch in for 2.6.39-rc2? >> http://marc.info/?l=linux-omap&m=130200500812156&w=2 > > Tony will say for sure, but I don't consider that a bugfix, so you need > to wait next merge window for that to reach mainline :- It is not a new feature/driver for sure. We are just enabling support for a driver (lp5523) on N900 which is already present in mainline. Cheers, Ameya. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: RX-51: Platform support for lp5523 2011-04-05 12:23 ` Ameya Palande @ 2011-04-05 12:30 ` Felipe Balbi 2011-04-05 12:34 ` Ameya Palande 0 siblings, 1 reply; 14+ messages in thread From: Felipe Balbi @ 2011-04-05 12:30 UTC (permalink / raw) To: Ameya Palande; +Cc: balbi, ext Tony Lindgren, Sebastian Reichel, linux-omap On Tue, Apr 05, 2011 at 03:23:12PM +0300, Ameya Palande wrote: > On 04/05/2011 03:19 PM, ext Felipe Balbi wrote: > >On Tue, Apr 05, 2011 at 03:10:41PM +0300, Ameya Palande wrote: > >>Hi Tony, > >> > >>On 03/29/2011 10:33 PM, ext Tony Lindgren wrote: > >>>* Sebastian Reichel<sre@debian.org> [110329 11:13]: > >>>>On Tue, Mar 29, 2011 at 10:36:47AM -0700, Tony Lindgren wrote: > >>>>>* Sebastian Reichel<sre@debian.org> [110329 10:26]: > >>>>>>Is there any reason, that the rx51 platform code does not support > >>>>>>the lp5523 chip? The chip driver itself is in the mainline kernel > >>>>>>since 2.6.37-rc2. > >>>>> > >>>>>Got a patch for that? As always, patches related to blinking leds > >>>>>have a special high priority here! :) > >>>> > >>>>Ameya Palande has written one, which is available at [0]. I added > >>>>him to CC, so that he can comment on mainline inclusion. > >>> > >>>OK. Ameya, can you please post it for review for this list with > >>>linux-arm-kernel list Cc'd? > >>> > >>>Regards, > >>> > >>>Tony > >>> > >>>>[0] http://gitorious.org/nokia-n900-kernel/nokia-n900-kernel/commit/54caed7bdc7e9f5aa84fe50f3bc321fc1ef600ad?format=patch > >> > >>Can we get following patch in for 2.6.39-rc2? > >>http://marc.info/?l=linux-omap&m=130200500812156&w=2 > > > >Tony will say for sure, but I don't consider that a bugfix, so you need > >to wait next merge window for that to reach mainline :- > > It is not a new feature/driver for sure. We are just enabling support > for a driver (lp5523) on N900 which is already present in mainline. Exactly, adding a new feature. Let me put it this way: which bug or regression are you fixing with this patch ? -- balbi ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: RX-51: Platform support for lp5523 2011-04-05 12:30 ` Felipe Balbi @ 2011-04-05 12:34 ` Ameya Palande 2011-04-05 12:38 ` Felipe Balbi 0 siblings, 1 reply; 14+ messages in thread From: Ameya Palande @ 2011-04-05 12:34 UTC (permalink / raw) To: balbi; +Cc: ext Tony Lindgren, Sebastian Reichel, linux-omap On 04/05/2011 03:30 PM, ext Felipe Balbi wrote: > On Tue, Apr 05, 2011 at 03:23:12PM +0300, Ameya Palande wrote: >> On 04/05/2011 03:19 PM, ext Felipe Balbi wrote: >>> On Tue, Apr 05, 2011 at 03:10:41PM +0300, Ameya Palande wrote: >>>> Hi Tony, >>>> >>>> On 03/29/2011 10:33 PM, ext Tony Lindgren wrote: >>>>> * Sebastian Reichel<sre@debian.org> [110329 11:13]: >>>>>> On Tue, Mar 29, 2011 at 10:36:47AM -0700, Tony Lindgren wrote: >>>>>>> * Sebastian Reichel<sre@debian.org> [110329 10:26]: >>>>>>>> Is there any reason, that the rx51 platform code does not support >>>>>>>> the lp5523 chip? The chip driver itself is in the mainline kernel >>>>>>>> since 2.6.37-rc2. >>>>>>> >>>>>>> Got a patch for that? As always, patches related to blinking leds >>>>>>> have a special high priority here! :) >>>>>> >>>>>> Ameya Palande has written one, which is available at [0]. I added >>>>>> him to CC, so that he can comment on mainline inclusion. >>>>> >>>>> OK. Ameya, can you please post it for review for this list with >>>>> linux-arm-kernel list Cc'd? >>>>> >>>>> Regards, >>>>> >>>>> Tony >>>>> >>>>>> [0] http://gitorious.org/nokia-n900-kernel/nokia-n900-kernel/commit/54caed7bdc7e9f5aa84fe50f3bc321fc1ef600ad?format=patch >>>> >>>> Can we get following patch in for 2.6.39-rc2? >>>> http://marc.info/?l=linux-omap&m=130200500812156&w=2 >>> >>> Tony will say for sure, but I don't consider that a bugfix, so you need >>> to wait next merge window for that to reach mainline :- >> >> It is not a new feature/driver for sure. We are just enabling support >> for a driver (lp5523) on N900 which is already present in mainline. > > Exactly, adding a new feature. Let me put it this way: which bug or > regression are you fixing with this patch ? I never claimed that it is fixing a bug/regression ;) IMHO driver for lp5523 chip is a "new feature" which is already in mainline. This patch just enables use of this feature on N900. Cheers, Ameya. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: RX-51: Platform support for lp5523 2011-04-05 12:34 ` Ameya Palande @ 2011-04-05 12:38 ` Felipe Balbi 2011-04-05 12:59 ` Ameya Palande 0 siblings, 1 reply; 14+ messages in thread From: Felipe Balbi @ 2011-04-05 12:38 UTC (permalink / raw) To: Ameya Palande; +Cc: balbi, ext Tony Lindgren, Sebastian Reichel, linux-omap Hi, On Tue, Apr 05, 2011 at 03:34:08PM +0300, Ameya Palande wrote: > >Exactly, adding a new feature. Let me put it this way: which bug or > >regression are you fixing with this patch ? > > I never claimed that it is fixing a bug/regression ;) but you want this go into the RC cycle, which is strictly bug fixing and regression fixing :-) > IMHO driver for lp5523 chip is a "new feature" which is already in > mainline. This patch just enables use of this feature on N900. enabling the use of that feature on N900 is a new feature for N900 ;-) -- balbi ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: RX-51: Platform support for lp5523 2011-04-05 12:38 ` Felipe Balbi @ 2011-04-05 12:59 ` Ameya Palande 2011-04-05 13:02 ` Felipe Balbi 0 siblings, 1 reply; 14+ messages in thread From: Ameya Palande @ 2011-04-05 12:59 UTC (permalink / raw) To: balbi; +Cc: ext Tony Lindgren, Sebastian Reichel, linux-omap Hi Felipe, On 04/05/2011 03:38 PM, ext Felipe Balbi wrote: > Hi, > > On Tue, Apr 05, 2011 at 03:34:08PM +0300, Ameya Palande wrote: >>> Exactly, adding a new feature. Let me put it this way: which bug or >>> regression are you fixing with this patch ? >> >> I never claimed that it is fixing a bug/regression ;) > > but you want this go into the RC cycle, which is strictly bug fixing and > regression fixing :-) How about following commits since v2.6.39-rc1? 54a93b6 ARM: pxa: PalmZ72: Add OV9640 camera support 54d5710 ARM: PXA: Z2: Add default triggers for LEDs 7780c80 arm: mach-kirkwood: add led in sheevaplug-setup.c 14fb20c ARM: mx53_loco: Add GPIO Keypad support 1b6f1e8 ARM: mxs/mx23evk: add mmc device 4b2a58a libceph: Create a new key type "ceph" 6090912 powerpc: Implement dma_mmap_coherent() 57bd35d microblaze: Wire up new syscalls beb4727 drm/radeon/kms: Add support for tv-out dongle on G5 9600 758f231 drm/radeon/kms: add some new ontario pci ids 41c5789 kernel/signal.c: add kernel-doc notation to syscalls 9a684e1 Documentation: consolidate leds files to leds/ subdir I agree that rc cycle is mostly about bug/regression fixing but there are definitely exceptions for borderline cases and I am trying to check if this patch is such a case ;) Cheers, Ameya. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: RX-51: Platform support for lp5523 2011-04-05 12:59 ` Ameya Palande @ 2011-04-05 13:02 ` Felipe Balbi 2011-04-20 15:19 ` Tony Lindgren 0 siblings, 1 reply; 14+ messages in thread From: Felipe Balbi @ 2011-04-05 13:02 UTC (permalink / raw) To: Ameya Palande; +Cc: balbi, ext Tony Lindgren, Sebastian Reichel, linux-omap Hi, On Tue, Apr 05, 2011 at 03:59:32PM +0300, Ameya Palande wrote: > On 04/05/2011 03:38 PM, ext Felipe Balbi wrote: > >Hi, > > > >On Tue, Apr 05, 2011 at 03:34:08PM +0300, Ameya Palande wrote: > >>>Exactly, adding a new feature. Let me put it this way: which bug or > >>>regression are you fixing with this patch ? > >> > >>I never claimed that it is fixing a bug/regression ;) > > > >but you want this go into the RC cycle, which is strictly bug fixing and > >regression fixing :-) > > How about following commits since v2.6.39-rc1? > > 54a93b6 ARM: pxa: PalmZ72: Add OV9640 camera support > 54d5710 ARM: PXA: Z2: Add default triggers for LEDs > 7780c80 arm: mach-kirkwood: add led in sheevaplug-setup.c > 14fb20c ARM: mx53_loco: Add GPIO Keypad support > 1b6f1e8 ARM: mxs/mx23evk: add mmc device > 4b2a58a libceph: Create a new key type "ceph" > 6090912 powerpc: Implement dma_mmap_coherent() > 57bd35d microblaze: Wire up new syscalls > beb4727 drm/radeon/kms: Add support for tv-out dongle on G5 9600 > 758f231 drm/radeon/kms: add some new ontario pci ids > 41c5789 kernel/signal.c: add kernel-doc notation to syscalls > 9a684e1 Documentation: consolidate leds files to leds/ subdir > > I agree that rc cycle is mostly about bug/regression fixing but there > are definitely exceptions for borderline cases and I am trying to > check if this patch is such a case ;) Like I said: Tony is the final judge here. :-) But the fact that Russell has already stated the next merge window is strictly for code consolidation already puts a stop sign in front of this patch :-) Still, Tony is the final judge. -- balbi ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: RX-51: Platform support for lp5523 2011-04-05 13:02 ` Felipe Balbi @ 2011-04-20 15:19 ` Tony Lindgren 0 siblings, 0 replies; 14+ messages in thread From: Tony Lindgren @ 2011-04-20 15:19 UTC (permalink / raw) To: Felipe Balbi; +Cc: Ameya Palande, Sebastian Reichel, linux-omap * Felipe Balbi <balbi@ti.com> [110405 06:00]: > > But the fact that Russell has already stated the next merge window is > strictly for code consolidation already puts a stop sign in front of > this patch :-) Still, Tony is the final judge. Yes this would be for the next merge window. It is still unclear what if any more platform data we want to merge. As stated, consolidation patches will be the highest priority right now. Tony ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2011-04-20 15:20 UTC | newest] Thread overview: 14+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-03-29 17:29 RX-51: Platform support for lp5523 Sebastian Reichel 2011-03-29 17:36 ` Tony Lindgren 2011-03-29 18:16 ` Sebastian Reichel 2011-03-29 19:33 ` Tony Lindgren 2011-03-31 12:20 ` Ameya Palande 2011-04-05 12:10 ` Ameya Palande 2011-04-05 12:19 ` Felipe Balbi 2011-04-05 12:23 ` Ameya Palande 2011-04-05 12:30 ` Felipe Balbi 2011-04-05 12:34 ` Ameya Palande 2011-04-05 12:38 ` Felipe Balbi 2011-04-05 12:59 ` Ameya Palande 2011-04-05 13:02 ` Felipe Balbi 2011-04-20 15:19 ` Tony Lindgren
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).