From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Avinash.H.M." Subject: Re: [PATCH 2/2 v2] OMAP2/3: hwmod: fix gpio-reset timeouts seen during bootup. Date: Thu, 7 Apr 2011 12:15:50 +0530 Message-ID: <20110407064550.GA19781@avinash-laptop> References: <1302018015-8858-1-git-send-email-avinashhm@ti.com> <1302018015-8858-3-git-send-email-avinashhm@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aog101.obsmtp.com ([74.125.149.67]:44625 "EHLO na3sys009aog101.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752155Ab1DGGqG (ORCPT ); Thu, 7 Apr 2011 02:46:06 -0400 Received: by gwb17 with SMTP id 17so1227902gwb.15 for ; Wed, 06 Apr 2011 23:46:03 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Gulati, Shweta" Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rajendra Nayak , Paul Walmsley , Benoit Cousson , Kevin Hilman On Wed, Apr 06, 2011 at 11:28:00AM +0530, Gulati, Shweta wrote: > Hi, > > On Tue, Apr 5, 2011 at 9:10 PM, Avinash.H.M wrote: > > GPIO module expects the debounce clocks to be enabled during reset. It doesn't > > reset properly and timeouts are seen, if this clock isn't enabled during > > reset. Add the HWMOD_CONTROL_OPT_CLKS_IN_RESET flags to the GPIO HWMODs, with > > which the debounce clocks are enabled during reset. > Minor comment, > Rephrase as " GPIO module doesn't reset properly and timeouts are seen > during bootup, if > debounce clock is not enabled" > to make commit log more clear. Hi Shweta , thanks for the review. i will fix the rephrase the change log . br , - avinash > > Cc: Rajendra Nayak > > Cc: Paul Walmsley > > Cc: Benoit Cousson > > Cc: Kevin Hilman > > Signed-off-by: Avinash.H.M