* [RFC/PATCH] arm: omap2plus: kill section mismatches
@ 2011-04-07 8:05 Felipe Balbi
2011-04-07 8:21 ` Santosh Shilimkar
0 siblings, 1 reply; 3+ messages in thread
From: Felipe Balbi @ 2011-04-07 8:05 UTC (permalink / raw)
To: Tony Lindgren; +Cc: Linux OMAP Mailing List, Felipe Balbi
Those were very simple to fix and while we should
be putting effort on code consolidation, having
a noisy compilation is very painful and makes it
more difficult to see newer warnings introduced
by re-factoring other code.
Signed-off-by: Felipe Balbi <balbi@ti.com>
---
arch/arm/mach-omap2/board-3430sdp.c | 10 +++++-----
arch/arm/mach-omap2/board-4430sdp.c | 8 ++++----
arch/arm/mach-omap2/board-omap4panda.c | 8 ++++----
3 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/arch/arm/mach-omap2/board-3430sdp.c b/arch/arm/mach-omap2/board-3430sdp.c
index 9afd087..5f15767 100644
--- a/arch/arm/mach-omap2/board-3430sdp.c
+++ b/arch/arm/mach-omap2/board-3430sdp.c
@@ -719,25 +719,25 @@ static struct omap_device_pad serial3_pads[] __initdata = {
OMAP_MUX_MODE0),
};
-static struct omap_board_data serial1_data = {
+static struct omap_board_data serial1_data __initdata = {
.id = 0,
.pads = serial1_pads,
.pads_cnt = ARRAY_SIZE(serial1_pads),
};
-static struct omap_board_data serial2_data = {
+static struct omap_board_data serial2_data __initdata = {
.id = 1,
.pads = serial2_pads,
.pads_cnt = ARRAY_SIZE(serial2_pads),
};
-static struct omap_board_data serial3_data = {
+static struct omap_board_data serial3_data __initdata = {
.id = 2,
.pads = serial3_pads,
.pads_cnt = ARRAY_SIZE(serial3_pads),
};
-static inline void board_serial_init(void)
+static inline void __init board_serial_init(void)
{
omap_serial_init_port(&serial1_data);
omap_serial_init_port(&serial2_data);
@@ -746,7 +746,7 @@ static inline void board_serial_init(void)
#else
#define board_mux NULL
-static inline void board_serial_init(void)
+static inline void __init board_serial_init(void)
{
omap_serial_init();
}
diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c
index 56702c5..ab701cd 100644
--- a/arch/arm/mach-omap2/board-4430sdp.c
+++ b/arch/arm/mach-omap2/board-4430sdp.c
@@ -736,25 +736,25 @@ static struct omap_device_pad serial4_pads[] __initdata = {
OMAP_PIN_OUTPUT | OMAP_MUX_MODE0),
};
-static struct omap_board_data serial2_data = {
+static struct omap_board_data serial2_data __initdata = {
.id = 1,
.pads = serial2_pads,
.pads_cnt = ARRAY_SIZE(serial2_pads),
};
-static struct omap_board_data serial3_data = {
+static struct omap_board_data serial3_data __initdata = {
.id = 2,
.pads = serial3_pads,
.pads_cnt = ARRAY_SIZE(serial3_pads),
};
-static struct omap_board_data serial4_data = {
+static struct omap_board_data serial4_data __initdata = {
.id = 3,
.pads = serial4_pads,
.pads_cnt = ARRAY_SIZE(serial4_pads),
};
-static inline void board_serial_init(void)
+static inline void __init board_serial_init(void)
{
struct omap_board_data bdata;
bdata.flags = 0;
diff --git a/arch/arm/mach-omap2/board-omap4panda.c b/arch/arm/mach-omap2/board-omap4panda.c
index f3a7b10..4573b96 100644
--- a/arch/arm/mach-omap2/board-omap4panda.c
+++ b/arch/arm/mach-omap2/board-omap4panda.c
@@ -551,25 +551,25 @@ static struct omap_device_pad serial4_pads[] __initdata = {
OMAP_PIN_OUTPUT | OMAP_MUX_MODE0),
};
-static struct omap_board_data serial2_data = {
+static struct omap_board_data serial2_data __initdata = {
.id = 1,
.pads = serial2_pads,
.pads_cnt = ARRAY_SIZE(serial2_pads),
};
-static struct omap_board_data serial3_data = {
+static struct omap_board_data serial3_data __initdata = {
.id = 2,
.pads = serial3_pads,
.pads_cnt = ARRAY_SIZE(serial3_pads),
};
-static struct omap_board_data serial4_data = {
+static struct omap_board_data serial4_data __initdata = {
.id = 3,
.pads = serial4_pads,
.pads_cnt = ARRAY_SIZE(serial4_pads),
};
-static inline void board_serial_init(void)
+static inline void __init board_serial_init(void)
{
struct omap_board_data bdata;
bdata.flags = 0;
--
1.7.4.1.343.ga91df
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC/PATCH] arm: omap2plus: kill section mismatches
2011-04-07 8:05 [RFC/PATCH] arm: omap2plus: kill section mismatches Felipe Balbi
@ 2011-04-07 8:21 ` Santosh Shilimkar
2011-04-07 8:23 ` Felipe Balbi
0 siblings, 1 reply; 3+ messages in thread
From: Santosh Shilimkar @ 2011-04-07 8:21 UTC (permalink / raw)
To: Felipe Balbi; +Cc: Tony Lindgren, Linux OMAP Mailing List
On 4/7/2011 1:35 PM, Felipe Balbi wrote:
> Those were very simple to fix and while we should
> be putting effort on code consolidation, having
> a noisy compilation is very painful and makes it
> more difficult to see newer warnings introduced
> by re-factoring other code.
>
> Signed-off-by: Felipe Balbi<balbi@ti.com>
> ---
I did post one for section mismatch already :)
http://www.spinics.net/lists/linux-omap/msg49557.html
Regards
Santosh
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC/PATCH] arm: omap2plus: kill section mismatches
2011-04-07 8:21 ` Santosh Shilimkar
@ 2011-04-07 8:23 ` Felipe Balbi
0 siblings, 0 replies; 3+ messages in thread
From: Felipe Balbi @ 2011-04-07 8:23 UTC (permalink / raw)
To: Santosh Shilimkar; +Cc: Felipe Balbi, Tony Lindgren, Linux OMAP Mailing List
On Thu, Apr 07, 2011 at 01:51:49PM +0530, Santosh Shilimkar wrote:
> On 4/7/2011 1:35 PM, Felipe Balbi wrote:
> >Those were very simple to fix and while we should
> >be putting effort on code consolidation, having
> >a noisy compilation is very painful and makes it
> >more difficult to see newer warnings introduced
> >by re-factoring other code.
> >
> >Signed-off-by: Felipe Balbi<balbi@ti.com>
> >---
> I did post one for section mismatch already :)
> http://www.spinics.net/lists/linux-omap/msg49557.html
oops, let's use that one instead :-)
--
balbi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-07 8:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-07 8:05 [RFC/PATCH] arm: omap2plus: kill section mismatches Felipe Balbi
2011-04-07 8:21 ` Santosh Shilimkar
2011-04-07 8:23 ` Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).