From: Tony Lindgren <tony@atomide.com>
To: "Manuel, Lesly Arackal" <leslyam@ti.com>
Cc: linux-omap@vger.kernel.org, Nishanth Menon <nm@ti.com>,
David Derrick <dderrick@ti.com>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH v9 4/9] OMAP3: PM: TWL4030 power scripts for OMAP3 boards
Date: Mon, 18 Apr 2011 15:58:20 +0300 [thread overview]
Message-ID: <20110418125820.GO12272@atomide.com> (raw)
In-Reply-To: <BANLkTinjkqmL5a2YQTnMYFSZt-11vRNy0w@mail.gmail.com>
* Manuel, Lesly Arackal <leslyam@ti.com> [110418 15:52]:
> >
> > To me it seems this should go into drivers/mfd instead.
> > The script may contain omap specific values, but can be
> > a loadable driver module.
>
> - subsys_initcall(twl_init)
> -> twl_probe()
> -> twl4030_power_init()
> -> load_twl4030_script() #to copy this script data to the PM IC.
>
> Since this is getting called from a subsys initcall, not sure whether
> we can make this scripts as loadable module.
AFAIK it does not need to do anything that early. Maybe take a look
at initialing it later?
Regards,
Tony
next prev parent reply other threads:[~2011-04-18 12:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-14 12:27 [PATCH v9 0/9] OMAP3: PM: TWL4030 power scripts and workaround for TWL erratum 27 Lesly A M
2011-04-14 12:27 ` [PATCH v9 1/9] OMAP3: PM: Fix for the TWL4030 sleep/wakeup sequence Lesly A M
2011-04-26 9:54 ` Samuel Ortiz
2011-04-14 12:27 ` [PATCH v9 2/9] OMAP3: PM: Correct the warning print during script loading Lesly A M
2011-04-26 9:57 ` Samuel Ortiz
2011-04-14 12:27 ` [PATCH v9 3/9] OMAP3: PM: Modifying the macro name Main_Ref to all caps Lesly A M
2011-04-26 10:07 ` Samuel Ortiz
2011-04-14 12:27 ` [PATCH v9 4/9] OMAP3: PM: TWL4030 power scripts for OMAP3 boards Lesly A M
2011-04-18 12:32 ` Tony Lindgren
2011-04-18 12:55 ` Manuel, Lesly Arackal
2011-04-18 12:58 ` Tony Lindgren [this message]
2011-04-27 12:59 ` Manuel, Lesly Arackal
2011-04-27 13:05 ` Tony Lindgren
2011-04-14 12:27 ` [PATCH v9 5/9] OMAP3: PM: TWL5030 version checking Lesly A M
2011-04-26 10:12 ` Samuel Ortiz
2011-04-14 12:27 ` [PATCH v9 6/9] MFD: TWL4030: workaround changes for TWL4030 Erratum 27 Lesly A M
2011-04-26 10:13 ` Samuel Ortiz
2011-04-27 14:24 ` Manuel, Lesly Arackal
2011-04-14 12:27 ` [PATCH v9 7/9] OMAP3430: Updating the board file to use TWL4030 scripts Lesly A M
2011-04-14 12:27 ` [PATCH v9 8/9] OMAP3630: " Lesly A M
2011-04-14 12:27 ` [PATCH v9 9/9] OMAP3: PM: TWL4030 optimizing resource configuration Lesly A M
2011-05-03 13:21 ` [PATCH v9 0/9] OMAP3: PM: TWL4030 power scripts and workaround for TWL erratum 27 Jean Pihet
2011-05-04 14:28 ` Manuel, Lesly Arackal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110418125820.GO12272@atomide.com \
--to=tony@atomide.com \
--cc=dderrick@ti.com \
--cc=leslyam@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).