From: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
To: Steve Calfee <stevecalfee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: balbi-l0cyMroinI0@public.gmane.org,
Keshava Munegowda <keshava_mgowda-l0cyMroinI0@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Anand Gadiyar <gadiyar-l0cyMroinI0@public.gmane.org>,
Partha Basak <p-basak2-l0cyMroinI0@public.gmane.org>,
axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
johnstul-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org,
mpfj-list-kZtEnBLzDKq1Qrn1Bg8BZw@public.gmane.org
Subject: Re: [PATCH] mfd: Fix usbhs_enable error handling
Date: Tue, 26 Apr 2011 22:34:09 +0300 [thread overview]
Message-ID: <20110426193407.GR13227@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <BANLkTi=NB5as-Kz8bSCvh3=KPQR1wwXUOQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Tue, Apr 26, 2011 at 08:09:17AM -0700, Steve Calfee wrote:
> On Tue, Apr 26, 2011 at 2:04 AM, Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org> wrote:
> > On Tue, Apr 26, 2011 at 02:32:04PM +0530, Keshava Munegowda wrote:
> >> > -----Original Message-----
> >> > From: Felipe Balbi [mailto:balbi-l0cyMroinI0@public.gmane.org]
> >> > Sent: Tuesday, April 26, 2011 2:29 PM
> >> > To: Keshava Munegowda
> >> > Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; balbi-l0cyMroinI0@public.gmane.org;
> >> gadiyar-l0cyMroinI0@public.gmane.org; p-
> >> > basak2-l0cyMroinI0@public.gmane.org; axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org; johnstul-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org;
> >> mpfj-list-kZtEnBLzDKq1Qrn1Bg8BZw@public.gmane.org
> >> > Subject: Re: [PATCH] mfd: Fix usbhs_enable error handling
> >> >
> >> > Hi,
> >> >
> >> > On Thu, Apr 21, 2011 at 07:52:41PM +0530, Keshava Munegowda wrote:
> >> > > From: Axel Lin <axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >> > >
> >> > > In the case of missing platform_data we do not hold a spin_lock,
> >> > > thus we should not call spin_unlock_irqrestore in the error path.
> >> > >
> >> > > Also simplify the error handling by separating the successful path
> >> > > from error path. I think this change improves readability.
> >> > >
> >> > > Signed-off-by: Axel Lin <axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >> >
> >> > Can someone give me a Tested-by so I can take these patches.
> >> >
> >> > --
> >> > Balbi
> >>
> >> Hi Balbi
> >>
> >> I have validated this patch and it works :)
> >>
> >> Tested-by: Keshava Munegowda <keshava_mgowda-l0cyMroinI0@public.gmane.org>
> >
> > what about the others ?
> >
> > --
> > balbi
>
> Hi Felipe,
>
> I responded on another thread. I tested this on a beagleboardxm on
> version 2.6.39-rc4
care to reply to this one with your Tested-by so I add to all patches
and queue them to Greg ?
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-04-26 19:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 14:22 [PATCH] mfd: Fix usbhs_enable error handling Keshava Munegowda
[not found] ` <1303395763-8702-1-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2011-04-21 14:22 ` [PATCH] omap:usb: fixing ehci phy gpio values for omap3 Keshava Munegowda
[not found] ` <1303395763-8702-2-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2011-04-21 14:22 ` [PATCH] omap:usb: add regulator support for EHCI Keshava Munegowda
[not found] ` <1303395763-8702-3-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2011-05-02 9:38 ` Felipe Balbi
2011-04-26 13:40 ` [PATCH] omap:usb: fixing ehci phy gpio values for omap3 Menon, Nishanth
[not found] ` <BANLkTi=fQCRAST1DvJEAnznNnySCv55Yag-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-04-27 5:52 ` Munegowda, Keshava
[not found] ` <BANLkTi=apB0cZpgzFjHKuArrxkQX5W7deQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-04-27 7:58 ` Felipe Balbi
[not found] ` <20110427075843.GS13227-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-04-27 8:26 ` Munegowda, Keshava
2011-05-02 9:38 ` Felipe Balbi
[not found] ` <20110502093815.GQ2529-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-05-02 11:31 ` Munegowda, Keshava
[not found] ` <BANLkTi=kH02P9GFo6wmPpRGr=L582DEp0A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-02 11:54 ` Felipe Balbi
2011-05-02 12:23 ` Munegowda, Keshava
2011-04-26 8:58 ` [PATCH] mfd: Fix usbhs_enable error handling Felipe Balbi
[not found] ` <20110426085846.GI13227-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-04-26 9:02 ` Keshava Munegowda
2011-04-26 9:04 ` Felipe Balbi
[not found] ` <20110426090418.GJ13227-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-04-26 15:09 ` Steve Calfee
[not found] ` <BANLkTi=NB5as-Kz8bSCvh3=KPQR1wwXUOQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-04-26 19:34 ` Felipe Balbi [this message]
[not found] ` <20110426193407.GR13227-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-04-26 20:57 ` Steve Calfee
2011-05-02 9:37 ` Felipe Balbi
[not found] <1301393275.2253.7.camel@phoenix>
2011-03-29 10:35 ` Keshava Munegowda
2011-03-29 11:06 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110426193407.GR13227@legolas.emea.dhcp.ti.com \
--to=balbi-l0cymroini0@public.gmane.org \
--cc=axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=gadiyar-l0cyMroinI0@public.gmane.org \
--cc=johnstul-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=keshava_mgowda-l0cyMroinI0@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mpfj-list-kZtEnBLzDKq1Qrn1Bg8BZw@public.gmane.org \
--cc=p-basak2-l0cyMroinI0@public.gmane.org \
--cc=stevecalfee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).